From: Stephane Grosjean <s.grosjean@peak-system.com>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards
Date: Fri, 03 Feb 2012 13:01:19 +0100 [thread overview]
Message-ID: <4F2BCC8F.1060402@peak-system.com> (raw)
In-Reply-To: <4F2BBE24.5090601@grandegger.com>
Le 03/02/2012 11:59, Wolfgang Grandegger a écrit :
>
> I mean, no support for the PCIEC
> if CAN_PEAK_PCIEC is not enabled.
... Hmm: I don't know how to do that without adding another
#ifdef/#endif block in the pci devices table:
static DEFINE_PCI_DEVICE_TABLE(peak_pci_tbl) = {
{PEAK_PCI_VENDOR_ID, PEAK_PCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
{PEAK_PCI_VENDOR_ID, PEAK_PCIE_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
{PEAK_PCI_VENDOR_ID, PEAK_MPCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
+#ifdef CONFIG_CAN_PEAK_PCIEC
{PEAK_PCI_VENDOR_ID, PEAK_PCIEC_DEVICE_ID, PCI_ANY_ID,
PCI_ANY_ID,},
+#endif
{0,}
};
I think that other blocks could be handled using Marc proposal (#define
peak_pciec_leds() (0) or (1)).
Will this be ok?
Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com
next prev parent reply other threads:[~2012-02-03 12:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 13:19 [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards Stephane Grosjean
2012-02-02 18:03 ` Oliver Hartkopp
2012-02-02 23:06 ` Oliver Hartkopp
2012-02-03 10:14 ` Stephane Grosjean
2012-02-03 10:19 ` Wolfgang Grandegger
2012-02-03 10:44 ` Stephane Grosjean
2012-02-03 10:59 ` Wolfgang Grandegger
2012-02-03 11:34 ` Stephane Grosjean
2012-02-03 12:01 ` Stephane Grosjean [this message]
2012-02-03 12:28 ` Wolfgang Grandegger
2012-02-03 13:02 ` Stephane Grosjean
2012-02-03 12:09 ` Stephane Grosjean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2BCC8F.1060402@peak-system.com \
--to=s.grosjean@peak-system.com \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).