Re: [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards

[Stephane Grosjean <s.grosjean@peak-system.com>]

Le 03/02/2012 13:28, Wolfgang Grandegger a écrit :
> On 02/03/2012 01:01 PM, Stephane Grosjean wrote:
>> Le 03/02/2012 11:59, Wolfgang Grandegger a écrit :
>>> I mean, no support for the PCIEC
>>> if CAN_PEAK_PCIEC is not enabled.
>> ... Hmm: I don't know how to do that without adding another
>> #ifdef/#endif block in the pci devices table:
>>
>> static DEFINE_PCI_DEVICE_TABLE(peak_pci_tbl) = {
>>          {PEAK_PCI_VENDOR_ID, PEAK_PCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
>>          {PEAK_PCI_VENDOR_ID, PEAK_PCIE_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
>>          {PEAK_PCI_VENDOR_ID, PEAK_MPCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
>> +#ifdef CONFIG_CAN_PEAK_PCIEC
>>          {PEAK_PCI_VENDOR_ID, PEAK_PCIEC_DEVICE_ID, PCI_ANY_ID,
>> PCI_ANY_ID,},
>> +#endif
>>          {0,}
>> };
> Fine for me! In principle the probe function could also just return
> -ENODEV. BTW: s/peak_pciec_init/peak_pciec_probe/ would now be perfect.
>

Well, always the same: depends whether the driver should be modprobe'd 
or not , during pci enum... What is the "approved"  way?
(_probe() failure could be nice to log a msg notifying to select the 
CONFIG_CAN_PEAK_PCIEC kernel option, to support the card...)

Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt 
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt 
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391 
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com