From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Stephane Grosjean <s.grosjean@peak-system.com>
Cc: linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH v2] can/sja1000: add support for PEAK-System PCMCIA card
Date: Fri, 03 Feb 2012 17:44:59 +0100 [thread overview]
Message-ID: <4F2C0F0B.5010607@hartkopp.net> (raw)
In-Reply-To: <1328281974-11761-1-git-send-email-s.grosjean@peak-system.com>
On 03.02.2012 16:12, Stephane Grosjean wrote:
> This patch adds the support of the PCAN-PC Card (PCMCIA) card from
> PEAK-System Technik (http://www.peak-system.com). The PCAN-PC Card is
> sja1000 based and exists in 1 or 2 channels.
>
> v2 changes:
> - no particular changes except fixing some coding style issues
(..)
> +static int pcan_add_channels(struct pcan_pccard *card)
> +{
> + struct pcmcia_device *pdev = card->pdev;
> + int i, err;
> + u8 ccr = PCC_CCR_INIT;
> +
drivers/net/can/sja1000/peak_pcmcia.c: In function 'pcan_add_channels':
drivers/net/can/sja1000/peak_pcmcia.c:573:2: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
Will test it on Monday as i do not have the hw at home ;-)
Tnx,
Oliver
next prev parent reply other threads:[~2012-02-03 16:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 15:12 [PATCH v2] can/sja1000: add support for PEAK-System PCMCIA card Stephane Grosjean
2012-02-03 16:44 ` Oliver Hartkopp [this message]
2012-02-06 16:03 ` Oliver Hartkopp
2012-02-06 17:05 ` Sven Geggus
2012-02-06 17:41 ` Oliver Hartkopp
[not found] ` <4F30F691.5070307@peak-system.com>
2012-02-07 13:13 ` About can/usb v4 patches serie Oliver Hartkopp
2012-02-07 13:43 ` Stephane Grosjean
2012-02-07 13:51 ` Oliver Hartkopp
2012-02-15 14:41 ` Stephane Grosjean
2012-02-15 20:05 ` Oliver Hartkopp
2012-02-10 11:00 ` can/sja1000: potential issue in sja1000.c? Stephane Grosjean
2012-02-10 11:16 ` Marc Kleine-Budde
2012-02-10 11:44 ` Wolfgang Grandegger
2012-02-10 15:32 ` Sebastian Haas
2012-02-10 15:37 ` Marc Kleine-Budde
2012-02-10 11:56 ` Wolfgang Grandegger
2012-02-10 15:39 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2C0F0B.5010607@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).