Re: [PATCH v6] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2320 bytes --]

On 02/13/2012 10:20 AM, Marc Kleine-Budde wrote:
> On 02/06/2012 04:46 PM, Stephane Grosjean wrote:
>> This patch adds the support for the following 3x sja1000 based PCI cards
>> from PEAK-System Technik (www.peak-system.com):
>>
>> PCAN-PCI Express (1 or 2 channels)
>> PCAN-ExpressCard (1 or 2 channels)
>> PCAN-miniPCI (1 or 2 channels)
>>
>> The PCAN-ExpressCard card needs I2C bit-banging interface, so it must be
>> explicitly selected. Doing this automatically selects I2C and I2C_ALGOBIT
>> bit-banging kernel configuration options.
>>
>> Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
>> Acked-by: Wolfgang Grandegger <wg@grandegger.com>
>> ---
>> v6 changes:
>> - the PCANExpressCard device id belongs to the module device id. table only if
>>   the kernel is configured for (see CONFIG_CAN_PEAK_PCIEC)
>>
>>  drivers/net/can/sja1000/Kconfig    |   18 +-
>>  drivers/net/can/sja1000/peak_pci.c |  509 +++++++++++++++++++++++++++++++++++-
>>  2 files changed, 510 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/net/can/sja1000/Kconfig b/drivers/net/can/sja1000/Kconfig
>> index 36e9d59..8116336 100644
>> --- a/drivers/net/can/sja1000/Kconfig
>> +++ b/drivers/net/can/sja1000/Kconfig
>> @@ -44,11 +44,23 @@ config CAN_EMS_PCI
>>  	  (http://www.ems-wuensche.de).
>>  
>>  config CAN_PEAK_PCI
>> -	tristate "PEAK PCAN PCI/PCIe Cards"
>> +	tristate "PEAK PCAN-PCI/PCIe/miniPCI Cards"
>>  	depends on PCI
>>  	---help---
>> -	  This driver is for the PCAN PCI/PCIe cards (1, 2, 3 or 4 channels)
>> -	  from PEAK Systems (http://www.peak-system.com).
>> +	  This driver is for the PCAN-PCI/PCIe/miniPCI cards
>> +	  (1, 2, 3 or 4 channels) from PEAK-System Technik
>> +	  (http://www.peak-system.com).
>> +
>> +config CAN_PEAK_PCIEC
>> +	bool "PEAK PCAN-ExpressCard Cards"
> 
> Is there a particular reason to make this bool, why not tristate? Todays
> dekstop distros usually build everything modular.

Where's my brown paper bag - Sorry for the noise. :)

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]