From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH v6] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards Date: Mon, 13 Feb 2012 10:24:57 +0100 Message-ID: <4F38D6E9.8060506@pengutronix.de> References: <1328543212-9016-1-git-send-email-s.grosjean@peak-system.com> <4F38D5F0.2070605@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigEA94F573DB19FEE9CA4F9B44" Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:36368 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753692Ab2BMJY6 (ORCPT ); Mon, 13 Feb 2012 04:24:58 -0500 In-Reply-To: <4F38D5F0.2070605@pengutronix.de> Sender: linux-can-owner@vger.kernel.org List-ID: To: Stephane Grosjean Cc: Oliver Hartkopp , linux-can Mailing List This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEA94F573DB19FEE9CA4F9B44 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 02/13/2012 10:20 AM, Marc Kleine-Budde wrote: > On 02/06/2012 04:46 PM, Stephane Grosjean wrote: >> This patch adds the support for the following 3x sja1000 based PCI car= ds >> from PEAK-System Technik (www.peak-system.com): >> >> PCAN-PCI Express (1 or 2 channels) >> PCAN-ExpressCard (1 or 2 channels) >> PCAN-miniPCI (1 or 2 channels) >> >> The PCAN-ExpressCard card needs I2C bit-banging interface, so it must = be >> explicitly selected. Doing this automatically selects I2C and I2C_ALGO= BIT >> bit-banging kernel configuration options. >> >> Signed-off-by: Stephane Grosjean >> Acked-by: Wolfgang Grandegger >> --- >> v6 changes: >> - the PCANExpressCard device id belongs to the module device id. table= only if >> the kernel is configured for (see CONFIG_CAN_PEAK_PCIEC) >> >> drivers/net/can/sja1000/Kconfig | 18 +- >> drivers/net/can/sja1000/peak_pci.c | 509 +++++++++++++++++++++++++++= ++++++++- >> 2 files changed, 510 insertions(+), 17 deletions(-) >> >> diff --git a/drivers/net/can/sja1000/Kconfig b/drivers/net/can/sja1000= /Kconfig >> index 36e9d59..8116336 100644 >> --- a/drivers/net/can/sja1000/Kconfig >> +++ b/drivers/net/can/sja1000/Kconfig >> @@ -44,11 +44,23 @@ config CAN_EMS_PCI >> (http://www.ems-wuensche.de). >> =20 >> config CAN_PEAK_PCI >> - tristate "PEAK PCAN PCI/PCIe Cards" >> + tristate "PEAK PCAN-PCI/PCIe/miniPCI Cards" >> depends on PCI >> ---help--- >> - This driver is for the PCAN PCI/PCIe cards (1, 2, 3 or 4 channels)= >> - from PEAK Systems (http://www.peak-system.com). >> + This driver is for the PCAN-PCI/PCIe/miniPCI cards >> + (1, 2, 3 or 4 channels) from PEAK-System Technik >> + (http://www.peak-system.com). >> + >> +config CAN_PEAK_PCIEC >> + bool "PEAK PCAN-ExpressCard Cards" >=20 > Is there a particular reason to make this bool, why not tristate? Today= s > dekstop distros usually build everything modular. Where's my brown paper bag - Sorry for the noise. :) Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enigEA94F573DB19FEE9CA4F9B44 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk841ukACgkQjTAFq1RaXHNhgQCePQ7fxssbA1OTFikzjGQuyoSJ KVoAn3u7YRyXXCskXsqYPNm+ycB9uHWz =GXBK -----END PGP SIGNATURE----- --------------enigEA94F573DB19FEE9CA4F9B44--