From: Stephane Grosjean <s.grosjean@peak-system.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: About peak_pci PATH v6.1
Date: Mon, 20 Feb 2012 12:25:24 +0100 [thread overview]
Message-ID: <4F422DA4.1080703@peak-system.com> (raw)
Hi Oliver,
I found that the i2c_transfer() is able to sleep, which is generally
*not* a good idea when in an interrupt context...
So, I changed the delay management with a delayed work mechanism. I
successfully tested the change on my testbed, but as you know, this is
not the best place for testing...
I hope you will be able to find some time to test that new patch.
@Marc: the peak_pci and peak_pcmcia patches bring modifications to the
can/sja1000 dir Kconfig and Makefile, So the apply sequence order is
critical (I mean, the peak_pci patch must be applied before the
peak_pcmcia, because of lines numbers). How to fix that? I first
proposed to use a serie of patches but this was not approved...
Regards,
Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com
next reply other threads:[~2012-02-20 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 11:25 Stephane Grosjean [this message]
2012-02-20 12:18 ` About peak_pci PATH v6.1 Marc Kleine-Budde
2012-02-20 13:25 ` Stephane Grosjean
2012-02-23 15:28 ` Stephane Grosjean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F422DA4.1080703@peak-system.com \
--to=s.grosjean@peak-system.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).