Re: [PATCH 0/3 v5] can/usb: Add PEAK-System PCAN USB adapters driver

[Stephane Grosjean <s.grosjean@peak-system.com>]

Le 22/02/2012 17:40, Oliver Hartkopp a écrit :
> On 22.02.2012 17:33, Stephane Grosjean wrote:
>
>> Le 22/02/2012 17:01, Oliver Hartkopp a écrit :
>>
>>> Pls try the following:
>>>
>>> PC1:
>>> can0 ->   usb-pro ch1 ----+
>>> can1 ->   usb-pro ch2 -+  |
>>> can2 ->   usb ---------+  |
>>>                        |  | 1Mpbs
>>> PC2:                 |  |
>>> can0 ->   pcmcia ch1 --+  |
>>> can1 ->   pcmcia ch2 -----+
>>>
>>> PC1:
>>> cangen -g0 -i can0
>>> cangen -g0 -i can1
>>> candump any
>>>
>>> PC2:
>>> cangen -g0 -i can0
>>> cangen -g0 -i can1
>>> candump any
>>>
>>> and then pull the usb-pro from PC1 ...
>>>
>>> That's really unfriendly 8-)
>>
>> Ok, I found another cable and set up your tesbed: now the usb-pro is pulled
>> and both "candump" always are displaying data sent by "cangen can0" from PC2
>> and read from pcan-usb on PC1... Both drivers can be removed without any problem.
>
> cangen can0 only on PC2?
>
> pls put the cangen on PC2 _and_ PC1 as shown above.
>

Sorry but your scheme showed cangen only on can0 and can1... which are 
mapped to usb-pro can interfaces. on PC1, which is pulled from PC1! So, 
no more can data is sent from PC1! Remains only "cangen can0" from PC2!
I just did another test, adding "cangen can2" on PC1 too... Everything 
is still ok, on both sides...

>
>>> Please check this use-case above. And when it works with your fixed driver you
>>> can probalby check the 'old' v5 version to see if you can follow my bug report
>>> on your setup.
>> ???
>> I'm sorry I don't understand what you mean: why should I check the v5 version?
>
> Didn't you write that you made some changes before the test??
>> And what is (to) "follow your bug report on my setup" ???
>
> I just wanted to make sure that you can see the same effect with your setup
> that i had with version 5.

Ok, confusion came from the fact that, once I did modifications into v5, 
this automatically became a "v6"  for me ...
So you want me to reproduce your crash using the "old" v5, right? I 
already did that, I confirm that the pc hanged with v5, removing the 
driver and/or pulling (one of) the usb adapters.

Should I now wait for any linux-usb ml review before posting this v6?

Regards,

Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt 
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt 
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391 
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com