About peak_pci PATCH v6.1

About peak_pci PATCH v6.1

[Stephane Grosjean]

Hi Oliver,

Thanks for your tests on usb adapters, I'll have a look to these diags.
Did you also plan to test the pciec card under heavy traffic? I would 
like to close that problem first...

>
> I found that the i2c_transfer() is able to sleep, which is generally *not* a good idea when in an interrupt context...
> So, I changed the delay management with a delayed work mechanism. I successfully tested the change on my testbed,
 > but as you know, this is not the best place for testing...
>
> I hope you will be able to find some time to test that new patch.
>

Regards,

Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt 
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt 
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391 
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com

Re: About peak_pci PATCH v6.1

[Oliver Hartkopp]

On 22.02.2012 09:59, Stephane Grosjean wrote:

> Did you also plan to test the pciec card under heavy traffic? I would like to
> close that problem first...


Unfortunately i didn't find the time @work, where i have the PCIeC slot to
test. Will do tomorrow.

Regards,
Oliver

Testing peak_pci v6.1 / peak_usb v6 / peak_pcmcia v4.1

[Oliver Hartkopp]

Hello Stephane,

you can add to all these drivers

- peak_pci v6.1 (http://marc.info/?l=linux-can&m=132973636320107&w=2)
- peak_usb v6 (http://marc.info/?l=linux-can&m=132998590401560&w=2)
- peak_pcmcia v4.1 (http://marc.info/?l=linux-pcmcia&m=132938721324159&w=2)

my

Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>

Very impressive! Whatever i tried - i didn't run into any problem with
plugging / unplugging all of these interfaces (with & without traffic load).

Testbed was:

peak_pci 0000:0e:00.0: can0 at reg_base=0xf827e000 cfg_base=0xf814e000 irq=19
peak_pci 0000:0e:00.0: can1 at reg_base=0xf827e400 cfg_base=0xf814e000 irq=19
peak_pcmcia 0.0: PEAK-System pcmcia card PC_CAN_CARD fw 1.5
peak_pcmcia 0.0: can2 on channel 0 at 0x00012100 irq 19
peak_pcmcia 0.0: can3 on channel 1 at 0x00012120 irq 19
peak_usb 2-2:1.0: PEAK-System PCAN-USB Pro hwrev 0 serial FFFFFFFF.00000001 (2 channels)
peak_usb 2-2:1.0: can4: attached to PCAN-USB Pro channel 0 (device 1)
peak_usb 2-2:1.0: can5: attached to PCAN-USB Pro channel 1 (device 0)
peak_usb 5-1:1.0: PEAK-System PCAN-USB adapter hwrev 28 serial FFFFFFFF (1 channel)
peak_usb 5-1:1.0: can6: attached to PCAN-USB channel 0 (device 46)

can0 - can2 - can4 - can6 - PEAK MicroMod (for 100% busload)
can1 - can3 - can5

Just two nitpicks:

When having traffic the LEDs from the PCIeC are flashing faster than the PCMCIA LEDs.
With no traffic and interface is up, they are flashing with the same frequency.

The other one:

usb 2-2: new high-speed USB device number 4 using ehci_hcd
usb 2-2: config 1 interface 0 altsetting 0 bulk endpoint 0x83 has invalid maxpacket 64
usb 2-2: config 1 interface 1 altsetting 0 bulk endpoint 0x86 has invalid maxpacket 64
peak_usb 2-2:1.0: PEAK-System PCAN-USB Pro hwrev 0 serial FFFFFFFF.00000001 (2 channels)
peak_usb 2-2:1.0: can4: attached to PCAN-USB Pro channel 0 (device 1)
peak_usb 2-2:1.0: can5: attached to PCAN-USB Pro channel 1 (device 0)
usbcore: registered new interface driver peak_usb

Do you have any idea what 

"altsetting 0 bulk endpoint 0x83 has invalid maxpacket 64"

means?

Is this something that's caused by your driver or it is caused by the
hardware configuration of the USBpro adapter? I assume it's the latter. 

Regards,
Oliver

Re: Testing peak_pci v6.1 / peak_usb v6 / peak_pcmcia v4.1

[Stephane Grosjean]

Hi Oliver,

Le 23/02/2012 14:44, Oliver Hartkopp a écrit :
> Hello Stephane,
>
> you can add to all these drivers
>
> - peak_pci v6.1 (http://marc.info/?l=linux-can&m=132973636320107&w=2)
> - peak_usb v6 (http://marc.info/?l=linux-can&m=132998590401560&w=2)
> - peak_pcmcia v4.1 (http://marc.info/?l=linux-pcmcia&m=132938721324159&w=2)
>
> my
>
> Tested-by: Oliver Hartkopp<socketcan@hartkopp.net>

Thanks for all of your precious time.

> Just two nitpicks:
>
> When having traffic the LEDs from the PCIeC are flashing faster than the PCMCIA LEDs.
> With no traffic and interface is up, they are flashing with the same frequency.

... I should check whether the two boards use the same chip to control 
the LEDs... But I think that the word "nitpicks" was especially invented 
for that particular issue ;-)

> The other one:
>
> usb 2-2: new high-speed USB device number 4 using ehci_hcd
> usb 2-2: config 1 interface 0 altsetting 0 bulk endpoint 0x83 has invalid maxpacket 64
> usb 2-2: config 1 interface 1 altsetting 0 bulk endpoint 0x86 has invalid maxpacket 64
> peak_usb 2-2:1.0: PEAK-System PCAN-USB Pro hwrev 0 serial FFFFFFFF.00000001 (2 channels)
> peak_usb 2-2:1.0: can4: attached to PCAN-USB Pro channel 0 (device 1)
> peak_usb 2-2:1.0: can5: attached to PCAN-USB Pro channel 1 (device 0)
> usbcore: registered new interface driver peak_usb
>
> Do you have any idea what
>
> "altsetting 0 bulk endpoint 0x83 has invalid maxpacket 64"
>
> means?
>
> Is this something that's caused by your driver or it is caused by the
> hardware configuration of the USBpro adapter? I assume it's the latter.

Yes you're right. These msgs are printed by the usb-core, before the 
_probe() function of the driver is called. It is something I will send 
back to our hw team...

> Regards,
> Oliver
>


Best regards,

Stéphane

--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt 
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt 
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391 
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com