From: Stephane Grosjean <s.grosjean@peak-system.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: About peak_pci PATH v6.1
Date: Thu, 23 Feb 2012 16:28:54 +0100 [thread overview]
Message-ID: <4F465B36.40904@peak-system.com> (raw)
In-Reply-To: <4F423A2E.3030806@pengutronix.de>
Hi Marc,
Le 20/02/2012 13:18, Marc Kleine-Budde a écrit :
>> @Marc: the peak_pci and peak_pcmcia patches bring modifications to the
>> can/sja1000 dir Kconfig and Makefile, So the apply sequence order is
>> critical (I mean, the peak_pci patch must be applied before the
>> peak_pcmcia, because of lines numbers). How to fix that? I first
>> proposed to use a serie of patches but this was not approved...
> I think due to my too short answer there was a misunderstanding. IIRC in
> one patch you 1. fixed a problem (which is already in mainline) and 2.
> introduced a new feature. This is why I asked for separate patches. All
> changes can still go into a series.
>
> I already added your "add support for PEAK-System PCIe/PCIeC/miniPCI
> cards" patch to can-next/master, but If you now have a better version,
> I'll force update the branch.
>
So what's your opinion about that new serie?
0001 which contains Kconfig changes (pci+pciec+pcmcia)
0002 contains peak_pci modifications (+pciec,...)
0002 contains Makefile "pcmcia.o" adding + peak_pcmcia
???
Moreover, is that new format compatible with the previous pci-related
patch you pushed before?
Regards,
Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com
prev parent reply other threads:[~2012-02-23 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 11:25 About peak_pci PATH v6.1 Stephane Grosjean
2012-02-20 12:18 ` Marc Kleine-Budde
2012-02-20 13:25 ` Stephane Grosjean
2012-02-23 15:28 ` Stephane Grosjean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F465B36.40904@peak-system.com \
--to=s.grosjean@peak-system.com \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).