From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Stephane Grosjean <s.grosjean@peak-system.com>
Subject: Re: [PATCH 1/2] can/peak_pci: add support of some new PEAK-System PCI cards
Date: Thu, 01 Mar 2012 18:18:22 +0100 [thread overview]
Message-ID: <4F4FAF5E.3070605@hartkopp.net> (raw)
In-Reply-To: <4F4FADF0.3070401@pengutronix.de>
On 01.03.2012 18:12, Marc Kleine-Budde wrote:
> On 02/27/2012 04:52 PM, Stephane Grosjean wrote:
>> This patch adds the support of some new PEAK-System PCI cards in the CAN
>> network sub-system. These are:
>>
>> PCAN-PCIeC (PCI-ExpressCard)
>> PCAN-mminiPCI (mini-PCI)
>> PCAN-PCI (PCI next-gen)
>>
>> This patch also adds the control of the blinking leds of the PCAN-PCIeC.
>>
>> Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
>> Acked-by: Wolfgang Grandegger <wg@grandegger.com>
>> Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
>> ---
>> Note: that patch contains modifications tested and approved in
>> peak_pci v6.1 but also includes Kconfig and Makefile modifications
>> from peak_pcmcia v4.1
>>
>
> Sorry, that series is not bisectable. At least if you switch on the
> CONFIG_CAN_PEAK_PCMCIA option.
>
Is this due to the fact that the both Kconfig entries are placed in the first
file?
I asked myself, why this was optimized in this way. IMO adding
1. PCIEC support
2. PCMCIA support
within two patches would be better, right?
Regards,
Oliver
next prev parent reply other threads:[~2012-03-01 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 15:52 [PATCH 1/2] can/peak_pci: add support of some new PEAK-System PCI cards Stephane Grosjean
2012-03-01 17:12 ` Marc Kleine-Budde
2012-03-01 17:18 ` Oliver Hartkopp [this message]
2012-03-01 17:27 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4FAF5E.3070605@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).