From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Stephane Grosjean <s.grosjean@peak-system.com>
Subject: Re: [PATCH 1/2] can/peak_pci: add support of some new PEAK-System PCI cards
Date: Thu, 01 Mar 2012 18:27:18 +0100 [thread overview]
Message-ID: <4F4FB176.8020003@pengutronix.de> (raw)
In-Reply-To: <4F4FAF5E.3070605@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]
On 03/01/2012 06:18 PM, Oliver Hartkopp wrote:
> On 01.03.2012 18:12, Marc Kleine-Budde wrote:
>
>> On 02/27/2012 04:52 PM, Stephane Grosjean wrote:
>>> This patch adds the support of some new PEAK-System PCI cards in the CAN
>>> network sub-system. These are:
>>>
>>> PCAN-PCIeC (PCI-ExpressCard)
>>> PCAN-mminiPCI (mini-PCI)
>>> PCAN-PCI (PCI next-gen)
>>>
>>> This patch also adds the control of the blinking leds of the PCAN-PCIeC.
>>>
>>> Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
>>> Acked-by: Wolfgang Grandegger <wg@grandegger.com>
>>> Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
>>> ---
>>> Note: that patch contains modifications tested and approved in
>>> peak_pci v6.1 but also includes Kconfig and Makefile modifications
>>> from peak_pcmcia v4.1
>>>
>
>>
>> Sorry, that series is not bisectable. At least if you switch on the
>> CONFIG_CAN_PEAK_PCMCIA option.
>>
>
>
> Is this due to the fact that the both Kconfig entries are placed in the first
> file?
Yes, but not :)
Adding the Kconfig option and this Makefile line:
+obj-$(CONFIG_CAN_PEAK_PCMCIA) += peak_pcmcia.o
but no .c file would result in a compilation error if you swtich on the
Kconfig option.
> I asked myself, why this was optimized in this way. IMO adding
>
> 1. PCIEC support
> 2. PCMCIA support
>
> within two patches would be better, right?
Yes:
1. add PCIEC in Kconfig + .c file changes
2. add PCMCIA in Kconfig and Makefile + new .c file
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2012-03-01 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 15:52 [PATCH 1/2] can/peak_pci: add support of some new PEAK-System PCI cards Stephane Grosjean
2012-03-01 17:12 ` Marc Kleine-Budde
2012-03-01 17:18 ` Oliver Hartkopp
2012-03-01 17:27 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4FB176.8020003@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).