Re: can: usb: PEAK-System Technik PCAN-USB specific part

[Stephane Grosjean <s.grosjean@peak-system.com>]

Le 07/03/2012 10:24, Marc Kleine-Budde a écrit :
> On 03/07/2012 09:56 AM, Stephane Grosjean wrote:
> Le 06/03/2012 12:21, Dan Carpenter a écrit :
>>> Hello Stephane Grosjean,
>>>
>>> The patch 46be265d3388: "can: usb: PEAK-System Technik PCAN-USB
>>> specific part" from Mar 2, 2012, leads to the following warning:
>>>
>>> drivers/net/can/usb/peak_usb/pcan_usb.c:751 pcan_usb_encode_msg()
>>>       error: wrong number of bits for 'cpu_to_le32' (16 vs 32)
>>>
>>> drivers/net/can/usb/peak_usb/pcan_usb.c
>>>      742          /* can id */
>>>      743          if (cf->can_id&   CAN_EFF_FLAG) {
>>>      744                  __le32 tmp32 = cpu_to_le32(cf->can_id&
>>> CAN_ERR_MASK);
>>>      745
>>>      746                  tmp32<<= 3;
>>>      747                  *pc |= PCAN_USB_STATUSLEN_EXT_ID;
>>>      748                  memcpy(++pc,&tmp32, 4);
>>>      749                  pc += 4;
>>>      750          } else {
>>>      751                  __le16 tmp16 = cpu_to_le32(cf->can_id&
>>> CAN_ERR_MASK);
>>>                           ^^^^^^^^^^^^
>>> A little endian 32 bit can't fit here.
>>
>> How may this error happen while it didn't before? Is this is due to some
>> (new) options of gcc, or because of a new version used? In the future,
>> how could I avoid that? I mean, how to synchronize with the final GCC
>> options/version?
> There's no final gcc version. Gcc and the kernel will always evolve.


Yes I know, this is Ok... But the question is: how did that guy manage 
to get that error? I "git pull"ed my own linux-can-next then rebuilt my 
drivers and don't even see that error!
I suppose that he set some flags somewhere in the Kernel Makefile(s), 
but where? How can I know whether my next patch will fail or not in his 
configuration?

Thanks for your reply,

Stéphane


--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt 
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt 
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391 
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com