On 03/20/2012 10:47 AM, yegorslists@googlemail.com wrote: > From: Yegor Yefremov > > Signed-off-by: Yegor Yefremov Looks a bit ugly to me (as a non Android developer) repeating some variables so many times. Is it usual to write android makefiles like this? There are some trailing whitespaces. No need to recommit the patch, I've removed them. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |