On 03/22/2012 11:15 AM, Yegor Yefremov wrote: > Am 20.03.2012 11:08, schrieb Marc Kleine-Budde: >> On 03/20/2012 10:47 AM, yegorslists@googlemail.com wrote: >>> From: Yegor Yefremov >>> >>> Signed-off-by: Yegor Yefremov >> >> Looks a bit ugly to me (as a non Android developer) repeating some >> variables so many times. Is it usual to write android makefiles like this? > > Yes, it is really ugly :-( I'd like Android to have Buildroot like > build system, so that native autotools/cmake/ etc. could be used > directly. I've looked at other external packages in Android and took > their Android.mk as a template. Okay...seems you know what you're doing :) >> There are some trailing whitespaces. No need to recommit the patch, I've >> removed them. > > Working with quilt was easier regarding trailing white spaces. I'm > looking for git way of removing them. > > I've seen the first patch committed, this is one is still not > committed as far as I can see. Do I need to rework something? No - I just wanted to have a statement on the ugliness :) I'll commit the patch now. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |