Re: [RFC PATCH] can: add tx/rx led trigger support

[Wolfgang Grandegger <wg@grandegger.com>]

On 04/11/2012 08:29 PM, Oliver Hartkopp wrote:
> On 11.04.2012 19:58, Fabio Baltieri wrote:
> 
> 
>> On Wed, Apr 11, 2012 at 8:14 AM, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
> 
>>> I wonder if it makes more sense to add the LED trigger stuff into
>>> drivers/net/can/dev.c ?!?
>>
>> Of course that seems to be the obvious (=correct) place to trap this
>> stuff. The reason why I worked on upper layer is that I did not found
>> any generic place to trap tx/rx events in the dev file without
>> modifying every device driver, as while tx can be trapped in
>> can_get_echo_skb(), rx frames are handled directly to the network
>> layer.
> 
> 
> I think that depends heavily on the driver and therefore adding the
> can_led_tx() and can_led_rx() calls to the appropriate places is the most
> transparent implementation.

I would prefer to implement can_led_trigger (or can_led_event) passing a
mask defining the event (RX, TX or event something else).

Wolfgang.