Re: [RFC PATCH] can: add tx/rx led trigger support

[Oliver Hartkopp <socketcan@hartkopp.net>]

>>> Is the LED "blinking" on traffic or is it just "on" for some time when a
>>> CAN frame is processed?
>>
>> It stays on for some time after each frame. Above a certain
>> packet-rate (1/led_off_delay) LED appear to be constantly on. You can
>> tell periodic packets from bursts from it but nothing more.
> 
> I think a Tx or Rx trigger should just "start" one LED blink, e.g. ON for 
> 100ms and OFF for 100ms no matter if other packets being processed. This way 
> you will constantly see a LED blinking if a specific load is exceeded. If it 
> is at lower rate the LED will blink more rarely.
> You could even go one step further and activate a LED if the CAN interface is 
> UP and turn it off for some time if there is some traffic. So the LED could 
> inidicate if the interface is being used and/or if there is some traffic.


Hi Alexander,

the latter is implemented in my WIFI LED in my notebook:

Interface up -> LED is ON

Interface traffic -> LED is doing a off-on-sequence which leads to constant
blinking when downloading files ...

Nice idea.

Regards,
Oliver