Re: [PATCH] candump: resolve signedness warnings

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

On 04/19/2012 09:44 AM, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

nbytes has been tested before if it's < 0, so it's safe to cast it to an
unsigned value.

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Oliver do you want to take the patch?

Marc

> ---
>  candump.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/candump.c b/candump.c
> index 5ba9431..ac51192 100644
> --- a/candump.c
> +++ b/candump.c
> @@ -611,7 +611,7 @@ int main(int argc, char **argv)
>  					return 1;
>  				}
>  
> -				if (nbytes < sizeof(struct can_frame)) {
> +				if ((size_t)nbytes < sizeof(struct can_frame)) {
>  					fprintf(stderr, "read: incomplete CAN frame\n");
>  					return 1;
>  				}
> @@ -627,7 +627,7 @@ int main(int argc, char **argv)
>  					if (nbytes < 0) {
>  						perror("bridge write");
>  						return 1;
> -					} else if (nbytes < sizeof(struct can_frame)) {
> +					} else if ((size_t)nbytes < sizeof(struct can_frame)) {
>  						fprintf(stderr,"bridge write: incomplete CAN frame\n");
>  						return 1;
>  					}


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]