Re: [PATCH] can: flexcan: add PM support

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2169 bytes --]

On 05/08/2012 05:12 PM, Eric Bénard wrote:
> tested on an i.MX257

What about the transceiver? Does is make sense to switch it off, too?

Marc

> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
>  drivers/net/can/flexcan.c |   38 ++++++++++++++++++++++++++++++++++++++
>  1 files changed, 38 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index 1efb083..0d058b0 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -1050,6 +1050,42 @@ static struct of_device_id flexcan_of_match[] = {
>  	{},
>  };
>  
> +#ifdef CONFIG_PM
> +static int flexcan_suspend(struct platform_device *pdev, pm_message_t state)
> +{
> +	struct net_device *dev = platform_get_drvdata(pdev);
> +	struct flexcan_priv *priv = netdev_priv(dev);
> +
> +	flexcan_chip_disable(priv);
> +
> +	if (netif_running(dev)) {
> +		netif_stop_queue(dev);
> +		netif_device_detach(dev);
> +	}
> +	priv->can.state = CAN_STATE_SLEEPING;
> +
> +	return 0;
> +}
> +
> +static int flexcan_resume(struct platform_device *pdev)
> +{
> +	struct net_device *dev = platform_get_drvdata(pdev);
> +	struct flexcan_priv *priv = netdev_priv(dev);
> +
> +	priv->can.state = CAN_STATE_ERROR_ACTIVE;
> +	if (netif_running(dev)) {
> +		netif_device_attach(dev);
> +		netif_start_queue(dev);
> +	}
> +	flexcan_chip_enable(priv);
> +
> +	return 0;
> +}
> +#else
> +#define flexcan_suspend NULL
> +#define flexcan_resume NULL
> +#endif
> +
>  static struct platform_driver flexcan_driver = {
>  	.driver = {
>  		.name = DRV_NAME,
> @@ -1058,6 +1094,8 @@ static struct platform_driver flexcan_driver = {
>  	},
>  	.probe = flexcan_probe,
>  	.remove = __devexit_p(flexcan_remove),
> +	.suspend = flexcan_suspend,
> +	.resume = flexcan_resume,
>  };
>  
>  module_platform_driver(flexcan_driver);


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]