From: Marc Kleine-Budde <mkl@pengutronix.de>
To: AnilKumar Ch <anilkumar@ti.com>
Cc: wg@grandegger.com, linux-can@vger.kernel.org, anantgole@ti.com,
nsekhar@ti.com
Subject: Re: [PATCH v2 2/4] can: c_can: fix: enable CAN HW interrupts after napi_enable()
Date: Thu, 10 May 2012 21:16:55 +0200 [thread overview]
Message-ID: <4FAC1427.7070708@pengutronix.de> (raw)
In-Reply-To: <1336649657-4152-3-git-send-email-anilkumar@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]
On 05/10/2012 01:34 PM, AnilKumar Ch wrote:
> Fix the issue of C_CAN interrupts getting disabled forever even though
> we do can configuration multiple times using can utils. According to
> NAPI usage we disable all the hardware interrupts in ISR and re-enable
> them in poll(). Current implementation calls napi_enable() after hardware
> interrupts are enabled. If we get any interrupts between these two steps
> then we do not process those interrupts because napi is not enabled. Mostly
> these interrupts come because of STATUS is not 0x7 or ERROR interrupts. If
> napi_enable() happens before hardware interrupts enabled then c_can_poll()
> function will be called eventual re-enabling of interrupts will happen.
>
> This patch moves the napi_enable() call before interrupts enabled.
>
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
Please test on c_can, also this is a stable candidate. What about add
the term "race condition" to the subject?
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-05-10 19:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 11:34 [PATCH v2 0/4] can: c_can: Add support for Bosch D_CAN controller AnilKumar Ch
2012-05-10 11:34 ` [PATCH v2 1/4] can: c_can: fix an interrupt thrash issue with c_can driver AnilKumar Ch
2012-05-10 19:13 ` Marc Kleine-Budde
2012-05-10 11:34 ` [PATCH v2 2/4] can: c_can: fix: enable CAN HW interrupts after napi_enable() AnilKumar Ch
2012-05-10 19:16 ` Marc Kleine-Budde [this message]
2012-05-11 11:09 ` AnilKumar, Chimata
2012-05-10 11:34 ` [PATCH v2 3/4] can: c_can: Move overlay structure to array with offset as index AnilKumar Ch
2012-05-10 20:12 ` Marc Kleine-Budde
2012-05-11 11:09 ` AnilKumar, Chimata
2012-05-11 14:40 ` Wolfgang Grandegger
2012-05-11 15:23 ` AnilKumar, Chimata
2012-05-11 16:54 ` Marc Kleine-Budde
2012-05-10 11:34 ` [PATCH v2 4/4] can: c_can: Add support for Bosch D_CAN controller AnilKumar Ch
2012-05-10 19:34 ` Marc Kleine-Budde
2012-05-11 11:10 ` AnilKumar, Chimata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAC1427.7070708@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=anantgole@ti.com \
--cc=anilkumar@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).