From: Oliver Hartkopp <socketcan@hartkopp.net>
To: yegorslists@googlemail.com
Cc: linux-can@vger.kernel.org
Subject: Re: socketcan: license issues
Date: Tue, 12 Jun 2012 10:45:57 +0200 [thread overview]
Message-ID: <4FD701C5.6010207@hartkopp.net> (raw)
In-Reply-To: <1339484312-4281-1-git-send-email-yegorslists@googlemail.com>
On 12.06.2012 08:58, yegorslists@googlemail.com wrote:
> During my effort bringing SocketCAN to Android I encountered following issue: Android devs found out that SocketCAN headers are not licensed as GPL2. See discussion here https://android-review.googlesource.com/#/c/34510/
>
> I added GPL2 notion to the headers. Is it O.K. the way I made it or should we make this consistent for all SocketCAN files including the drivers?
Hello Yegor,
the stuff which is inside the kernel is GPL source.
No need to put any effort to change copyright notices in Kernel headers.
The Android guys can pick the headers as-is. They did it with xattr.h too:
See
https://github.com/android/platform_bionic/blob/master/libc/kernel/common/linux/xattr.h
and the original header starts with
/*
File: linux/xattr.h
Extended attributes handling.
Copyright (C) 2001 by Andreas Gruenbacher <a.gruenbacher@computer.org>
Copyright (c) 2001-2002 Silicon Graphics, Inc. All Rights Reserved.
Copyright (c) 2004 Red Hat, Inc., James Morris <jmorris@redhat.com>
*/
http://lxr.linux.no/#linux+v3.4.2/include/linux/xattr.h
which also includes a copyright and "All rights reserved" message from SGI.
So why is there any problem with can.h when there was no problem with xattr.h?
The CAN subsystem is licensed by Volkswagen under GPL/BSD - the Android guys
are hereby invited to pick the headers for their libs - even when i personally
think, that their header cleaning process is a bad message for contributing
developers.
Regards,
Oliver
prev parent reply other threads:[~2012-06-12 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 6:58 socketcan: license issues yegorslists
2012-06-12 6:58 ` [PATCH] socketcan: provide GPL2 notion for the headers yegorslists
2012-06-12 7:21 ` Marc Kleine-Budde
2012-06-12 8:45 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD701C5.6010207@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).