Re: [PATCH 4/4] can: flexcan: add transceiver switch support when use device tree

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1349 bytes --]

On 06/27/2012 10:19 AM, Hui Wang wrote:
> Some platforms (like i.MX6) has an external PHY, the PHY is operated
> by some gpios. If the system registers a platform_data, we can
> set a callback function pointer to pdata->transceiver_switch to
> implement PHY switch. If we use device tree, we couldn't pass
> platform_data to the driver, so i move the switch function to the
> driver and add device tree entries to let user set which gpios
> are used to operate PHY.
> 
> This design doesn't break existing platforms, if a platform doesn't
> need PHY switch, it doesn't need to set dt entries just as before,
> if a platform has platform_data, the pdata->transceiver_switch has
> higher priority.
> 
> Cc: linux-can@vger.kernel.org
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Hui Wang <jason77.wang@gmail.com>

please coordinate whith Shawn Guo, he has posted a similar patch some
days ago. http://www.spinics.net/lists/netdev/msg202442.html

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]