From: Hui Wang <jason77.wang@gmail.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Shawn Guo <shawn.guo@linaro.org>,
Hui Wang <jason77.wang@gmail.com>,
mkl@pengutronix.de, wg@grandegger.com, linux-can@vger.kernel.org
Subject: Re: [PATCH] can: flexcan: use of_property_read_u32 to avoid endian problem
Date: Thu, 28 Jun 2012 13:18:19 +0800 [thread overview]
Message-ID: <4FEBE91B.3020709@gmail.com> (raw)
In-Reply-To: <4FEBE648.7040007@hartkopp.net>
Oliver Hartkopp wrote:
> The first patch (you wanted to superseed) has already been pulled from Dave
> Miller, see:
>
> http://git.kernel.org/?p=linux/kernel/git/davem/net.git;a=commitdiff;h=85f2f834e85517307f13e30e630a5fc86f757cb5
>
> If you want to update your patch you need to do this based on your already
> accepted patch.
>
Got it, i will generate an incremental patch basing on it.
> Regards,
> Oliver
>
> Btw. no need to put Dave Miller in all your CAN-related postings in CC. He
> get's hundreds of mails each day ...
>
OK.
Regards,
Hui.
> On 28.06.2012 05:32, Shawn Guo wrote:
>
>
>> On 28 June 2012 10:58, Hui Wang <jason77.wang@gmail.com> wrote:
>>
>>> Use of_property_read_u32() to get DT value can avoid endian problems,
>>> this is needed since this driver can run on powerpc (be) and arm (le).
>>>
>>> No need to check ret value here since we will check the got value to
>>> verify if users pass a valid value in the DT.
>>>
>>> Cc: linux-can@vger.kernel.org
>>> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
>>> Cc: David S. Miller <davem@davemloft.net>
>>> Cc: Shawn Guo <shawn.guo@linaro.org>
>>>
>> Reviewed-by: Shawn Guo <shawn.guo@linaro.org>
>>
>>
>>> Cc: Wolfgang Grandegger <wg@grandegger.com>
>>> Signed-off-by: Hui Wang <jason77.wang@gmail.com>
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-can" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>
>
prev parent reply other threads:[~2012-06-28 5:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 2:58 [PATCH] can: flexcan: use of_property_read_u32 to avoid endian problem Hui Wang
2012-06-28 3:32 ` Shawn Guo
2012-06-28 5:06 ` Oliver Hartkopp
2012-06-28 5:18 ` Hui Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEBE91B.3020709@gmail.com \
--to=jason77.wang@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).