Re: can-next pull request for CAN ID Ematch

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

On 07/04/2012 08:03 AM, Oliver Hartkopp wrote:
> Hi all,
> 
> the pull location is still valid :-)
> 
> Btw. i needed to change a minor thing as the em_canid_match() function did
> not handle the case that the same CAN-ID can be SFF or EFF ...
> 
> The option to support the CAN_EFF_FLAG cleared in the can_mask is broken,
> unusual and can not be handled in a simple way.
> 
> The tc tool can handle eff and sff rules - and so i did it in the
> em_canid_change() function now. No support for CAN_EFF_FLAG cleared in the
> can_mask - just check the CAN_EFF_FLAG in the filter.can_id to decide the
> rules type.

I hope I took the correct patch. Please check the for-davem branch in my
gitorious repo[1].

I've changed some things in the commit:
- credited Rostislav Lisovy as the original author.
  (git commit --amend --author="Rostislav Lisovy <lisovy@gmail.com>")
- added a "net:" in the Subject line
- Fixed coding style issue in pkt_cls.h
  all defines indent now with a tab

The patch currently has these S-o-bs:

    Signed-off-by: Rostislav Lisovy <lisovy@gmail.com>
    Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

Oliver, if you want to credit your changes I can add a oneliner between
Rostislav's and your S-o-b, which may look like this:

[Oliver: fixed random stuff]

Marc

cheers, Marc

[1] https://gitorious.org/linux-can/linux-can-next/commits/for-davem

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]