Re: can-next pull request for CAN ID Ematch

[Oliver Hartkopp <oliver.hartkopp@volkswagen.de>]

On 04.07.2012 13:09, Marc Kleine-Budde wrote:
> On 07/04/2012 08:03 AM, Oliver Hartkopp wrote:
>> Hi all,
>>
>> the pull location is still valid :-)
>>
>> Btw. i needed to change a minor thing as the em_canid_match() function did
>> not handle the case that the same CAN-ID can be SFF or EFF ...
>>
>> The option to support the CAN_EFF_FLAG cleared in the can_mask is broken,
>> unusual and can not be handled in a simple way.
>>
>> The tc tool can handle eff and sff rules - and so i did it in the
>> em_canid_change() function now. No support for CAN_EFF_FLAG cleared in the
>> can_mask - just check the CAN_EFF_FLAG in the filter.can_id to decide the
>> rules type.
>
> I hope I took the correct patch. Please check the for-davem branch in my
> gitorious repo[1].

Yes - it is the correct patch.

>
> I've changed some things in the commit:
> - credited Rostislav Lisovy as the original author.
>    (git commit --amend --author="Rostislav Lisovy<lisovy@gmail.com>")
> - added a "net:" in the Subject line
> - Fixed coding style issue in pkt_cls.h
>    all defines indent now with a tab

Good!

I also had some whitespace issues in Kconfig i fixed this morning ...

>
> The patch currently has these S-o-bs:
>
>      Signed-off-by: Rostislav Lisovy<lisovy@gmail.com>
>      Signed-off-by: Oliver Hartkopp<socketcan@hartkopp.net>
>      Signed-off-by: Marc Kleine-Budde<mkl@pengutronix.de>
>
> Oliver, if you want to credit your changes I can add a oneliner between
> Rostislav's and your S-o-b, which may look like this:
>
> [Oliver: fixed random stuff]

No need for that.

I'm pretty sure now that there are no obvious issues open now.
At least it's getting shorter and shorter it get's easier to review ;-)

Tnx!

Oliver

>
> [1] https://gitorious.org/linux-can/linux-can-next/commits/for-davem
>