From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out.smtpout.orange.fr (out-67.smtpout.orange.fr [193.252.22.67]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CC532E6133; Thu, 26 Jun 2025 14:50:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750949456; cv=none; b=mEnZX9KiZsZEs3pcfZEzOGfctfip2elcHbf043zq0VXnAtqM6A4gAFlQBiudyyUC0fyCyGYy1WTNAQdBrumrHsDiKBRetLw3FKP4dBAT1kp8cPp54de7hFUDMbIsEtO8HsS/u/MM4xLDALVX2GOUeAJE5aiBh6Imqbo2B5Eoi9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750949456; c=relaxed/simple; bh=0MP0tnHu6fQzXUoVEVy0aE8NoUMK5QMnnmNk1hZfbuQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uXqioOZXN2D+AFt2xaPkm4ef4sx7xVe257M+uO128Qxxcv7I0TnXi0KbfHiXGpWYD9unHSeAJfqpfNvXtND1AYFqRLRK01aXpYyTi8wvgy4H7KtHp3ngARKi0a14iJfB1vv++LbAAED0OGnhQ6UX+kqlIhlwkncnWT/sp+aOCwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wanadoo.fr; spf=pass smtp.mailfrom=wanadoo.fr; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b=CnB+jpkD; arc=none smtp.client-ip=193.252.22.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wanadoo.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wanadoo.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b="CnB+jpkD" Received: from [172.16.82.72] ([124.33.176.97]) by smtp.orange.fr with ESMTPA id Unw1uePibyDfnUnw2uCBbf; Thu, 26 Jun 2025 16:50:46 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1750949446; bh=CK8v7DCERysOk/Rvq1+fguI+gY89l+aE5AQv4JbT6Ps=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=CnB+jpkDINyf3UqSzYPPQJB+Qvb2iXDfs+CitNx9wZRVzbBWVk72ORRI4sfdsVmdx Pkw9w2hYRmAFxspd8ZaxIn5N9EkZgc4qZMBsDFEvmkuDxvegoItYANif1yL+It/RwM 9tkQaxA3AxV6egyd2A5pUnssifsF/P/4dxwMlMij1jKpQ1/MMb/SrZdxwgdwv496LL GAB7lreuVvY0kuVaBMq1QLmToBHCXa3lfaNwgPawj5Lf1vOOTD7AHaIvxFJ1I7YQld tzU9ZnJQ2oO3wZJi0xTQHIHFWX6GQK4rw+8tt/SZpBJvWHz3tOeBjq4bNgYpo0OEuD BezRNYqa16niQ== X-ME-Helo: [172.16.82.72] X-ME-Auth: bWFpbGhvbC52aW5jZW50QHdhbmFkb28uZnI= X-ME-Date: Thu, 26 Jun 2025 16:50:46 +0200 X-ME-IP: 124.33.176.97 Message-ID: <4af1102c-a5b6-4d9b-af8d-2c5f721b845e@wanadoo.fr> Date: Thu, 26 Jun 2025 23:50:40 +0900 Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations To: Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, Chen Ni , linux-can@vger.kernel.org, Marc Kleine-Budde References: <48e217a7-b90e-4af3-b535-812c449dd3ba@web.de> <0768a008-d4a9-41ec-bc47-1e7c63362296@web.de> <7e6f8929-6665-45af-b01b-167a1aa80305@web.de> <1e64bcef-33f1-4295-b91f-d4598b32b866@web.de> <57815326-740d-4053-8b85-c5e57d7cec90@wanadoo.fr> Content-Language: en-US From: Vincent Mailhol Autocrypt: addr=mailhol.vincent@wanadoo.fr; keydata= xjMEZluomRYJKwYBBAHaRw8BAQdAf+/PnQvy9LCWNSJLbhc+AOUsR2cNVonvxhDk/KcW7FvN LFZpbmNlbnQgTWFpbGhvbCA8bWFpbGhvbC52aW5jZW50QHdhbmFkb28uZnI+wrIEExYKAFoC GwMFCQp/CJcFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AWIQTtj3AFdOZ/IOV06OKrX+uI bbuZwgUCZx41XhgYaGtwczovL2tleXMub3BlbnBncC5vcmcACgkQq1/riG27mcIYiwEAkgKK BJ+ANKwhTAAvL1XeApQ+2NNNEwFWzipVAGvTRigA+wUeyB3UQwZrwb7jsQuBXxhk3lL45HF5 8+y4bQCUCqYGzjgEZx4y8xIKKwYBBAGXVQEFAQEHQJrbYZzu0JG5w8gxE6EtQe6LmxKMqP6E yR33sA+BR9pLAwEIB8J+BBgWCgAmFiEE7Y9wBXTmfyDldOjiq1/riG27mcIFAmceMvMCGwwF CQPCZwAACgkQq1/riG27mcJU7QEA+LmpFhfQ1aij/L8VzsZwr/S44HCzcz5+jkxnVVQ5LZ4B ANOCpYEY+CYrld5XZvM8h2EntNnzxHHuhjfDOQ3MAkEK In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Markus, Thanks for the v2. On 26/06/2025 at 23:46, Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Jun 2025 16:34:26 +0200 > > * Reuse existing functionality from usb_endpoint_is_bulk_in() > and usb_endpoint_is_bulk_out() instead of keeping duplicate source code. > > * Omit two comment lines which became redundant with this refactoring. > > The source code was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Vincent Mailhol Yours sincerely, Vincent Mailhol