linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, kernel@pengutronix.de,
	Hui Wang <jason77.wang@gmail.com>,
	Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH] can: flexcan: add hardware controller version support
Date: Wed, 18 Jul 2012 11:50:22 +0200	[thread overview]
Message-ID: <500686DE.1050908@pengutronix.de> (raw)
In-Reply-To: <1341174085-11781-1-git-send-email-mkl@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

Hello,

On 07/01/2012 10:21 PM, Marc Kleine-Budde wrote:
> From: Hui Wang <jason77.wang@gmail.com>
> 
> At least in the i.MX series, the flexcan contrller divides into ver_3
> and ver_10, current driver is for ver_3 controller.

Has someone access to the freescale hardware people and can figure out
the controller versions used on:

imx28
imx25
imx35
imx53

Because I noticed that the FLEXCAN_CTRL_CLK_SRC bit (bit 13 of the
FLEXCAN control register) is marked as reserved in the mx53 datasheet
(although its meaning is documented) as well as in the imx6q. Is there a
Changelog of this core available?

> i.MX6 has ver_10 controller, it has more reigsters than ver_3 has.
> The rxfgmask (Rx FIFO Global Mask) register is one of the new added.
> Its reset value is 0xffffffff, this means ID Filter Table must be
> checked when receive a packet, but the driver is designed to accept
> everything during the chip start, we need to clear this register to
> follow this design.
> 
> Use the data entry of the struct of_device_id to point chip specific
> info, we can set hardware version for each platform.

cheers, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  parent reply	other threads:[~2012-07-18  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-01 20:21 [PATCH] can: flexcan: add hardware controller version support Marc Kleine-Budde
2012-07-02  2:24 ` Hui Wang
2012-07-02  7:23   ` Marc Kleine-Budde
2012-07-02 12:42   ` Marc Kleine-Budde
2012-07-03  3:07     ` Hui Wang
2012-07-18  9:50 ` Marc Kleine-Budde [this message]
2012-07-18 10:03   ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500686DE.1050908@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=jason77.wang@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).