Re: [PATCH 1/4] can: c_can: Add device tree support to Bosch C_CAN/D_CAN controller

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]

On 07/25/2012 12:06 PM, AnilKumar, Chimata wrote:
[...]
>>> --- a/drivers/net/can/c_can/c_can_platform.c
>>> +++ b/drivers/net/can/c_can/c_can_platform.c
>>> @@ -30,6 +30,8 @@
>>>  #include <linux/io.h>
>>>  #include <linux/platform_device.h>
>>>  #include <linux/clk.h>
>>> +#include <linux/of.h>
>>> +#include <linux/of_device.h>
>>>  
>>>  #include <linux/can/dev.h>
>>>  
>>> @@ -65,17 +67,51 @@ static void c_can_plat_write_reg_aligned_to_32bit(struct c_can_priv *priv,
>>>  	writew(val, priv->base + 2 * priv->regs[index]);
>>>  }
>>>  
>>> +static struct platform_device_id c_can_id_table[] = {
>>> +	{
>>> +		.name = KBUILD_MODNAME,
>>> +		.driver_data = C_CAN_DEVTYPE,
>>> +	}, {
>>> +		.name = "c_can",
>>> +		.driver_data = C_CAN_DEVTYPE,
>>> +	}, {
>>> +		.name = "d_can",
>>> +		.driver_data = D_CAN_DEVTYPE,
>>> +	}, {
>>> +	}
>>> +};
>>> +
>>> +static const struct of_device_id c_can_of_table[] = {
>>> +	{ .compatible = "bosch,c_can_platform", .data = &c_can_id_table[0] },
>>
>> Please don't add the "legacy bosch,c_can_platform" to the device tree
> 
> I will remove this from DT bindings.
> 
>> bindings. I personally would appreciate if you introduce an enum as
>> array index (BOSCH_C_CAN_PLATFORM, BOSCH_C_CAN, BOSCH_D_CAN) and
>> initialize the c_can_id_table above using the array indexes, then you
>> can use these indexes here too.
> 
> What about having the same enum for devtype and index like

That was 100% exactly what I was thinking of :)

> enum c_can_dev_id {
> 	BOSCH_C_CAN_PLATFORM,
> 	BOSCH_C_CAN,
> 	BOSCH_D_CAN,
> };
> 
> static struct platform_device_id c_can_id_table[] = {
> 	[BOSCH_C_CAN_PLATFORM] = {
> 		.name = KBUILD_MODNAME,
> 		.driver_data = BOSCH_C_CAN,
> 	},
> };

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]