From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Andrew Beard <abeard@ovro.caltech.edu>
Cc: Ira Snyder <iws@ovro.caltech.edu>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: Patch for libsocketcan
Date: Tue, 07 Aug 2012 09:43:48 +0200 [thread overview]
Message-ID: <5020C734.2090008@pengutronix.de> (raw)
In-Reply-To: <6D9074C1-4B77-4D4B-BCF5-F13625B6DC05@ovro.caltech.edu>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
Hello Andrew,
I've added linux-can on Cc.
On 08/03/2012 08:23 PM, Andrew Beard wrote:
> Hi Marc,
> Attached is a patch for what I believe is a bug in libsocketcan.
> Please let me know if you have any questions.
Yes, it's a bug, Alexander Stein fixed it already, but I didn't apply
his patch. Your patch, is the way better solution. You did not follow
quite the kernel coding style, and put some variable definition into the
loop. I fixed that an will commit it to the repo. Can I add your
Signed-off-by[1] to the patch?
Marc
[1]
http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L298
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next parent reply other threads:[~2012-08-07 7:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6D9074C1-4B77-4D4B-BCF5-F13625B6DC05@ovro.caltech.edu>
2012-08-07 7:43 ` Marc Kleine-Budde [this message]
2012-08-07 15:09 ` Patch for libsocketcan Andrew Beard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5020C734.2090008@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=abeard@ovro.caltech.edu \
--cc=iws@ovro.caltech.edu \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox