Re: Fwd: [Socketcan-users] sja1000_platform interrupt sharing

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2099 bytes --]

On 08/09/2012 01:21 PM, Marc Kleine-Budde wrote:
> I've found something confusing when I wanted to use more than one

It's not confusing, it's a bug. Good catch.

> sja1000 attached to a platform bus with interrupt sharing. The flag for
> the sja1000 resources I wanted to set first was the
> IORESOURCE_IRQ_SHAREABLE* flag because of the other IORESOURCE_IRQ_XXX
> flags. But this flag is ignored by the sja1000_platform driver because
> it has another position. If I use the generic IRQF_SHARED** flag
> everything works fine. Does it make sense to patch the driver in a way
> like that:
> 
> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
> 2012-08-09 10:38:57.405381025 +0200
> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
> 2012-08-09 10:57:22.693364557 +0200
> @@ -109,6 +109,8 @@
>  	priv = netdev_priv(dev);
>  
>  	dev->irq = res_irq->start;
> +	if(res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
> +		priv->irq_flags |= IRQF_SHARED;

Please adjust to kernel coding style, space between if and opening bracket.

>  	priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
> IRQF_SHARED);

Please remove the IRQF_SHARED here, as IRQF_SHARED is wrong here and
means something different.

>  	priv->reg_base = addr;
>  	/* The CAN clock frequency is half the oscillator clock
> frequency */

If you have a look at the history of the file, it shows that this flag
was added Yegor Yefremov <yegor_sub1@visionsystems.de> in commit

abde89d can: sja1000: allow shared interrupt definition

Please resend your patch, with the problems fixed, use git send-email
for this, add Yegor on Cc and Sign your work [1]. If this is too
complicated for you, I'll fix it myself.

Marc

[1]
http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L298
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]