From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Schmitt, Sven (EVM/8)" <Sven.Schmitt@volkswagen.de>
Cc: yegor_sub1@visionsystems.de, linux-can@vger.kernel.org
Subject: Re: AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
Date: Fri, 10 Aug 2012 10:21:20 +0200 [thread overview]
Message-ID: <5024C480.2010508@pengutronix.de> (raw)
In-Reply-To: <6C5A3B79888A804CAB605257CD26D37703955B60@vwagwox00032.vw.vwg>
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
On 08/09/2012 02:46 PM, Schmitt, Sven (EVM/8) wrote:
> Second try:
>
> Signed-off-by: Sven Schmitt <sven.schmitt@volkswagen.de>
>
> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
> @@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
> priv = netdev_priv(dev);
>
> dev->irq = res_irq->start;
> - priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
> IRQF_SHARED);
> + priv->irq_flags &= IRQF_TRIGGER_MASK;
Should be:
priv->irq_flags = res_irq->flags & IRQF_TRIGGER_MASK;
I'm fixing this,
Marc
> + if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
> + priv->irq_flags |= IRQF_SHARED;
> priv->reg_base = addr;
> /* The CAN clock frequency is half the oscillator clock
> frequency */
> priv->can.clock.freq = pdata->osc_freq / 2;
>
>
> note: patch is compile tested only.
>
> Sven
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-08-10 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 12:46 AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing Schmitt, Sven (EVM/8)
2012-08-09 12:56 ` Yegor Yefremov
2012-08-09 13:01 ` Marc Kleine-Budde
2012-08-09 13:13 ` Yegor Yefremov
2012-08-09 14:00 ` Marc Kleine-Budde
2012-08-09 13:05 ` AW: " Marc Kleine-Budde
[not found] ` <1236253306.453.1344517522410.JavaMail.trustmail@VW2BWOSEVG02>
2012-08-09 13:23 ` AW: " Schmitt, Sven (EVM/8)
2012-08-10 8:21 ` Marc Kleine-Budde [this message]
2012-08-10 8:23 ` Schmitt, Sven (EVM/8)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5024C480.2010508@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Sven.Schmitt@volkswagen.de \
--cc=linux-can@vger.kernel.org \
--cc=yegor_sub1@visionsystems.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).