From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Andreas Larsson <andreas@gaisler.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH] can: can_oc: Add driver for CAN_OC cores from Aeroflex Gaisler
Date: Wed, 26 Sep 2012 14:58:51 +0200 [thread overview]
Message-ID: <5062FC0B.4050309@pengutronix.de> (raw)
In-Reply-To: <5062FB2B.2030700@gaisler.com>
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
On 09/26/2012 02:55 PM, Andreas Larsson wrote:
[...]
>>>> Right, at least I do not see anything special. The following DTS entry
>>>> should do the jobs:
>>>> [...]
>>>
>>> I'll look into this. Note that this is a SPARC device and not a PowerPC
>>> device.
>>
>> The driver doesn't care about your processor :)
>
> The driver doesn't care per se, but how the device tree is generated
> differs compared to how it is done in PowerPC, at least for Leon SPARC.
What difference do you mean? For example the flexcan driver works
perfectly for ARM (DT and non-DT) and PowerPC (DT).
> I'll look into it. At the very least the Kconfig entry for
> sja1000_of_platform could not solely depend on PPC_OF, but the more
> important issue is the device tree differences.
Sure send a patch, or better send a patch that integrates the OF
Bindings into the existing platform driver and remove the of_platform
driver completely.
regards, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2012-09-26 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 5:52 [PATCH] can: can_oc: Add driver for CAN_OC cores from Aeroflex Gaisler Andreas Larsson
2012-09-26 9:38 ` Marc Kleine-Budde
2012-09-26 9:56 ` Wolfgang Grandegger
2012-09-26 11:40 ` Andreas Larsson
2012-09-26 11:41 ` Marc Kleine-Budde
2012-09-26 12:55 ` Andreas Larsson
2012-09-26 12:58 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5062FC0B.4050309@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andreas@gaisler.com \
--cc=linux-can@vger.kernel.org \
--cc=software@gaisler.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox