Re: [PATCH] can: can_oc: Add driver for CAN_OC cores from Aeroflex Gaisler

Marc Kleine-Budde
2012-09-26T12:59:07Z

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

On 09/26/2012 02:55 PM, Andreas Larsson wrote:
[...]

>>>> Right, at least I do not see anything special. The following DTS entry
>>>> should do the jobs:
>>>> [...]
>>>
>>> I'll look into this. Note that this is a SPARC device and not a PowerPC
>>> device.
>>
>> The driver doesn't care about your processor :)
>
> The driver doesn't care per se, but how the device tree is generated
> differs compared to how it is done in PowerPC, at least for Leon SPARC.

What difference do you mean? For example the flexcan driver works
perfectly for ARM (DT and non-DT) and PowerPC (DT).

> I'll look into it. At the very least the Kconfig entry for
> sja1000_of_platform could not solely depend on PPC_OF, but the more
> important issue is the device tree differences.

Sure send a patch, or better send a patch that integrates the OF
Bindings into the existing platform driver and remove the of_platform
driver completely.

regards, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]