Re: [PATCH] can: can_oc: Add driver for CAN_OC cores from Aeroflex Gaisler

Andreas Larsson
2012-09-26T12:55:44Z

On 09/26/2012 01:41 PM, Marc Kleine-Budde wrote:
> On 09/26/2012 01:40 PM, Andreas Larsson wrote:
>> On 09/26/2012 11:56 AM, Wolfgang Grandegger wrote:
>>> On 09/26/2012 11:38 AM, Marc Kleine-Budde wrote:
>>>> On 09/25/2012 07:52 AM, Andreas Larsson wrote:
>>>>> This driver is for the sja1000 compatible CAN_OC cores from Aeroflex
>>>>> Gaisler available in the GRLIB VHDL IP core library.
>>>>
>>>> Why don't you describe a single sja1000 compatible core with an OF
>>>> device? The devices have indipendent address spaces and IRQs. With a
>>>> proper abstraction/desciption you would not need this driver.
>>>
>>> Right, at least I do not see anything special. The following DTS entry
>>> should do the jobs:
>>> [...]
>>
>> I'll look into this. Note that this is a SPARC device and not a PowerPC
>> device.
>
> The driver doesn't care about your processor :)

The driver doesn't care per se, but how the device tree is generated
differs compared to how it is done in PowerPC, at least for Leon SPARC.

I'll look into it. At the very least the Kconfig entry for
sja1000_of_platform could not solely depend on PPC_OF, but the more
important issue is the device tree differences.

Cheers,
Andreas