From: Marc Kleine-Budde <mkl@pengutronix.de>
To: AnilKumar Ch <anilkumar@ti.com>
Cc: wg@grandegger.com, swarren@wwwdotorg.org,
linux-can@vger.kernel.org, anantgole@ti.com, nsekhar@ti.com
Subject: Re: [PATCH] can: c_can: fix segfault during rmmod
Date: Thu, 27 Sep 2012 16:43:17 +0200 [thread overview]
Message-ID: <50646605.8080909@pengutronix.de> (raw)
In-Reply-To: <1348748698-5635-1-git-send-email-anilkumar@ti.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On 09/27/2012 02:24 PM, AnilKumar Ch wrote:
> This patch fixes an oops which occurs during unloading the driver.
> unregister_c_can_dev() is doing c_can/d_can module interrupts
> disable, which requires module clock enable. c_can/d_can interrupts
> enable/disable is handled properly in c_can_start and c_can_stop,
> so removing from unregister_c_can_dev().
>
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
Thanks, I've added a reference to the commit that added the runtime pm
support. I'll send a pull request to David soon.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2012-09-27 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 12:24 [PATCH] can: c_can: fix segfault during rmmod AnilKumar Ch
2012-09-27 14:43 ` Marc Kleine-Budde [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-27 10:41 AnilKumar Ch
2012-09-27 11:11 ` Marc Kleine-Budde
2012-09-27 11:22 ` AnilKumar, Chimata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50646605.8080909@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=anantgole@ti.com \
--cc=anilkumar@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).