Re: [PATCH] can: grcan: Add device driver for GRCAN and GRHCAN cores

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

Hello,

On 10/02/2012 04:38 PM, Andreas Larsson wrote:
> This driver supports GRCAN and CRHCAN CAN controllers available in the GRLIB
> VHDL IP core library.
> 
> Signed-off-by: Andreas Larsson <andreas@gaisler.com>
> ---
>  drivers/net/can/Kconfig  |    6 +
>  drivers/net/can/Makefile |    1 +
>  drivers/net/can/grcan.c  | 1283 ++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/net/can/grcan.h  |  273 ++++++++++
>  4 files changed, 1563 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/net/can/grcan.c
>  create mode 100644 drivers/net/can/grcan.h

Some general remarks while scrolling though the driver:
- please provide a device tree binding documentation
  Documentation/devicetree/bindings/net/can/grcan.txt
  and add devicetree-discuss@lists.ozlabs.org on Cc
- please provide a documentation for the sysfs entries:
  Documentation/ABI/testing/sys-XXX-grcan.txt
- please implement a NAPI
- please include the .h file into the C code,
  as the C code is the one and only user of the .h file
- please give every macro a GRCAN_ prefix

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]