From: Andreas Larsson <andreas@gaisler.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH] can: sja1000: Make sja1000_of_platform selectable and compilable on SPARC
Date: Thu, 04 Oct 2012 15:43:02 +0200 [thread overview]
Message-ID: <506D9266.6010707@gaisler.com> (raw)
In-Reply-To: <506D85D7.8090801@pengutronix.de>
On 10/04/2012 02:49 PM, Marc Kleine-Budde wrote:
> On 10/02/2012 03:13 PM, Andreas Larsson wrote:
>> Signed-off-by: Andreas Larsson <andreas@gaisler.com>
>
> On sparc32 (and others) this fails to compile with:
>
>> linux/drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_read_reg':
>> linux/drivers/net/can/sja1000/sja1000_of_platform.c:64:2: error: implicit declaration of function 'in_8' [-Werror=implicit-function-declaration]
>> linux/drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_write_reg':
>> linux/drivers/net/can/sja1000/sja1000_of_platform.c:70:2: error: implicit declaration of function 'out_8' [-Werror=implicit-function-declaration]
Oh, right, sorry about that. Thank's for the input. I was testing on top
of a local patch providing that for sparc. I'll send a new patch
changing the I/O functions to ioread8 and iowrite8.
Cheers,
Andreas
next prev parent reply other threads:[~2012-10-04 13:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 13:13 [PATCH] can: sja1000: Make sja1000_of_platform selectable and compilable on SPARC Andreas Larsson
2012-10-04 12:49 ` Marc Kleine-Budde
2012-10-04 13:43 ` Andreas Larsson [this message]
2012-10-04 13:59 ` [PATCH v2] " Andreas Larsson
2012-10-04 14:42 ` Marc Kleine-Budde
2012-10-04 15:12 ` Marc Kleine-Budde
2012-10-05 9:01 ` Andreas Larsson
2012-10-05 9:05 ` Marc Kleine-Budde
2012-10-05 9:16 ` Andreas Larsson
2012-10-05 9:19 ` Marc Kleine-Budde
2012-11-12 17:52 ` Andreas Larsson
2012-11-22 11:30 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506D9266.6010707@gaisler.com \
--to=andreas@gaisler.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=software@gaisler.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).