From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Andreas Larsson <andreas@gaisler.com>
Cc: linux-can@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH v2] can: sja1000: Make sja1000_of_platform selectable and compilable on SPARC
Date: Thu, 04 Oct 2012 17:12:41 +0200 [thread overview]
Message-ID: <506DA769.6090000@pengutronix.de> (raw)
In-Reply-To: <506DA06D.3070003@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]
On 10/04/2012 04:42 PM, Marc Kleine-Budde wrote:
> On 10/04/2012 03:59 PM, Andreas Larsson wrote:
>> Signed-off-by: Andreas Larsson <andreas@gaisler.com>
>
> Looks better. However on sparc and sparc64, I'm seeing this warning.
> From my point of view a false positive.
>
>> linux/drivers/net/can/sja1000/sja1000_of_platform.c: In function 'sja1000_ofp_remove':
>> linux/include/linux/ioport.h:165:18: warning: 'res.end' is used uninitialized in this function [-Wuninitialized]
>> linux/drivers/net/can/sja1000/sja1000_of_platform.c:78:18: note: 'res.end' was declared here
>> linux/include/linux/ioport.h:165:2: warning: 'res.start' is used uninitialized in this function [-Wuninitialized]
>> linux/drivers/net/can/sja1000/sja1000_of_platform.c:78:18: note: 'res.start' was declared here
Looking at the preprocessed code, the compiler is right:
> # 30 "/home/frogger/pengutronix/socketcan/linux/include/linux/of_address.h"
> static inline __attribute__((always_inline)) __attribute__((no_instrument_function)) int of_address_to_resource(struct device_node *dev, int index,
> struct resource *r)
> {
> return -22;
> }
http://lxr.free-electrons.com/source/include/linux/of_address.h#L29
Why is CONFIG_OF_ADDRESS not set in my .config?
http://lxr.free-electrons.com/source/drivers/of/Kconfig#L43
What a U+1F4A9,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2012-10-04 15:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 13:13 [PATCH] can: sja1000: Make sja1000_of_platform selectable and compilable on SPARC Andreas Larsson
2012-10-04 12:49 ` Marc Kleine-Budde
2012-10-04 13:43 ` Andreas Larsson
2012-10-04 13:59 ` [PATCH v2] " Andreas Larsson
2012-10-04 14:42 ` Marc Kleine-Budde
2012-10-04 15:12 ` Marc Kleine-Budde [this message]
2012-10-05 9:01 ` Andreas Larsson
2012-10-05 9:05 ` Marc Kleine-Budde
2012-10-05 9:16 ` Andreas Larsson
2012-10-05 9:19 ` Marc Kleine-Budde
2012-11-12 17:52 ` Andreas Larsson
2012-11-22 11:30 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506DA769.6090000@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andreas@gaisler.com \
--cc=linux-can@vger.kernel.org \
--cc=software@gaisler.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).