From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-can@vger.kernel.org, Hui Wang <jason77.wang@gmail.com>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH v3] can: flexcan: disable bus error interrupts for the i.MX6q
Date: Thu, 11 Oct 2012 17:28:16 +0200 [thread overview]
Message-ID: <5076E590.5000903@pengutronix.de> (raw)
In-Reply-To: <5076E34C.3090404@grandegger.com>
[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]
On 10/11/2012 05:18 PM, Wolfgang Grandegger wrote:
> Hi Marc,
>
> On 10/11/2012 03:39 PM, Marc Kleine-Budde wrote:
>> From: Wolfgang Grandegger <wg@grandegger.com>
>>
>> Due to a bug in most Flexcan cores, the bus error interrupt needs
>> to be enabled. Otherwise we don't get any error warning or passive
>> interrupts. This is _not_ necessary for the i.MX6q and this patch
>> disables bus error interrupts if "berr-reporting" is not requested.
>> This avoids bus error flooding, which might harm, especially on
>> low-end systems.
>
> Should be something like:
>
> This patch adds some Flexcan version info and removes the feature flag
> FLEXCAN_HAS_BROKEN_ERR_STATE for the i.MX6Q. It also has the line
> [TR]WRN_INT properly connected.
Tnx, I've send a v4 with the new commit message.
>
>> Cc: Hui Wang <jason77.wang@gmail.com>
>> Cc: Shawn Guo <shawn.guo@linaro.org>
>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
>> [mkl: convert to incremental patch]
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> Changes since v3:
>> - convert to incremental patch
>> - update mx6 glitch filter information
>> ---
>> Hello Wolfgang,
>>
>> I've converted your patch so that it can be applied to current net, where David
>> already accepted your v1 version of the patch.
>
> Thanks, I will not have time before this evening. Looks good, apart from
> the commit message. Feel free to go ahead.
Will do,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2012-10-11 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 13:39 [PATCH v3] can: flexcan: disable bus error interrupts for the i.MX6q Marc Kleine-Budde
2012-10-11 15:18 ` Wolfgang Grandegger
2012-10-11 15:28 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5076E590.5000903@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=jason77.wang@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).