From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Stephane Grosjean <s.grosjean@peak-system.com>
Cc: linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can/sja1000: Add miniPCIe/cPCI PC/104Plus PCI/104e PEAK-System boards
Date: Tue, 23 Oct 2012 18:56:22 +0200 [thread overview]
Message-ID: <5086CC36.8040006@hartkopp.net> (raw)
In-Reply-To: <1350988637-13581-1-git-send-email-s.grosjean@peak-system.com>
Hi Stephane,
nice to see things are going on :-)
Btw. Marc and Wolfgang mainly should be addressed for this driver.
Maybe Marc should 'tune' the commit message to
can/peak_pci: Add/fix PCI IDs for miniPCIe/cPCI PC/104Plus PCI/104e cards
which hits the point and will generate no remarks - even if it goes into the
netdev tree in the 3.7-rc phase.
Anyway you can get a
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
:-)
Tnx,
Oliver
On 23.10.2012 12:37, Stephane Grosjean wrote:
> This patch adds the support for 4 new PCI boards based on the SJA1000 CAN
> controller, from PEAK-System Technik:
>
> . PCAN-miniPCIe (PCI-Express Mini slots, available as single or dual-channel)
> . PCAN-cPCI (CompactPCI format, available as single or dual-channel)
> . PCAN-PC/104-Plus (PC/104-Plus system, av. as 1, 2 or 4 channels)
> . PCAN-PCI/104-Express (PCI/104-Express system, av. as 1 or 2 channels)
>
> This patch also fixes a typo in existing "PEAK_MPCI_DEVICE_ID" identifier
> (missing "E" for Express). Finally, it also adds another author as well as it
> updates the module supported devices list.
>
> Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
> ---
next prev parent reply other threads:[~2012-10-23 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 10:37 [PATCH] can/sja1000: Add miniPCIe/cPCI PC/104Plus PCI/104e PEAK-System boards Stephane Grosjean
2012-10-23 16:56 ` Oliver Hartkopp [this message]
2012-10-24 6:29 ` Wolfgang Grandegger
[not found] ` <508A4369.9010301@peak-system.com>
2012-10-26 8:11 ` Marc Kleine-Budde
2012-10-24 9:08 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086CC36.8040006@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).