From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Chuansheng Liu <chuansheng.liu@intel.com>
Cc: wg@grandegger.com, linux-kernel@vger.kernel.org,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: [PATCH 5/7] can: janz-ican3: Fix the usage of wait_for_completion_timeout
Date: Tue, 06 Nov 2012 12:43:59 +0100 [thread overview]
Message-ID: <5098F7FF.1090100@pengutronix.de> (raw)
In-Reply-To: <1352223097.15558.1599.camel@cliu38-desktop-build>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On 11/06/2012 06:31 PM, Chuansheng Liu wrote:
>
> The return value of wait_for_completion_timeout() is always
>> = 0 with unsigned int type.
>
> So the condition "ret < 0" or "ret >= 0" is pointless.
>
> Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
Thnx, applied to can-next. Please put linux-can@vger.kernel.org on Cc
next time.
regards, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
parent reply other threads:[~2012-11-06 11:44 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1352223097.15558.1599.camel@cliu38-desktop-build>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5098F7FF.1090100@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=chuansheng.liu@intel.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).