From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Olivier Sobrie <olivier@sobrie.be>
Cc: linux-can@vger.kernel.org, Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [can:for-davem 2/3] drivers/net/can/usb/kvaser_usb.c:431 kvaser_usb_send_simple_msg() error: doing dma on the stack ((null))
Date: Thu, 22 Nov 2012 16:50:42 +0100 [thread overview]
Message-ID: <50AE49D2.4080709@pengutronix.de> (raw)
In-Reply-To: <20121122144648.GA11612@hposo>
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
On 11/22/2012 03:46 PM, Olivier Sobrie wrote:
> Hi Marc,
>
> Argh.
>
> On Thu, Nov 22, 2012 at 02:05:30PM +0100, Marc Kleine-Budde wrote:
>> Hello Olivier,
>>
>> can you please ask on the usb mailinglist how to fix this problem (given
>> this isn't a false positive)
>
> Ok I'll ask. By googling I found this which looks to be a similar problem
> fixed in another driver.
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=32ec4576c3fb37316b1d11a04b220527822f3f0d
>
> I assume I've to kmalloc the kvaser_msg I send through
> kvaser_usb_send_msg(). I'll ask to people of linux-usb to be sure.
>
> By the way I installed smatch (which I never used) and ran the command
> make CHECK="~/bin/smatch -p=kernel" C=1"
> in my kernel dir but I didn't get the error:
> CHECK drivers/net/can/usb/kvaser_usb.c
> CC [M] drivers/net/can/usb/kvaser_usb.o
>
> Do I've to give a specific option to smatch to get this error?
I've not used smack either. Maybe Wu can give us some hints and/or links.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]
next prev parent reply other threads:[~2012-11-22 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 12:22 [can:for-davem 2/3] drivers/net/can/usb/kvaser_usb.c:431 kvaser_usb_send_simple_msg() error: doing dma on the stack ((null)) kbuild test robot
2012-11-22 13:05 ` Marc Kleine-Budde
2012-11-22 14:46 ` Olivier Sobrie
2012-11-22 15:50 ` Marc Kleine-Budde [this message]
2012-11-22 16:29 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AE49D2.4080709@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=fengguang.wu@intel.com \
--cc=linux-can@vger.kernel.org \
--cc=olivier@sobrie.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).