From: Wolfgang Grandegger <wg@grandegger.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, bhupesh.sharma@st.com, tomoya.rohm@gmail.com
Subject: Re: [RFC 0/6] pch_can/c_can: fix races and add PCH support to c_can
Date: Mon, 26 Nov 2012 09:50:08 +0100 [thread overview]
Message-ID: <50B32D40.1040507@grandegger.com> (raw)
In-Reply-To: <50B32CAC.4050501@pengutronix.de>
On 11/26/2012 09:47 AM, Marc Kleine-Budde wrote:
> On 11/26/2012 09:23 AM, Wolfgang Grandegger wrote:
>> Hello,
>>
>> as you might have already realized, Michael has reported problems with
>> the PCH_CAN driver. With his help we try to fix these issues and add
>> PCH PCI support to the C_CAN driver replacing the PCH_CAN driver sooner
>> than later. Here follows my current patch stack for the records. When
>> Michael's tests are successful, I'm going to post final patches.
>>
>> For Michael I have prepared out-of-tree driver sources allowing to
>> easily build the drivers also for older 3.x kernel versions. More
>> tester are welcome.
>>
>> As also pointed out by Casper, the problems are obvisouly due to races
>> with stop and wakeup of the netif tx queue, managing tx_next and
>> concurrent register accesses. For the moment I have fixed the races by
>> adding "spin[un]lock_irqsave/restore" but, thinking more about it,
>> "spinlock_bh" should be enough to protect against softirq context.
>>
>> With the C_CAN driver I realized some other minor issues:
>>
>> - The C/D_CAN type handling is common code and could go to
>> alloc_c_can_dev() or register_c_can_dev().
>>
>> Comments are welcome.
>
> Please make the patches based on linux-can-next/for-davem
OK, will do for the next round. For the moment these are just RFC patches.
Wolfgang.
next prev parent reply other threads:[~2012-11-26 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 8:23 [RFC 0/6] pch_can/c_can: fix races and add PCH support to c_can Wolfgang Grandegger
2012-11-26 8:23 ` [RFC 1/6] pch_can: add spinlock to protect tx objects Wolfgang Grandegger
2012-11-26 8:23 ` [RFC 2/6] c_can: add spinlock to protect tx and rx objects Wolfgang Grandegger
2012-11-26 8:23 ` [RFC 3/6] c_can: add optional reset callback Wolfgang Grandegger
2012-11-26 8:23 ` [RFC 4/6] c_can_pci: introduce board specific PCI bar Wolfgang Grandegger
2012-11-26 8:23 ` [RFC 5/6] c_can_pci: enable PCI bus master only for MSI Wolfgang Grandegger
2012-11-26 8:23 ` [RFC 6/6] c_can_pci: add support for PCH CAN on Intel EG20T PCH Wolfgang Grandegger
2012-11-26 8:47 ` [RFC 0/6] pch_can/c_can: fix races and add PCH support to c_can Marc Kleine-Budde
2012-11-26 8:50 ` Wolfgang Grandegger [this message]
2012-11-26 8:59 ` Marc Kleine-Budde
2012-11-26 9:20 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B32D40.1040507@grandegger.com \
--to=wg@grandegger.com \
--cc=bhupesh.sharma@st.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=tomoya.rohm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).