* at91_can.c: Data transmission stops @ 2012-11-26 14:28 Henrik Bork Steffensen 2012-11-26 15:25 ` Wolfgang Grandegger 0 siblings, 1 reply; 17+ messages in thread From: Henrik Bork Steffensen @ 2012-11-26 14:28 UTC (permalink / raw) To: linux-can Hi All, We use the canopen on an at91sam9263, and experience a can problem. Sometimes data transmission simply stops. Data reception continues normally. Reloading the at91_can module seems to be the only action to bring our system back on can. When we experience this problem, the TXF counter in /proc/net/can/stats is frozen. I have followed the thread on a similar issue "pch_can", and I was wondering if this is the same problem, and if the real problem might be in a higher level. In our case the lockup occurs approximately 1 time in 50 days. I tried reducing the number of mailboxes used for TX, from 4 to 1. That seem to increase the frequency of this lockup by a factor 2-5. These numbers are very uncertain due to the randomness and rarity of this bug. Some numbers to give an impression of our system: 125 kbit bus speed can bus load <1% max tx burst 1-6 telegrams, rx is a little bit higher. 240MHz ARM 9 (at91sam9263B) 2.6.32 kernel, with at91_can (and related files) patched with a few important fixes. I would like to move to a recent kernel, but that is not possible right now. I am considering protecting tx objects as Wolfgang suggests in the pch_can thread. Any ideas? best regards, Henrik Bork Steffensen ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-26 14:28 at91_can.c: Data transmission stops Henrik Bork Steffensen @ 2012-11-26 15:25 ` Wolfgang Grandegger 2012-11-26 16:29 ` Henrik Bork Steffensen 2012-11-26 16:36 ` Marc Kleine-Budde 0 siblings, 2 replies; 17+ messages in thread From: Wolfgang Grandegger @ 2012-11-26 15:25 UTC (permalink / raw) To: Henrik Bork Steffensen; +Cc: linux-can On 11/26/2012 03:28 PM, Henrik Bork Steffensen wrote: > Hi All, > > We use the canopen on an at91sam9263, and experience a can problem. > Sometimes data transmission simply stops. Data reception continues > normally. > > Reloading the at91_can module seems to be the only action to bring our > system back on can. > When we experience this problem, the TXF counter in /proc/net/can/stats > is frozen. > > I have followed the thread on a similar issue "pch_can", and I was > wondering > if this is the same problem, and if the real problem might be in a > higher level. > > In our case the lockup occurs approximately 1 time in 50 days. :( > I tried reducing the number of mailboxes used for TX, from 4 to 1. > That seem to increase the frequency of this lockup by a factor 2-5. > These numbers are very uncertain due to the randomness and rarity of > this bug. > > Some numbers to give an impression of our system: > 125 kbit bus speed > can bus load <1% > max tx burst 1-6 telegrams, rx is a little bit higher. > 240MHz ARM 9 (at91sam9263B) > 2.6.32 kernel, with at91_can (and related files) patched with a few > important fixes. > I would like to move to a recent kernel, but that is not possible right > now. > > > I am considering protecting tx objects as Wolfgang suggests in the > pch_can thread. This problem is with SMP in the first place. Can you show your .config. The c_can driver uses similar code than the at91_can and they have therefore the same issues if the kernel is preemptable, IIUC. Should not be a big deal to adapt the following patch: http://marc.info/?l=linux-can&m=135391821814519&w=2 Wolfgang. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-26 15:25 ` Wolfgang Grandegger @ 2012-11-26 16:29 ` Henrik Bork Steffensen 2012-11-27 14:11 ` Henrik Bork Steffensen 2012-11-26 16:36 ` Marc Kleine-Budde 1 sibling, 1 reply; 17+ messages in thread From: Henrik Bork Steffensen @ 2012-11-26 16:29 UTC (permalink / raw) To: Wolfgang Grandegger; +Cc: linux-can [-- Attachment #1: Type: text/plain, Size: 794 bytes --] On 11/26/2012 04:25 PM, Wolfgang Grandegger wrote: > On 11/26/2012 03:28 PM, Henrik Bork Steffensen wrote: >> In our case the lockup occurs approximately 1 time in 50 days. > :( Luckily we have 50 systems for in-house testing. > >> I am considering protecting tx objects as Wolfgang suggests in the >> pch_can thread. > This problem is with SMP in the first place. Can you show your .config. I attached my .config. > The c_can driver uses similar code than the at91_can and they have > therefore the same issues if the kernel is preemptable, IIUC. Should not > be a big deal to adapt the following patch: > > http://marc.info/?l=linux-can&m=135391821814519&w=2 I was not aware of the relationship to c_can. I agree, it should be very easy to implement that patch. thank you. Henrik. [-- Attachment #2: .config --] [-- Type: text/plain, Size: 44847 bytes --] # # Automatically generated make config: don't edit # Linux kernel version: 2.6.32 # Mon Oct 1 08:56:23 2012 # CONFIG_ARM=y CONFIG_SYS_SUPPORTS_APM_EMULATION=y CONFIG_GENERIC_GPIO=y CONFIG_GENERIC_TIME=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_HARDIRQS=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_HAVE_LATENCYTOP_SUPPORT=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_TRACE_IRQFLAGS_SUPPORT=y CONFIG_HARDIRQS_SW_RESEND=y CONFIG_GENERIC_IRQ_PROBE=y CONFIG_RWSEM_GENERIC_SPINLOCK=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_GENERIC_HARDIRQS_NO__DO_IRQ=y CONFIG_VECTORS_BASE=0xffff0000 CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" CONFIG_CONSTRUCTORS=y # # General setup # CONFIG_EXPERIMENTAL=y CONFIG_BROKEN_ON_SMP=y CONFIG_LOCK_KERNEL=y CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_LOCALVERSION="" # CONFIG_LOCALVERSION_AUTO is not set CONFIG_SWAP=y CONFIG_SYSVIPC=y CONFIG_SYSVIPC_SYSCTL=y # CONFIG_POSIX_MQUEUE is not set # CONFIG_BSD_PROCESS_ACCT is not set # CONFIG_TASKSTATS is not set # CONFIG_AUDIT is not set # # RCU Subsystem # CONFIG_TREE_RCU=y # CONFIG_TREE_PREEMPT_RCU is not set # CONFIG_RCU_TRACE is not set CONFIG_RCU_FANOUT=32 # CONFIG_RCU_FANOUT_EXACT is not set # CONFIG_TREE_RCU_TRACE is not set # CONFIG_IKCONFIG is not set CONFIG_LOG_BUF_SHIFT=14 # CONFIG_GROUP_SCHED is not set # CONFIG_CGROUPS is not set # CONFIG_SYSFS_DEPRECATED_V2 is not set # CONFIG_RELAY is not set CONFIG_NAMESPACES=y # CONFIG_UTS_NS is not set # CONFIG_IPC_NS is not set # CONFIG_USER_NS is not set # CONFIG_PID_NS is not set # CONFIG_NET_NS is not set CONFIG_BLK_DEV_INITRD=y CONFIG_INITRAMFS_SOURCE="" CONFIG_RD_GZIP=y CONFIG_RD_BZIP2=y CONFIG_RD_LZMA=y CONFIG_CC_OPTIMIZE_FOR_SIZE=y CONFIG_SYSCTL=y CONFIG_ANON_INODES=y # CONFIG_EMBEDDED is not set CONFIG_UID16=y CONFIG_SYSCTL_SYSCALL=y CONFIG_KALLSYMS=y CONFIG_KALLSYMS_ALL=y # CONFIG_KALLSYMS_EXTRA_PASS is not set CONFIG_HOTPLUG=y CONFIG_PRINTK=y CONFIG_BUG=y CONFIG_ELF_CORE=y CONFIG_BASE_FULL=y CONFIG_FUTEX=y CONFIG_EPOLL=y CONFIG_SIGNALFD=y CONFIG_TIMERFD=y CONFIG_EVENTFD=y CONFIG_SHMEM=y CONFIG_AIO=y # # Kernel Performance Events And Counters # CONFIG_VM_EVENT_COUNTERS=y CONFIG_COMPAT_BRK=y CONFIG_SLAB=y # CONFIG_SLUB is not set # CONFIG_SLOB is not set # CONFIG_PROFILING is not set CONFIG_TRACEPOINTS=y CONFIG_HAVE_OPROFILE=y # CONFIG_KPROBES is not set CONFIG_HAVE_KPROBES=y CONFIG_HAVE_KRETPROBES=y CONFIG_HAVE_CLK=y # # GCOV-based kernel profiling # # CONFIG_GCOV_KERNEL is not set # CONFIG_SLOW_WORK is not set CONFIG_HAVE_GENERIC_DMA_COHERENT=y CONFIG_SLABINFO=y CONFIG_RT_MUTEXES=y CONFIG_BASE_SMALL=0 CONFIG_MODULES=y # CONFIG_MODULE_FORCE_LOAD is not set CONFIG_MODULE_UNLOAD=y # CONFIG_MODULE_FORCE_UNLOAD is not set # CONFIG_MODVERSIONS is not set # CONFIG_MODULE_SRCVERSION_ALL is not set CONFIG_BLOCK=y CONFIG_LBDAF=y # CONFIG_BLK_DEV_BSG is not set # CONFIG_BLK_DEV_INTEGRITY is not set # # IO Schedulers # CONFIG_IOSCHED_NOOP=y # CONFIG_IOSCHED_AS is not set CONFIG_IOSCHED_DEADLINE=y # CONFIG_IOSCHED_CFQ is not set # CONFIG_DEFAULT_AS is not set CONFIG_DEFAULT_DEADLINE=y # CONFIG_DEFAULT_CFQ is not set # CONFIG_DEFAULT_NOOP is not set CONFIG_DEFAULT_IOSCHED="deadline" # CONFIG_FREEZER is not set # # System Type # CONFIG_MMU=y # CONFIG_ARCH_AAEC2000 is not set # CONFIG_ARCH_INTEGRATOR is not set # CONFIG_ARCH_REALVIEW is not set # CONFIG_ARCH_VERSATILE is not set CONFIG_ARCH_AT91=y # CONFIG_ARCH_CLPS711X is not set # CONFIG_ARCH_GEMINI is not set # CONFIG_ARCH_EBSA110 is not set # CONFIG_ARCH_EP93XX is not set # CONFIG_ARCH_FOOTBRIDGE is not set # CONFIG_ARCH_MXC is not set # CONFIG_ARCH_STMP3XXX is not set # CONFIG_ARCH_NETX is not set # CONFIG_ARCH_H720X is not set # CONFIG_ARCH_NOMADIK is not set # CONFIG_ARCH_IOP13XX is not set # CONFIG_ARCH_IOP32X is not set # CONFIG_ARCH_IOP33X is not set # CONFIG_ARCH_IXP23XX is not set # CONFIG_ARCH_IXP2000 is not set # CONFIG_ARCH_IXP4XX is not set # CONFIG_ARCH_L7200 is not set # CONFIG_ARCH_KIRKWOOD is not set # CONFIG_ARCH_LOKI is not set # CONFIG_ARCH_MV78XX0 is not set # CONFIG_ARCH_ORION5X is not set # CONFIG_ARCH_MMP is not set # CONFIG_ARCH_KS8695 is not set # CONFIG_ARCH_NS9XXX is not set # CONFIG_ARCH_W90X900 is not set # CONFIG_ARCH_PNX4008 is not set # CONFIG_ARCH_PXA is not set # CONFIG_ARCH_MSM is not set # CONFIG_ARCH_RPC is not set # CONFIG_ARCH_SA1100 is not set # CONFIG_ARCH_S3C2410 is not set # CONFIG_ARCH_S3C64XX is not set # CONFIG_ARCH_S5PC1XX is not set # CONFIG_ARCH_SHARK is not set # CONFIG_ARCH_LH7A40X is not set # CONFIG_ARCH_U300 is not set # CONFIG_ARCH_DAVINCI is not set # CONFIG_ARCH_OMAP is not set # CONFIG_ARCH_BCMRING is not set # # Atmel AT91 System-on-Chip # # CONFIG_ARCH_AT91RM9200 is not set # CONFIG_ARCH_AT91SAM9260 is not set # CONFIG_ARCH_AT91SAM9261 is not set # CONFIG_ARCH_AT91SAM9G10 is not set CONFIG_ARCH_AT91SAM9263=y # CONFIG_ARCH_AT91SAM9RL is not set # CONFIG_ARCH_AT91SAM9G20 is not set # CONFIG_ARCH_AT91SAM9G45 is not set # CONFIG_ARCH_AT91CAP9 is not set # CONFIG_ARCH_AT91X40 is not set CONFIG_AT91_PMC_UNIT=y # # AT91SAM9263 Board Type # CONFIG_MACH_AT91SAM9263EK=y # CONFIG_MACH_USB_A9263 is not set # CONFIG_MACH_NEOCORE926 is not set # # AT91 Board Options # CONFIG_MTD_AT91_DATAFLASH_CARD=y # CONFIG_MTD_NAND_ATMEL_BUSWIDTH_16 is not set # # AT91 Feature Selections # # CONFIG_AT91_PROGRAMMABLE_CLOCKS is not set CONFIG_AT91_TIMER_HZ=100 CONFIG_AT91_EARLY_DBGU=y # CONFIG_AT91_EARLY_USART0 is not set # CONFIG_AT91_EARLY_USART1 is not set # CONFIG_AT91_EARLY_USART2 is not set # CONFIG_AT91_EARLY_USART3 is not set # CONFIG_AT91_EARLY_USART4 is not set # CONFIG_AT91_EARLY_USART5 is not set # # Processor Type # CONFIG_CPU_32=y CONFIG_CPU_ARM926T=y CONFIG_CPU_32v5=y CONFIG_CPU_ABRT_EV5TJ=y CONFIG_CPU_PABRT_LEGACY=y CONFIG_CPU_CACHE_VIVT=y CONFIG_CPU_COPY_V4WB=y CONFIG_CPU_TLB_V4WBI=y CONFIG_CPU_CP15=y CONFIG_CPU_CP15_MMU=y # # Processor Features # # CONFIG_ARM_THUMB is not set # CONFIG_CPU_ICACHE_DISABLE is not set # CONFIG_CPU_DCACHE_DISABLE is not set # CONFIG_CPU_DCACHE_WRITETHROUGH is not set # CONFIG_CPU_CACHE_ROUND_ROBIN is not set CONFIG_ARM_L1_CACHE_SHIFT=5 # # Bus support # # CONFIG_PCI_SYSCALL is not set # CONFIG_ARCH_SUPPORTS_MSI is not set # CONFIG_PCCARD is not set # # Kernel Features # CONFIG_TICK_ONESHOT=y CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y CONFIG_GENERIC_CLOCKEVENTS_BUILD=y CONFIG_VMSPLIT_3G=y # CONFIG_VMSPLIT_2G is not set # CONFIG_VMSPLIT_1G is not set CONFIG_PAGE_OFFSET=0xC0000000 # CONFIG_PREEMPT_NONE is not set # CONFIG_PREEMPT_VOLUNTARY is not set CONFIG_PREEMPT=y CONFIG_HZ=100 CONFIG_AEABI=y CONFIG_OABI_COMPAT=y # CONFIG_ARCH_SPARSEMEM_DEFAULT is not set # CONFIG_ARCH_SELECT_MEMORY_MODEL is not set # CONFIG_HIGHMEM is not set CONFIG_SELECT_MEMORY_MODEL=y CONFIG_FLATMEM_MANUAL=y # CONFIG_DISCONTIGMEM_MANUAL is not set # CONFIG_SPARSEMEM_MANUAL is not set CONFIG_FLATMEM=y CONFIG_FLAT_NODE_MEM_MAP=y CONFIG_PAGEFLAGS_EXTENDED=y CONFIG_SPLIT_PTLOCK_CPUS=4096 # CONFIG_PHYS_ADDR_T_64BIT is not set CONFIG_ZONE_DMA_FLAG=0 CONFIG_VIRT_TO_BUS=y CONFIG_HAVE_MLOCK=y CONFIG_HAVE_MLOCKED_PAGE_BIT=y # CONFIG_KSM is not set CONFIG_DEFAULT_MMAP_MIN_ADDR=4096 # CONFIG_LEDS is not set CONFIG_ALIGNMENT_TRAP=y # CONFIG_UACCESS_WITH_MEMCPY is not set # # Boot options # CONFIG_ZBOOT_ROM_TEXT=0x0 CONFIG_ZBOOT_ROM_BSS=0x0 CONFIG_CMDLINE="mem=64M console=ttyS0,115200 initrd=0x21100000,3145728 root=/dev/ram0 rw" # CONFIG_XIP_KERNEL is not set # CONFIG_KEXEC is not set # # CPU Power Management # # CONFIG_CPU_IDLE is not set # # Floating point emulation # # # At least one emulation must be selected # CONFIG_FPE_NWFPE=y # CONFIG_FPE_NWFPE_XP is not set # CONFIG_FPE_FASTFPE is not set # CONFIG_VFP is not set # # Userspace binary formats # CONFIG_BINFMT_ELF=y # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set CONFIG_HAVE_AOUT=y # CONFIG_BINFMT_AOUT is not set # CONFIG_BINFMT_MISC is not set # # Power management options # # CONFIG_PM is not set CONFIG_ARCH_SUSPEND_POSSIBLE=y CONFIG_NET=y # # Networking options # CONFIG_PACKET=y # CONFIG_PACKET_MMAP is not set CONFIG_UNIX=y CONFIG_XFRM=y # CONFIG_XFRM_USER is not set # CONFIG_XFRM_SUB_POLICY is not set # CONFIG_XFRM_MIGRATE is not set # CONFIG_XFRM_STATISTICS is not set # CONFIG_NET_KEY is not set CONFIG_INET=y # CONFIG_IP_MULTICAST is not set # CONFIG_IP_ADVANCED_ROUTER is not set CONFIG_IP_FIB_HASH=y CONFIG_IP_PNP=y CONFIG_IP_PNP_DHCP=y CONFIG_IP_PNP_BOOTP=y CONFIG_IP_PNP_RARP=y CONFIG_NET_IPIP=m CONFIG_NET_IPGRE=m # CONFIG_ARPD is not set # CONFIG_SYN_COOKIES is not set # CONFIG_INET_AH is not set # CONFIG_INET_ESP is not set # CONFIG_INET_IPCOMP is not set # CONFIG_INET_XFRM_TUNNEL is not set CONFIG_INET_TUNNEL=m # CONFIG_INET_XFRM_MODE_TRANSPORT is not set # CONFIG_INET_XFRM_MODE_TUNNEL is not set # CONFIG_INET_XFRM_MODE_BEET is not set CONFIG_INET_LRO=y CONFIG_INET_DIAG=y CONFIG_INET_TCP_DIAG=y # CONFIG_TCP_CONG_ADVANCED is not set CONFIG_TCP_CONG_CUBIC=y CONFIG_DEFAULT_TCP_CONG="cubic" # CONFIG_TCP_MD5SIG is not set CONFIG_IPV6=m # CONFIG_IPV6_PRIVACY is not set # CONFIG_IPV6_ROUTER_PREF is not set # CONFIG_IPV6_OPTIMISTIC_DAD is not set # CONFIG_INET6_AH is not set # CONFIG_INET6_ESP is not set # CONFIG_INET6_IPCOMP is not set # CONFIG_IPV6_MIP6 is not set # CONFIG_INET6_XFRM_TUNNEL is not set # CONFIG_INET6_TUNNEL is not set CONFIG_INET6_XFRM_MODE_TRANSPORT=m CONFIG_INET6_XFRM_MODE_TUNNEL=m CONFIG_INET6_XFRM_MODE_BEET=m # CONFIG_INET6_XFRM_MODE_ROUTEOPTIMIZATION is not set CONFIG_IPV6_SIT=m CONFIG_IPV6_NDISC_NODETYPE=y # CONFIG_IPV6_TUNNEL is not set # CONFIG_IPV6_MULTIPLE_TABLES is not set # CONFIG_IPV6_MROUTE is not set # CONFIG_NETWORK_SECMARK is not set # CONFIG_NETFILTER is not set # CONFIG_IP_DCCP is not set # CONFIG_IP_SCTP is not set # CONFIG_RDS is not set # CONFIG_TIPC is not set # CONFIG_ATM is not set # CONFIG_BRIDGE is not set # CONFIG_NET_DSA is not set # CONFIG_VLAN_8021Q is not set # CONFIG_DECNET is not set # CONFIG_LLC2 is not set # CONFIG_IPX is not set # CONFIG_ATALK is not set # CONFIG_X25 is not set # CONFIG_LAPB is not set # CONFIG_ECONET is not set # CONFIG_WAN_ROUTER is not set # CONFIG_PHONET is not set # CONFIG_IEEE802154 is not set # CONFIG_NET_SCHED is not set # CONFIG_DCB is not set # # Network testing # # CONFIG_NET_PKTGEN is not set # CONFIG_NET_DROP_MONITOR is not set # CONFIG_HAMRADIO is not set CONFIG_CAN=m CONFIG_CAN_RAW=m CONFIG_CAN_BCM=m # # CAN Device Drivers # CONFIG_CAN_VCAN=m CONFIG_CAN_DEV=m CONFIG_CAN_CALC_BITTIMING=y CONFIG_CAN_AT91=m # CONFIG_CAN_SJA1000 is not set # # CAN USB interfaces # # CONFIG_CAN_EMS_USB is not set # CONFIG_CAN_DEBUG_DEVICES is not set # CONFIG_IRDA is not set # CONFIG_BT is not set # CONFIG_AF_RXRPC is not set CONFIG_WIRELESS=y CONFIG_CFG80211=m # CONFIG_NL80211_TESTMODE is not set # CONFIG_CFG80211_DEVELOPER_WARNINGS is not set # CONFIG_CFG80211_REG_DEBUG is not set CONFIG_CFG80211_DEFAULT_PS=y CONFIG_CFG80211_DEFAULT_PS_VALUE=1 # CONFIG_CFG80211_DEBUGFS is not set # CONFIG_WIRELESS_OLD_REGULATORY is not set CONFIG_WIRELESS_EXT=y CONFIG_WIRELESS_EXT_SYSFS=y CONFIG_LIB80211=y CONFIG_LIB80211_DEBUG=y CONFIG_MAC80211=m CONFIG_MAC80211_RC_MINSTREL=y # CONFIG_MAC80211_RC_DEFAULT_PID is not set CONFIG_MAC80211_RC_DEFAULT_MINSTREL=y CONFIG_MAC80211_RC_DEFAULT="minstrel" # CONFIG_MAC80211_MESH is not set # CONFIG_MAC80211_LEDS is not set # CONFIG_MAC80211_DEBUGFS is not set # CONFIG_MAC80211_DEBUG_MENU is not set # CONFIG_WIMAX is not set CONFIG_RFKILL=m CONFIG_RFKILL_INPUT=y # CONFIG_NET_9P is not set # # Device Drivers # # # Generic Driver Options # CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" # CONFIG_DEVTMPFS is not set CONFIG_STANDALONE=y CONFIG_PREVENT_FIRMWARE_BUILD=y CONFIG_FW_LOADER=y CONFIG_FIRMWARE_IN_KERNEL=y CONFIG_EXTRA_FIRMWARE="" # CONFIG_DEBUG_DRIVER is not set # CONFIG_DEBUG_DEVRES is not set # CONFIG_SYS_HYPERVISOR is not set # CONFIG_CONNECTOR is not set CONFIG_MTD=y # CONFIG_MTD_DEBUG is not set # CONFIG_MTD_TESTS is not set # CONFIG_MTD_CONCAT is not set CONFIG_MTD_PARTITIONS=y # CONFIG_MTD_REDBOOT_PARTS is not set CONFIG_MTD_CMDLINE_PARTS=y # CONFIG_MTD_AFS_PARTS is not set # CONFIG_MTD_AR7_PARTS is not set # # User Modules And Translation Layers # CONFIG_MTD_CHAR=y CONFIG_MTD_BLKDEVS=y CONFIG_MTD_BLOCK=y CONFIG_FTL=y # CONFIG_NFTL is not set # CONFIG_INFTL is not set # CONFIG_RFD_FTL is not set # CONFIG_SSFDC is not set # CONFIG_MTD_OOPS is not set # # RAM/ROM/Flash chip drivers # CONFIG_MTD_CFI=y CONFIG_MTD_JEDECPROBE=y CONFIG_MTD_GEN_PROBE=y CONFIG_MTD_CFI_ADV_OPTIONS=y CONFIG_MTD_CFI_NOSWAP=y # CONFIG_MTD_CFI_BE_BYTE_SWAP is not set # CONFIG_MTD_CFI_LE_BYTE_SWAP is not set # CONFIG_MTD_CFI_GEOMETRY is not set CONFIG_MTD_MAP_BANK_WIDTH_1=y CONFIG_MTD_MAP_BANK_WIDTH_2=y CONFIG_MTD_MAP_BANK_WIDTH_4=y # CONFIG_MTD_MAP_BANK_WIDTH_8 is not set # CONFIG_MTD_MAP_BANK_WIDTH_16 is not set # CONFIG_MTD_MAP_BANK_WIDTH_32 is not set CONFIG_MTD_CFI_I1=y CONFIG_MTD_CFI_I2=y # CONFIG_MTD_CFI_I4 is not set # CONFIG_MTD_CFI_I8 is not set # CONFIG_MTD_OTP is not set CONFIG_MTD_CFI_INTELEXT=y CONFIG_MTD_CFI_AMDSTD=y # CONFIG_MTD_CFI_STAA is not set CONFIG_MTD_CFI_UTIL=y # CONFIG_MTD_RAM is not set # CONFIG_MTD_ROM is not set # CONFIG_MTD_ABSENT is not set # # Mapping drivers for chip access # CONFIG_MTD_COMPLEX_MAPPINGS=y CONFIG_MTD_PHYSMAP=y CONFIG_MTD_PHYSMAP_COMPAT=y CONFIG_MTD_PHYSMAP_START=0x10000000 CONFIG_MTD_PHYSMAP_LEN=0x4000000 CONFIG_MTD_PHYSMAP_BANKWIDTH=2 # CONFIG_MTD_ARM_INTEGRATOR is not set # CONFIG_MTD_IMPA7 is not set # CONFIG_MTD_GPIO_ADDR is not set # CONFIG_MTD_PLATRAM is not set # # Self-contained MTD device drivers # CONFIG_MTD_DATAFLASH=y # CONFIG_MTD_DATAFLASH_WRITE_VERIFY is not set # CONFIG_MTD_DATAFLASH_OTP is not set # CONFIG_MTD_M25P80 is not set # CONFIG_MTD_SST25L is not set # CONFIG_MTD_SLRAM is not set # CONFIG_MTD_PHRAM is not set # CONFIG_MTD_MTDRAM is not set # CONFIG_MTD_BLOCK2MTD is not set # # Disk-On-Chip Device Drivers # # CONFIG_MTD_DOC2000 is not set # CONFIG_MTD_DOC2001 is not set # CONFIG_MTD_DOC2001PLUS is not set CONFIG_MTD_NAND=y # CONFIG_MTD_NAND_VERIFY_WRITE is not set # CONFIG_MTD_NAND_ECC_SMC is not set # CONFIG_MTD_NAND_MUSEUM_IDS is not set # CONFIG_MTD_NAND_GPIO is not set CONFIG_MTD_NAND_IDS=y # CONFIG_MTD_NAND_DISKONCHIP is not set CONFIG_MTD_NAND_ATMEL=y # CONFIG_MTD_NAND_ATMEL_ECC_HW is not set CONFIG_MTD_NAND_ATMEL_ECC_SOFT=y # CONFIG_MTD_NAND_ATMEL_ECC_NONE is not set # CONFIG_MTD_NAND_NANDSIM is not set # CONFIG_MTD_NAND_PLATFORM is not set # CONFIG_MTD_ALAUDA is not set # CONFIG_MTD_ONENAND is not set # # LPDDR flash memory drivers # # CONFIG_MTD_LPDDR is not set CONFIG_MTD_UBI=y CONFIG_MTD_UBI_WL_THRESHOLD=4096 CONFIG_MTD_UBI_BEB_RESERVE=1 # CONFIG_MTD_UBI_GLUEBI is not set # CONFIG_MTD_UBI_DEBUG is not set # CONFIG_PARPORT is not set CONFIG_BLK_DEV=y # CONFIG_BLK_DEV_COW_COMMON is not set CONFIG_BLK_DEV_LOOP=y # CONFIG_BLK_DEV_CRYPTOLOOP is not set # CONFIG_BLK_DEV_NBD is not set CONFIG_BLK_DEV_UB=m CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_COUNT=16 CONFIG_BLK_DEV_RAM_SIZE=8192 # CONFIG_BLK_DEV_XIP is not set # CONFIG_CDROM_PKTCDVD is not set # CONFIG_ATA_OVER_ETH is not set # CONFIG_MG_DISK is not set CONFIG_MISC_DEVICES=y CONFIG_ATMEL_PWM=m CONFIG_ATMEL_TCLIB=y # CONFIG_ATMEL_TCB_CLKSRC is not set # CONFIG_ICS932S401 is not set CONFIG_ATMEL_SSC=y # CONFIG_ENCLOSURE_SERVICES is not set # CONFIG_ISL29003 is not set # CONFIG_C2PORT is not set # # EEPROM support # # CONFIG_EEPROM_AT24 is not set # CONFIG_EEPROM_AT25 is not set # CONFIG_EEPROM_LEGACY is not set # CONFIG_EEPROM_MAX6875 is not set # CONFIG_EEPROM_93CX6 is not set CONFIG_HAVE_IDE=y # CONFIG_IDE is not set # # SCSI device support # # CONFIG_RAID_ATTRS is not set CONFIG_SCSI=y CONFIG_SCSI_DMA=y # CONFIG_SCSI_TGT is not set # CONFIG_SCSI_NETLINK is not set CONFIG_SCSI_PROC_FS=y # # SCSI support type (disk, tape, CD-ROM) # CONFIG_BLK_DEV_SD=y # CONFIG_CHR_DEV_ST is not set # CONFIG_CHR_DEV_OSST is not set # CONFIG_BLK_DEV_SR is not set # CONFIG_CHR_DEV_SG is not set # CONFIG_CHR_DEV_SCH is not set CONFIG_SCSI_MULTI_LUN=y # CONFIG_SCSI_CONSTANTS is not set # CONFIG_SCSI_LOGGING is not set # CONFIG_SCSI_SCAN_ASYNC is not set CONFIG_SCSI_WAIT_SCAN=m # # SCSI Transports # # CONFIG_SCSI_SPI_ATTRS is not set # CONFIG_SCSI_FC_ATTRS is not set # CONFIG_SCSI_ISCSI_ATTRS is not set # CONFIG_SCSI_SAS_LIBSAS is not set # CONFIG_SCSI_SRP_ATTRS is not set CONFIG_SCSI_LOWLEVEL=y # CONFIG_ISCSI_TCP is not set # CONFIG_LIBFC is not set # CONFIG_LIBFCOE is not set # CONFIG_SCSI_DEBUG is not set # CONFIG_SCSI_DH is not set # CONFIG_SCSI_OSD_INITIATOR is not set # CONFIG_ATA is not set # CONFIG_MD is not set CONFIG_NETDEVICES=y # CONFIG_DUMMY is not set # CONFIG_BONDING is not set # CONFIG_MACVLAN is not set # CONFIG_EQUALIZER is not set # CONFIG_TUN is not set # CONFIG_VETH is not set CONFIG_PHYLIB=y # # MII PHY device drivers # # CONFIG_MARVELL_PHY is not set # CONFIG_DAVICOM_PHY is not set # CONFIG_QSEMI_PHY is not set # CONFIG_LXT_PHY is not set # CONFIG_CICADA_PHY is not set # CONFIG_VITESSE_PHY is not set # CONFIG_SMSC_PHY is not set # CONFIG_BROADCOM_PHY is not set # CONFIG_ICPLUS_PHY is not set # CONFIG_REALTEK_PHY is not set # CONFIG_NATIONAL_PHY is not set # CONFIG_STE10XP is not set # CONFIG_LSI_ET1011C_PHY is not set # CONFIG_FIXED_PHY is not set # CONFIG_MDIO_BITBANG is not set CONFIG_NET_ETHERNET=y CONFIG_MII=y CONFIG_MACB=y CONFIG_MACB_TX_SRAM=y # CONFIG_AX88796 is not set # CONFIG_SMC91X is not set # CONFIG_DM9000 is not set # CONFIG_ENC28J60 is not set # CONFIG_ETHOC is not set # CONFIG_SMC911X is not set # CONFIG_SMSC911X is not set # CONFIG_DNET is not set # CONFIG_IBM_NEW_EMAC_ZMII is not set # CONFIG_IBM_NEW_EMAC_RGMII is not set # CONFIG_IBM_NEW_EMAC_TAH is not set # CONFIG_IBM_NEW_EMAC_EMAC4 is not set # CONFIG_IBM_NEW_EMAC_NO_FLOW_CTRL is not set # CONFIG_IBM_NEW_EMAC_MAL_CLR_ICINTSTAT is not set # CONFIG_IBM_NEW_EMAC_MAL_COMMON_ERR is not set # CONFIG_B44 is not set # CONFIG_KS8842 is not set # CONFIG_KS8851 is not set # CONFIG_KS8851_MLL is not set # CONFIG_NETDEV_1000 is not set # CONFIG_NETDEV_10000 is not set CONFIG_WLAN=y # CONFIG_WLAN_PRE80211 is not set CONFIG_WLAN_80211=y # CONFIG_LIBERTAS is not set # CONFIG_LIBERTAS_THINFIRM is not set # CONFIG_AT76C50X_USB is not set # CONFIG_USB_ZD1201 is not set # CONFIG_USB_NET_RNDIS_WLAN is not set # CONFIG_RTL8187 is not set # CONFIG_MAC80211_HWSIM is not set # CONFIG_P54_COMMON is not set # CONFIG_ATH_COMMON is not set # CONFIG_HOSTAP is not set # CONFIG_B43 is not set # CONFIG_B43LEGACY is not set # CONFIG_ZD1211RW is not set CONFIG_RT2X00=m CONFIG_RT2500USB=m CONFIG_RT73USB=m CONFIG_RT2800USB=m CONFIG_RT2X00_LIB_USB=m CONFIG_RT2X00_LIB=m CONFIG_RT2X00_LIB_HT=y CONFIG_RT2X00_LIB_FIRMWARE=y CONFIG_RT2X00_LIB_CRYPTO=y # CONFIG_RT2X00_DEBUG is not set # CONFIG_WL12XX is not set # CONFIG_IWM is not set # # Enable WiMAX (Networking options) to see the WiMAX drivers # # # USB Network Adapters # # CONFIG_USB_CATC is not set # CONFIG_USB_KAWETH is not set # CONFIG_USB_PEGASUS is not set # CONFIG_USB_RTL8150 is not set # CONFIG_USB_USBNET is not set # CONFIG_USB_HSO is not set # CONFIG_WAN is not set # CONFIG_PPP is not set # CONFIG_SLIP is not set # CONFIG_NETCONSOLE is not set # CONFIG_NETPOLL is not set # CONFIG_NET_POLL_CONTROLLER is not set # CONFIG_ISDN is not set # CONFIG_PHONE is not set # # Input device support # CONFIG_INPUT=y # CONFIG_INPUT_FF_MEMLESS is not set CONFIG_INPUT_POLLDEV=y # # Userland interfaces # CONFIG_INPUT_MOUSEDEV=y # CONFIG_INPUT_MOUSEDEV_PSAUX is not set CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024 CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768 # CONFIG_INPUT_JOYDEV is not set CONFIG_INPUT_EVDEV=y # CONFIG_INPUT_EVBUG is not set # # Input Device Drivers # CONFIG_INPUT_KEYBOARD=y # CONFIG_KEYBOARD_ADP5588 is not set # CONFIG_KEYBOARD_ATKBD is not set # CONFIG_QT2160 is not set # CONFIG_KEYBOARD_LKKBD is not set # CONFIG_KEYBOARD_GPIO is not set # CONFIG_KEYBOARD_MATRIX is not set # CONFIG_KEYBOARD_MAX7359 is not set # CONFIG_KEYBOARD_NEWTON is not set # CONFIG_KEYBOARD_OPENCORES is not set # CONFIG_KEYBOARD_STOWAWAY is not set # CONFIG_KEYBOARD_SUNKBD is not set # CONFIG_KEYBOARD_XTKBD is not set # CONFIG_INPUT_MOUSE is not set # CONFIG_INPUT_JOYSTICK is not set # CONFIG_INPUT_TABLET is not set CONFIG_INPUT_TOUCHSCREEN=y CONFIG_TOUCHSCREEN_ADS7846=m # CONFIG_TOUCHSCREEN_AD7877 is not set # CONFIG_TOUCHSCREEN_AD7879_I2C is not set # CONFIG_TOUCHSCREEN_AD7879_SPI is not set # CONFIG_TOUCHSCREEN_AD7879 is not set # CONFIG_TOUCHSCREEN_EETI is not set # CONFIG_TOUCHSCREEN_FUJITSU is not set # CONFIG_TOUCHSCREEN_GUNZE is not set # CONFIG_TOUCHSCREEN_ELO is not set # CONFIG_TOUCHSCREEN_WACOM_W8001 is not set # CONFIG_TOUCHSCREEN_MCS5000 is not set # CONFIG_TOUCHSCREEN_MTOUCH is not set # CONFIG_TOUCHSCREEN_INEXIO is not set # CONFIG_TOUCHSCREEN_MK712 is not set # CONFIG_TOUCHSCREEN_PENMOUNT is not set # CONFIG_TOUCHSCREEN_TOUCHRIGHT is not set # CONFIG_TOUCHSCREEN_TOUCHWIN is not set # CONFIG_TOUCHSCREEN_USB_COMPOSITE is not set # CONFIG_TOUCHSCREEN_TOUCHIT213 is not set # CONFIG_TOUCHSCREEN_TSC2007 is not set # CONFIG_TOUCHSCREEN_W90X900 is not set # CONFIG_INPUT_MISC is not set # # Hardware I/O ports # # CONFIG_SERIO is not set # CONFIG_GAMEPORT is not set # # Character devices # CONFIG_VT=y CONFIG_CONSOLE_TRANSLATIONS=y CONFIG_VT_CONSOLE=y CONFIG_HW_CONSOLE=y # CONFIG_VT_HW_CONSOLE_BINDING is not set CONFIG_DEVKMEM=y # CONFIG_SERIAL_NONSTANDARD is not set # # Serial drivers # # CONFIG_SERIAL_8250 is not set # # Non-8250 serial port support # CONFIG_SERIAL_ATMEL=y CONFIG_SERIAL_ATMEL_CONSOLE=y CONFIG_SERIAL_ATMEL_PDC=y # CONFIG_SERIAL_ATMEL_TTYAT is not set # CONFIG_SERIAL_MAX3100 is not set CONFIG_SERIAL_CORE=y CONFIG_SERIAL_CORE_CONSOLE=y CONFIG_UNIX98_PTYS=y # CONFIG_DEVPTS_MULTIPLE_INSTANCES is not set CONFIG_LEGACY_PTYS=y CONFIG_LEGACY_PTY_COUNT=256 # CONFIG_IPMI_HANDLER is not set CONFIG_HW_RANDOM=y # CONFIG_HW_RANDOM_TIMERIOMEM is not set # CONFIG_R3964 is not set # CONFIG_RAW_DRIVER is not set # CONFIG_TCG_TPM is not set CONFIG_I2C=y CONFIG_I2C_BOARDINFO=y CONFIG_I2C_COMPAT=y CONFIG_I2C_CHARDEV=y CONFIG_I2C_HELPER_AUTO=y CONFIG_I2C_ALGOBIT=y # # I2C Hardware Bus support # # # I2C system bus drivers (mostly embedded / system-on-chip) # # CONFIG_I2C_DESIGNWARE is not set CONFIG_I2C_GPIO=y # CONFIG_I2C_OCORES is not set # CONFIG_I2C_SIMTEC is not set # # External I2C/SMBus adapter drivers # # CONFIG_I2C_PARPORT_LIGHT is not set # CONFIG_I2C_TAOS_EVM is not set # CONFIG_I2C_TINY_USB is not set # # Other I2C/SMBus bus drivers # # CONFIG_I2C_PCA_PLATFORM is not set # CONFIG_I2C_STUB is not set # # Miscellaneous I2C Chip support # # CONFIG_DS1682 is not set # CONFIG_SENSORS_TSL2550 is not set # CONFIG_I2C_DEBUG_CORE is not set # CONFIG_I2C_DEBUG_ALGO is not set # CONFIG_I2C_DEBUG_BUS is not set # CONFIG_I2C_DEBUG_CHIP is not set CONFIG_SPI=y # CONFIG_SPI_DEBUG is not set CONFIG_SPI_MASTER=y # # SPI Master Controller Drivers # CONFIG_SPI_ATMEL=y # CONFIG_SPI_BITBANG is not set # CONFIG_SPI_GPIO is not set # # SPI Protocol Masters # # CONFIG_SPI_SPIDEV is not set # CONFIG_SPI_TLE62X0 is not set # # PPS support # # CONFIG_PPS is not set CONFIG_ARCH_REQUIRE_GPIOLIB=y CONFIG_GPIOLIB=y CONFIG_DEBUG_GPIO=y CONFIG_GPIO_SYSFS=y # # Memory mapped GPIO expanders: # # # I2C GPIO expanders: # # CONFIG_GPIO_MAX732X is not set # CONFIG_GPIO_PCA953X is not set # CONFIG_GPIO_PCF857X is not set # # PCI GPIO expanders: # # # SPI GPIO expanders: # # CONFIG_GPIO_MAX7301 is not set # CONFIG_GPIO_MCP23S08 is not set # CONFIG_GPIO_MC33880 is not set # # AC97 GPIO expanders: # # CONFIG_W1 is not set # CONFIG_POWER_SUPPLY is not set # CONFIG_HWMON is not set # CONFIG_THERMAL is not set CONFIG_WATCHDOG=y CONFIG_WATCHDOG_NOWAYOUT=y # # Watchdog Device Drivers # # CONFIG_SOFT_WATCHDOG is not set CONFIG_AT91SAM9X_WATCHDOG=m # # USB-based Watchdog Cards # # CONFIG_USBPCWATCHDOG is not set CONFIG_SSB_POSSIBLE=y # # Sonics Silicon Backplane # # CONFIG_SSB is not set # # Multifunction device drivers # # CONFIG_MFD_CORE is not set # CONFIG_MFD_SM501 is not set # CONFIG_MFD_ASIC3 is not set # CONFIG_HTC_EGPIO is not set # CONFIG_HTC_PASIC3 is not set # CONFIG_TPS65010 is not set # CONFIG_TWL4030_CORE is not set # CONFIG_MFD_TMIO is not set # CONFIG_MFD_T7L66XB is not set # CONFIG_MFD_TC6387XB is not set # CONFIG_MFD_TC6393XB is not set # CONFIG_PMIC_DA903X is not set # CONFIG_MFD_WM8400 is not set # CONFIG_MFD_WM831X is not set # CONFIG_MFD_WM8350_I2C is not set # CONFIG_MFD_PCF50633 is not set # CONFIG_MFD_MC13783 is not set # CONFIG_AB3100_CORE is not set # CONFIG_EZX_PCAP is not set # CONFIG_REGULATOR is not set # CONFIG_MEDIA_SUPPORT is not set # # Graphics support # # CONFIG_VGASTATE is not set # CONFIG_VIDEO_OUTPUT_CONTROL is not set CONFIG_FB=y # CONFIG_FIRMWARE_EDID is not set # CONFIG_FB_DDC is not set # CONFIG_FB_BOOT_VESA_SUPPORT is not set CONFIG_FB_CFB_FILLRECT=m CONFIG_FB_CFB_COPYAREA=m CONFIG_FB_CFB_IMAGEBLIT=m # CONFIG_FB_CFB_REV_PIXELS_IN_BYTE is not set # CONFIG_FB_SYS_FILLRECT is not set # CONFIG_FB_SYS_COPYAREA is not set # CONFIG_FB_SYS_IMAGEBLIT is not set # CONFIG_FB_FOREIGN_ENDIAN is not set # CONFIG_FB_SYS_FOPS is not set # CONFIG_FB_SVGALIB is not set # CONFIG_FB_MACMODES is not set # CONFIG_FB_BACKLIGHT is not set # CONFIG_FB_MODE_HELPERS is not set # CONFIG_FB_TILEBLITTING is not set # # Frame buffer hardware drivers # # CONFIG_FB_S1D13XXX is not set CONFIG_FB_ATMEL=m # CONFIG_FB_VIRTUAL is not set # CONFIG_FB_METRONOME is not set # CONFIG_FB_MB862XX is not set # CONFIG_FB_BROADSHEET is not set CONFIG_BACKLIGHT_LCD_SUPPORT=y # CONFIG_LCD_CLASS_DEVICE is not set CONFIG_BACKLIGHT_CLASS_DEVICE=y CONFIG_BACKLIGHT_ATMEL_LCDC=y CONFIG_BACKLIGHT_ATMEL_PWM=m # CONFIG_BACKLIGHT_GENERIC is not set # # Display device support # # CONFIG_DISPLAY_SUPPORT is not set # # Console display driver support # # CONFIG_VGA_CONSOLE is not set CONFIG_DUMMY_CONSOLE=y # CONFIG_FRAMEBUFFER_CONSOLE is not set # CONFIG_LOGO is not set # CONFIG_SOUND is not set CONFIG_HID_SUPPORT=y CONFIG_HID=y # CONFIG_HIDRAW is not set # # USB Input Devices # # CONFIG_USB_HID is not set # CONFIG_HID_PID is not set # # Special HID drivers # CONFIG_USB_SUPPORT=y CONFIG_USB_ARCH_HAS_HCD=y CONFIG_USB_ARCH_HAS_OHCI=y # CONFIG_USB_ARCH_HAS_EHCI is not set CONFIG_USB=y # CONFIG_USB_DEBUG is not set # CONFIG_USB_ANNOUNCE_NEW_DEVICES is not set # # Miscellaneous USB options # CONFIG_USB_DEVICEFS=y CONFIG_USB_DEVICE_CLASS=y # CONFIG_USB_DYNAMIC_MINORS is not set # CONFIG_USB_OTG is not set CONFIG_USB_MON=m # CONFIG_USB_WUSB is not set # CONFIG_USB_WUSB_CBAF is not set # # USB Host Controller Drivers # # CONFIG_USB_C67X00_HCD is not set # CONFIG_USB_OXU210HP_HCD is not set # CONFIG_USB_ISP116X_HCD is not set # CONFIG_USB_ISP1760_HCD is not set # CONFIG_USB_ISP1362_HCD is not set CONFIG_USB_OHCI_HCD=m # CONFIG_USB_OHCI_BIG_ENDIAN_DESC is not set # CONFIG_USB_OHCI_BIG_ENDIAN_MMIO is not set CONFIG_USB_OHCI_LITTLE_ENDIAN=y # CONFIG_USB_SL811_HCD is not set # CONFIG_USB_R8A66597_HCD is not set # CONFIG_USB_HWA_HCD is not set # CONFIG_USB_MUSB_HDRC is not set # CONFIG_USB_GADGET_MUSB_HDRC is not set # # USB Device Class drivers # # CONFIG_USB_ACM is not set # CONFIG_USB_PRINTER is not set # CONFIG_USB_WDM is not set # CONFIG_USB_TMC is not set # # NOTE: USB_STORAGE depends on SCSI but BLK_DEV_SD may # # # also be needed; see USB_STORAGE Help for more info # CONFIG_USB_STORAGE=m # CONFIG_USB_STORAGE_DEBUG is not set # CONFIG_USB_STORAGE_DATAFAB is not set # CONFIG_USB_STORAGE_FREECOM is not set # CONFIG_USB_STORAGE_ISD200 is not set # CONFIG_USB_STORAGE_USBAT is not set # CONFIG_USB_STORAGE_SDDR09 is not set # CONFIG_USB_STORAGE_SDDR55 is not set # CONFIG_USB_STORAGE_JUMPSHOT is not set # CONFIG_USB_STORAGE_ALAUDA is not set # CONFIG_USB_STORAGE_ONETOUCH is not set # CONFIG_USB_STORAGE_KARMA is not set # CONFIG_USB_STORAGE_CYPRESS_ATACB is not set # CONFIG_USB_LIBUSUAL is not set # # USB Imaging devices # # CONFIG_USB_MDC800 is not set # CONFIG_USB_MICROTEK is not set # # USB port drivers # CONFIG_USB_SERIAL=m # CONFIG_USB_EZUSB is not set # CONFIG_USB_SERIAL_GENERIC is not set # CONFIG_USB_SERIAL_AIRCABLE is not set # CONFIG_USB_SERIAL_ARK3116 is not set # CONFIG_USB_SERIAL_BELKIN is not set # CONFIG_USB_SERIAL_CH341 is not set # CONFIG_USB_SERIAL_WHITEHEAT is not set # CONFIG_USB_SERIAL_DIGI_ACCELEPORT is not set # CONFIG_USB_SERIAL_CP210X is not set # CONFIG_USB_SERIAL_CYPRESS_M8 is not set # CONFIG_USB_SERIAL_EMPEG is not set CONFIG_USB_SERIAL_FTDI_SIO=m # CONFIG_USB_SERIAL_FUNSOFT is not set # CONFIG_USB_SERIAL_VISOR is not set # CONFIG_USB_SERIAL_IPAQ is not set # CONFIG_USB_SERIAL_IR is not set # CONFIG_USB_SERIAL_EDGEPORT is not set # CONFIG_USB_SERIAL_EDGEPORT_TI is not set # CONFIG_USB_SERIAL_GARMIN is not set # CONFIG_USB_SERIAL_IPW is not set # CONFIG_USB_SERIAL_IUU is not set # CONFIG_USB_SERIAL_KEYSPAN_PDA is not set # CONFIG_USB_SERIAL_KEYSPAN is not set # CONFIG_USB_SERIAL_KLSI is not set # CONFIG_USB_SERIAL_KOBIL_SCT is not set # CONFIG_USB_SERIAL_MCT_U232 is not set # CONFIG_USB_SERIAL_MOS7720 is not set # CONFIG_USB_SERIAL_MOS7840 is not set # CONFIG_USB_SERIAL_MOTOROLA is not set # CONFIG_USB_SERIAL_NAVMAN is not set CONFIG_USB_SERIAL_PL2303=m # CONFIG_USB_SERIAL_OTI6858 is not set # CONFIG_USB_SERIAL_QUALCOMM is not set # CONFIG_USB_SERIAL_SPCP8X5 is not set # CONFIG_USB_SERIAL_HP4X is not set # CONFIG_USB_SERIAL_SAFE is not set # CONFIG_USB_SERIAL_SIEMENS_MPI is not set # CONFIG_USB_SERIAL_SIERRAWIRELESS is not set # CONFIG_USB_SERIAL_SYMBOL is not set # CONFIG_USB_SERIAL_TI is not set # CONFIG_USB_SERIAL_CYBERJACK is not set # CONFIG_USB_SERIAL_XIRCOM is not set # CONFIG_USB_SERIAL_OPTION is not set # CONFIG_USB_SERIAL_OMNINET is not set # CONFIG_USB_SERIAL_OPTICON is not set # CONFIG_USB_SERIAL_DEBUG is not set # # USB Miscellaneous drivers # # CONFIG_USB_EMI62 is not set # CONFIG_USB_EMI26 is not set # CONFIG_USB_ADUTUX is not set # CONFIG_USB_SEVSEG is not set # CONFIG_USB_RIO500 is not set # CONFIG_USB_LEGOTOWER is not set # CONFIG_USB_LCD is not set # CONFIG_USB_BERRY_CHARGE is not set # CONFIG_USB_LED is not set # CONFIG_USB_CYPRESS_CY7C63 is not set # CONFIG_USB_CYTHERM is not set # CONFIG_USB_IDMOUSE is not set # CONFIG_USB_FTDI_ELAN is not set # CONFIG_USB_APPLEDISPLAY is not set # CONFIG_USB_LD is not set # CONFIG_USB_TRANCEVIBRATOR is not set # CONFIG_USB_IOWARRIOR is not set # CONFIG_USB_TEST is not set # CONFIG_USB_ISIGHTFW is not set # CONFIG_USB_VST is not set CONFIG_USB_GADGET=y # CONFIG_USB_GADGET_DEBUG is not set # CONFIG_USB_GADGET_DEBUG_FILES is not set # CONFIG_USB_GADGET_DEBUG_FS is not set CONFIG_USB_GADGET_VBUS_DRAW=2 CONFIG_USB_GADGET_SELECTED=y CONFIG_USB_GADGET_AT91=y CONFIG_USB_AT91=y # CONFIG_USB_GADGET_ATMEL_USBA is not set # CONFIG_USB_GADGET_FSL_USB2 is not set # CONFIG_USB_GADGET_LH7A40X is not set # CONFIG_USB_GADGET_OMAP is not set # CONFIG_USB_GADGET_PXA25X is not set # CONFIG_USB_GADGET_R8A66597 is not set # CONFIG_USB_GADGET_PXA27X is not set # CONFIG_USB_GADGET_S3C_HSOTG is not set # CONFIG_USB_GADGET_IMX is not set # CONFIG_USB_GADGET_S3C2410 is not set # CONFIG_USB_GADGET_M66592 is not set # CONFIG_USB_GADGET_AMD5536UDC is not set # CONFIG_USB_GADGET_FSL_QE is not set # CONFIG_USB_GADGET_CI13XXX is not set # CONFIG_USB_GADGET_NET2280 is not set # CONFIG_USB_GADGET_GOKU is not set # CONFIG_USB_GADGET_LANGWELL is not set # CONFIG_USB_GADGET_DUMMY_HCD is not set # CONFIG_USB_GADGET_DUALSPEED is not set CONFIG_USB_ZERO=m # CONFIG_USB_AUDIO is not set # CONFIG_USB_ETH is not set CONFIG_USB_GADGETFS=m CONFIG_USB_FILE_STORAGE=m # CONFIG_USB_FILE_STORAGE_TEST is not set CONFIG_USB_G_SERIAL=m # CONFIG_USB_MIDI_GADGET is not set # CONFIG_USB_G_PRINTER is not set # CONFIG_USB_CDC_COMPOSITE is not set # # OTG and related infrastructure # # CONFIG_USB_GPIO_VBUS is not set # CONFIG_NOP_USB_XCEIV is not set CONFIG_MMC=y # CONFIG_MMC_DEBUG is not set # CONFIG_MMC_UNSAFE_RESUME is not set # # MMC/SD/SDIO Card Drivers # CONFIG_MMC_BLOCK=m CONFIG_MMC_BLOCK_BOUNCE=y # CONFIG_SDIO_UART is not set # CONFIG_MMC_TEST is not set # # MMC/SD/SDIO Host Controller Drivers # # CONFIG_MMC_SDHCI is not set CONFIG_MMC_AT91=m # CONFIG_MMC_ATMELMCI is not set # CONFIG_MMC_SPI is not set # CONFIG_MEMSTICK is not set # CONFIG_NEW_LEDS is not set # CONFIG_ACCESSIBILITY is not set CONFIG_RTC_LIB=y CONFIG_RTC_CLASS=y CONFIG_RTC_HCTOSYS=y CONFIG_RTC_HCTOSYS_DEVICE="rtc0" # CONFIG_RTC_DEBUG is not set # # RTC interfaces # CONFIG_RTC_INTF_SYSFS=y CONFIG_RTC_INTF_PROC=y CONFIG_RTC_INTF_DEV=y # CONFIG_RTC_INTF_DEV_UIE_EMUL is not set # CONFIG_RTC_DRV_TEST is not set # # I2C RTC drivers # # CONFIG_RTC_DRV_DS1307 is not set CONFIG_RTC_DRV_DS1374=m # CONFIG_RTC_DRV_DS1672 is not set # CONFIG_RTC_DRV_MAX6900 is not set # CONFIG_RTC_DRV_RS5C372 is not set # CONFIG_RTC_DRV_ISL1208 is not set # CONFIG_RTC_DRV_X1205 is not set # CONFIG_RTC_DRV_PCF8563 is not set # CONFIG_RTC_DRV_PCF8583 is not set CONFIG_RTC_DRV_M41T80=m CONFIG_RTC_DRV_M41T80_WDT=y # CONFIG_RTC_DRV_S35390A is not set # CONFIG_RTC_DRV_FM3130 is not set # CONFIG_RTC_DRV_RX8581 is not set # CONFIG_RTC_DRV_RX8025 is not set # # SPI RTC drivers # # CONFIG_RTC_DRV_M41T94 is not set # CONFIG_RTC_DRV_DS1305 is not set # CONFIG_RTC_DRV_DS1390 is not set # CONFIG_RTC_DRV_MAX6902 is not set # CONFIG_RTC_DRV_R9701 is not set # CONFIG_RTC_DRV_RS5C348 is not set # CONFIG_RTC_DRV_DS3234 is not set # CONFIG_RTC_DRV_PCF2123 is not set # # Platform RTC drivers # # CONFIG_RTC_DRV_CMOS is not set # CONFIG_RTC_DRV_DS1286 is not set # CONFIG_RTC_DRV_DS1511 is not set # CONFIG_RTC_DRV_DS1553 is not set # CONFIG_RTC_DRV_DS1742 is not set # CONFIG_RTC_DRV_STK17TA8 is not set # CONFIG_RTC_DRV_M48T86 is not set # CONFIG_RTC_DRV_M48T35 is not set # CONFIG_RTC_DRV_M48T59 is not set # CONFIG_RTC_DRV_BQ4802 is not set # CONFIG_RTC_DRV_V3020 is not set # # on-CPU RTC drivers # CONFIG_RTC_DRV_AT91SAM9=m CONFIG_RTC_DRV_AT91SAM9_RTT=0 CONFIG_RTC_DRV_AT91SAM9_GPBR=0 # CONFIG_DMADEVICES is not set # CONFIG_AUXDISPLAY is not set # CONFIG_UIO is not set # # TI VLYNQ # # CONFIG_STAGING is not set # # Skov Drivers # CONFIG_RESET_STATE_DRIVER=m CONFIG_UNDER_VOLTAGE_DEVICE=y CONFIG_UNDER_VOLTAGE_DRIVER=y CONFIG_PWM_DEVICE=y CONFIG_PWM_DRIVER=m CONFIG_LCD_LC7981_DEVICE=y CONFIG_LCD_LC7981_DRIVER=m CONFIG_MATRIX_KBD_DEVICE=y CONFIG_MATRIX_KBD_DRIVER=m CONFIG_MATRIX_TEST=m CONFIG_ENCODER_DEVICE=y CONFIG_ENCODER_DRIVER=m CONFIG_LED_DEVICE=y CONFIG_LED_DRIVER=m CONFIG_SKOV_POWER_FAIL_DETECT=m CONFIG_ADC_MCP3002=m # # BD Drivers # CONFIG_BD_GPIO=m # # File systems # CONFIG_EXT2_FS=y CONFIG_EXT2_FS_XATTR=y # CONFIG_EXT2_FS_POSIX_ACL is not set # CONFIG_EXT2_FS_SECURITY is not set # CONFIG_EXT2_FS_XIP is not set CONFIG_EXT3_FS=m CONFIG_EXT3_DEFAULTS_TO_ORDERED=y # CONFIG_EXT3_FS_XATTR is not set CONFIG_EXT4_FS=m # CONFIG_EXT4_FS_XATTR is not set # CONFIG_EXT4_DEBUG is not set CONFIG_JBD=m # CONFIG_JBD_DEBUG is not set CONFIG_JBD2=m # CONFIG_JBD2_DEBUG is not set CONFIG_FS_MBCACHE=y # CONFIG_REISERFS_FS is not set # CONFIG_JFS_FS is not set # CONFIG_FS_POSIX_ACL is not set # CONFIG_XFS_FS is not set # CONFIG_GFS2_FS is not set # CONFIG_OCFS2_FS is not set # CONFIG_BTRFS_FS is not set # CONFIG_NILFS2_FS is not set CONFIG_FILE_LOCKING=y CONFIG_FSNOTIFY=y CONFIG_DNOTIFY=y CONFIG_INOTIFY=y CONFIG_INOTIFY_USER=y # CONFIG_QUOTA is not set # CONFIG_AUTOFS_FS is not set # CONFIG_AUTOFS4_FS is not set CONFIG_FUSE_FS=m # CONFIG_CUSE is not set # # Caches # # CONFIG_FSCACHE is not set # # CD-ROM/DVD Filesystems # # CONFIG_ISO9660_FS is not set # CONFIG_UDF_FS is not set # # DOS/FAT/NT Filesystems # CONFIG_FAT_FS=m # CONFIG_MSDOS_FS is not set CONFIG_VFAT_FS=m CONFIG_FAT_DEFAULT_CODEPAGE=437 CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" CONFIG_NTFS_FS=m # CONFIG_NTFS_DEBUG is not set # CONFIG_NTFS_RW is not set # # Pseudo filesystems # CONFIG_PROC_FS=y CONFIG_PROC_SYSCTL=y CONFIG_PROC_PAGE_MONITOR=y CONFIG_SYSFS=y CONFIG_TMPFS=y # CONFIG_TMPFS_POSIX_ACL is not set # CONFIG_HUGETLB_PAGE is not set # CONFIG_CONFIGFS_FS is not set CONFIG_MISC_FILESYSTEMS=y # CONFIG_ADFS_FS is not set # CONFIG_AFFS_FS is not set # CONFIG_HFS_FS is not set # CONFIG_HFSPLUS_FS is not set # CONFIG_BEFS_FS is not set # CONFIG_BFS_FS is not set # CONFIG_EFS_FS is not set # CONFIG_JFFS2_FS is not set CONFIG_UBIFS_FS=y # CONFIG_UBIFS_FS_XATTR is not set # CONFIG_UBIFS_FS_ADVANCED_COMPR is not set CONFIG_UBIFS_FS_LZO=y CONFIG_UBIFS_FS_ZLIB=y # CONFIG_UBIFS_FS_DEBUG is not set CONFIG_CRAMFS=y # CONFIG_SQUASHFS is not set # CONFIG_VXFS_FS is not set # CONFIG_MINIX_FS is not set # CONFIG_OMFS_FS is not set # CONFIG_HPFS_FS is not set # CONFIG_QNX4FS_FS is not set # CONFIG_ROMFS_FS is not set # CONFIG_SYSV_FS is not set # CONFIG_UFS_FS is not set CONFIG_NETWORK_FILESYSTEMS=y CONFIG_NFS_FS=y CONFIG_NFS_V3=y # CONFIG_NFS_V3_ACL is not set # CONFIG_NFS_V4 is not set CONFIG_ROOT_NFS=y # CONFIG_NFSD is not set CONFIG_LOCKD=y CONFIG_LOCKD_V4=y CONFIG_NFS_COMMON=y CONFIG_SUNRPC=y # CONFIG_RPCSEC_GSS_KRB5 is not set # CONFIG_RPCSEC_GSS_SPKM3 is not set # CONFIG_SMB_FS is not set # CONFIG_CIFS is not set # CONFIG_NCP_FS is not set # CONFIG_CODA_FS is not set # CONFIG_AFS_FS is not set # # Partition Types # CONFIG_PARTITION_ADVANCED=y # CONFIG_ACORN_PARTITION is not set # CONFIG_OSF_PARTITION is not set # CONFIG_AMIGA_PARTITION is not set # CONFIG_ATARI_PARTITION is not set # CONFIG_MAC_PARTITION is not set CONFIG_MSDOS_PARTITION=y # CONFIG_BSD_DISKLABEL is not set # CONFIG_MINIX_SUBPARTITION is not set # CONFIG_SOLARIS_X86_PARTITION is not set # CONFIG_UNIXWARE_DISKLABEL is not set # CONFIG_LDM_PARTITION is not set # CONFIG_SGI_PARTITION is not set # CONFIG_ULTRIX_PARTITION is not set # CONFIG_SUN_PARTITION is not set # CONFIG_KARMA_PARTITION is not set # CONFIG_EFI_PARTITION is not set # CONFIG_SYSV68_PARTITION is not set CONFIG_NLS=y CONFIG_NLS_DEFAULT="iso8859-1" CONFIG_NLS_CODEPAGE_437=y # CONFIG_NLS_CODEPAGE_737 is not set # CONFIG_NLS_CODEPAGE_775 is not set CONFIG_NLS_CODEPAGE_850=y # CONFIG_NLS_CODEPAGE_852 is not set # CONFIG_NLS_CODEPAGE_855 is not set # CONFIG_NLS_CODEPAGE_857 is not set # CONFIG_NLS_CODEPAGE_860 is not set # CONFIG_NLS_CODEPAGE_861 is not set # CONFIG_NLS_CODEPAGE_862 is not set # CONFIG_NLS_CODEPAGE_863 is not set # CONFIG_NLS_CODEPAGE_864 is not set # CONFIG_NLS_CODEPAGE_865 is not set # CONFIG_NLS_CODEPAGE_866 is not set # CONFIG_NLS_CODEPAGE_869 is not set # CONFIG_NLS_CODEPAGE_936 is not set # CONFIG_NLS_CODEPAGE_950 is not set # CONFIG_NLS_CODEPAGE_932 is not set # CONFIG_NLS_CODEPAGE_949 is not set # CONFIG_NLS_CODEPAGE_874 is not set # CONFIG_NLS_ISO8859_8 is not set # CONFIG_NLS_CODEPAGE_1250 is not set # CONFIG_NLS_CODEPAGE_1251 is not set # CONFIG_NLS_ASCII is not set CONFIG_NLS_ISO8859_1=y # CONFIG_NLS_ISO8859_2 is not set # CONFIG_NLS_ISO8859_3 is not set # CONFIG_NLS_ISO8859_4 is not set # CONFIG_NLS_ISO8859_5 is not set # CONFIG_NLS_ISO8859_6 is not set # CONFIG_NLS_ISO8859_7 is not set # CONFIG_NLS_ISO8859_9 is not set # CONFIG_NLS_ISO8859_13 is not set # CONFIG_NLS_ISO8859_14 is not set # CONFIG_NLS_ISO8859_15 is not set # CONFIG_NLS_KOI8_R is not set # CONFIG_NLS_KOI8_U is not set # CONFIG_NLS_UTF8 is not set # CONFIG_DLM is not set # # Kernel hacking # CONFIG_PRINTK_TIME=y CONFIG_ENABLE_WARN_DEPRECATED=y CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024 # CONFIG_MAGIC_SYSRQ is not set # CONFIG_STRIP_ASM_SYMS is not set # CONFIG_UNUSED_SYMBOLS is not set CONFIG_DEBUG_FS=y # CONFIG_HEADERS_CHECK is not set CONFIG_DEBUG_KERNEL=y # CONFIG_DEBUG_SHIRQ is not set CONFIG_DETECT_SOFTLOCKUP=y # CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC is not set CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC_VALUE=0 CONFIG_DETECT_HUNG_TASK=y # CONFIG_BOOTPARAM_HUNG_TASK_PANIC is not set CONFIG_BOOTPARAM_HUNG_TASK_PANIC_VALUE=0 CONFIG_SCHED_DEBUG=y CONFIG_SCHEDSTATS=y # CONFIG_TIMER_STATS is not set # CONFIG_DEBUG_OBJECTS is not set # CONFIG_DEBUG_SLAB is not set # CONFIG_DEBUG_KMEMLEAK is not set CONFIG_DEBUG_PREEMPT=y # CONFIG_DEBUG_RT_MUTEXES is not set # CONFIG_RT_MUTEX_TESTER is not set # CONFIG_DEBUG_SPINLOCK is not set # CONFIG_DEBUG_MUTEXES is not set # CONFIG_DEBUG_LOCK_ALLOC is not set # CONFIG_PROVE_LOCKING is not set # CONFIG_LOCK_STAT is not set # CONFIG_DEBUG_SPINLOCK_SLEEP is not set # CONFIG_DEBUG_LOCKING_API_SELFTESTS is not set CONFIG_STACKTRACE=y # CONFIG_DEBUG_KOBJECT is not set CONFIG_DEBUG_BUGVERBOSE=y CONFIG_DEBUG_INFO=y # CONFIG_DEBUG_VM is not set # CONFIG_DEBUG_WRITECOUNT is not set CONFIG_DEBUG_MEMORY_INIT=y # CONFIG_DEBUG_LIST is not set # CONFIG_TEST_LIST_SORT is not set # CONFIG_DEBUG_SG is not set # CONFIG_DEBUG_NOTIFIERS is not set # CONFIG_DEBUG_CREDENTIALS is not set CONFIG_FRAME_POINTER=y # CONFIG_BOOT_PRINTK_DELAY is not set # CONFIG_RCU_TORTURE_TEST is not set # CONFIG_RCU_CPU_STALL_DETECTOR is not set # CONFIG_BACKTRACE_SELF_TEST is not set # CONFIG_DEBUG_BLOCK_EXT_DEVT is not set # CONFIG_DEBUG_FORCE_WEAK_PER_CPU is not set # CONFIG_FAULT_INJECTION is not set CONFIG_LATENCYTOP=y # CONFIG_SYSCTL_SYSCALL_CHECK is not set # CONFIG_PAGE_POISONING is not set CONFIG_NOP_TRACER=y CONFIG_HAVE_FUNCTION_TRACER=y CONFIG_RING_BUFFER=y CONFIG_EVENT_TRACING=y CONFIG_CONTEXT_SWITCH_TRACER=y CONFIG_TRACING=y CONFIG_GENERIC_TRACER=y CONFIG_TRACING_SUPPORT=y CONFIG_FTRACE=y # CONFIG_FUNCTION_TRACER is not set # CONFIG_IRQSOFF_TRACER is not set # CONFIG_PREEMPT_TRACER is not set # CONFIG_SCHED_TRACER is not set CONFIG_BOOT_TRACER=y CONFIG_BRANCH_PROFILE_NONE=y # CONFIG_PROFILE_ANNOTATED_BRANCHES is not set # CONFIG_PROFILE_ALL_BRANCHES is not set # CONFIG_STACK_TRACER is not set # CONFIG_KMEMTRACE is not set # CONFIG_WORKQUEUE_TRACER is not set # CONFIG_BLK_DEV_IO_TRACE is not set # CONFIG_FTRACE_STARTUP_TEST is not set # CONFIG_RING_BUFFER_BENCHMARK is not set # CONFIG_DYNAMIC_DEBUG is not set # CONFIG_SAMPLES is not set CONFIG_HAVE_ARCH_KGDB=y # CONFIG_KGDB is not set CONFIG_ARM_UNWIND=y CONFIG_DEBUG_USER=y # CONFIG_DEBUG_ERRORS is not set # CONFIG_DEBUG_STACK_USAGE is not set CONFIG_DEBUG_LL=y # CONFIG_DEBUG_ICEDCC is not set # # Security options # # CONFIG_KEYS is not set # CONFIG_SECURITY is not set # CONFIG_SECURITYFS is not set # CONFIG_SECURITY_FILE_CAPABILITIES is not set CONFIG_CRYPTO=y # # Crypto core or helper # CONFIG_CRYPTO_ALGAPI=y CONFIG_CRYPTO_ALGAPI2=y CONFIG_CRYPTO_AEAD2=y CONFIG_CRYPTO_BLKCIPHER=y CONFIG_CRYPTO_BLKCIPHER2=y CONFIG_CRYPTO_HASH2=y CONFIG_CRYPTO_RNG2=y CONFIG_CRYPTO_PCOMP=y CONFIG_CRYPTO_MANAGER=y CONFIG_CRYPTO_MANAGER2=y # CONFIG_CRYPTO_GF128MUL is not set # CONFIG_CRYPTO_NULL is not set CONFIG_CRYPTO_WORKQUEUE=y # CONFIG_CRYPTO_CRYPTD is not set # CONFIG_CRYPTO_AUTHENC is not set # CONFIG_CRYPTO_TEST is not set # # Authenticated Encryption with Associated Data # # CONFIG_CRYPTO_CCM is not set # CONFIG_CRYPTO_GCM is not set # CONFIG_CRYPTO_SEQIV is not set # # Block modes # # CONFIG_CRYPTO_CBC is not set # CONFIG_CRYPTO_CTR is not set # CONFIG_CRYPTO_CTS is not set CONFIG_CRYPTO_ECB=y # CONFIG_CRYPTO_LRW is not set # CONFIG_CRYPTO_PCBC is not set # CONFIG_CRYPTO_XTS is not set # # Hash modes # # CONFIG_CRYPTO_HMAC is not set # CONFIG_CRYPTO_XCBC is not set # CONFIG_CRYPTO_VMAC is not set # # Digest # # CONFIG_CRYPTO_CRC32C is not set # CONFIG_CRYPTO_GHASH is not set # CONFIG_CRYPTO_MD4 is not set # CONFIG_CRYPTO_MD5 is not set # CONFIG_CRYPTO_MICHAEL_MIC is not set # CONFIG_CRYPTO_RMD128 is not set # CONFIG_CRYPTO_RMD160 is not set # CONFIG_CRYPTO_RMD256 is not set # CONFIG_CRYPTO_RMD320 is not set # CONFIG_CRYPTO_SHA1 is not set # CONFIG_CRYPTO_SHA256 is not set # CONFIG_CRYPTO_SHA512 is not set # CONFIG_CRYPTO_TGR192 is not set # CONFIG_CRYPTO_WP512 is not set # # Ciphers # CONFIG_CRYPTO_AES=y # CONFIG_CRYPTO_ANUBIS is not set CONFIG_CRYPTO_ARC4=y # CONFIG_CRYPTO_BLOWFISH is not set # CONFIG_CRYPTO_CAMELLIA is not set # CONFIG_CRYPTO_CAST5 is not set # CONFIG_CRYPTO_CAST6 is not set # CONFIG_CRYPTO_DES is not set # CONFIG_CRYPTO_FCRYPT is not set # CONFIG_CRYPTO_KHAZAD is not set # CONFIG_CRYPTO_SALSA20 is not set # CONFIG_CRYPTO_SEED is not set # CONFIG_CRYPTO_SERPENT is not set # CONFIG_CRYPTO_TEA is not set # CONFIG_CRYPTO_TWOFISH is not set # # Compression # CONFIG_CRYPTO_DEFLATE=y # CONFIG_CRYPTO_ZLIB is not set CONFIG_CRYPTO_LZO=y # # Random Number Generation # # CONFIG_CRYPTO_ANSI_CPRNG is not set CONFIG_CRYPTO_HW=y CONFIG_BINARY_PRINTF=y # # Library routines # CONFIG_BITREVERSE=y CONFIG_GENERIC_FIND_LAST_BIT=y CONFIG_CRC_CCITT=m CONFIG_CRC16=y # CONFIG_CRC_T10DIF is not set CONFIG_CRC_ITU_T=m CONFIG_CRC32=y # CONFIG_CRC7 is not set # CONFIG_LIBCRC32C is not set CONFIG_ZLIB_INFLATE=y CONFIG_ZLIB_DEFLATE=y CONFIG_LZO_COMPRESS=y CONFIG_LZO_DECOMPRESS=y CONFIG_DECOMPRESS_GZIP=y CONFIG_DECOMPRESS_BZIP2=y CONFIG_DECOMPRESS_LZMA=y CONFIG_HAS_IOMEM=y CONFIG_HAS_IOPORT=y CONFIG_HAS_DMA=y CONFIG_NLATTR=y ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-26 16:29 ` Henrik Bork Steffensen @ 2012-11-27 14:11 ` Henrik Bork Steffensen 2012-11-27 16:31 ` Wolfgang Grandegger 0 siblings, 1 reply; 17+ messages in thread From: Henrik Bork Steffensen @ 2012-11-27 14:11 UTC (permalink / raw) To: Wolfgang Grandegger, linux-can On 11/26/2012 05:29 PM, Henrik Bork Steffensen wrote: > On 11/26/2012 04:25 PM, Wolfgang Grandegger wrote: >> On 11/26/2012 03:28 PM, Henrik Bork Steffensen wrote: >>> In our case the lockup occurs approximately 1 time in 50 days. >> :( > Luckily we have 50 systems for in-house testing. > > >> >>> I am considering protecting tx objects as Wolfgang suggests in the >>> pch_can thread. >> This problem is with SMP in the first place. Can you show your .config. > I attached my .config. >> The c_can driver uses similar code than the at91_can and they have >> therefore the same issues if the kernel is preemptable, IIUC. Should not >> be a big deal to adapt the following patch: >> >> http://marc.info/?l=linux-can&m=135391821814519&w=2 > I was not aware of the relationship to c_can. > > I agree, it should be very easy to implement that patch. > I implemented this patch on our at91_can.c, and it was rather simple to find the spots. But the compiled kernel gives me this during boot: [ 86.750000] ------------[ cut here ]------------ [ 86.750000] WARNING: at kernel/softirq.c:143 local_bh_enable+0x4c/0xc8() [ 86.750000] Modules linked in: reset_state ad_converter_mcp3002 ohci_hcd ads7846 atmel_lcdfb cfbcopyarea cfbimgblt cfbfillrect pwm ext3 ipv6 jbd mmc_block at91_mci can_raw can at91_can can_dev led at91sam9_wdt rtc_at91sam9 [ 86.750000] [<c0030bb4>] (unwind_backtrace+0x0/0xd0) from [<c02c084c>] (dump_stack+0x18/0x1c) [ 86.750000] [<c02c084c>] (dump_stack+0x18/0x1c) from [<c0048f3c>] (warn_slowpath_common+0x50/0x68) [ 86.750000] [<c0048f3c>] (warn_slowpath_common+0x50/0x68) from [<c0048f6c>] (warn_slowpath_null+0x18/0x1c) [ 86.750000] [<c0048f6c>] (warn_slowpath_null+0x18/0x1c) from [<c004f620>] (local_bh_enable+0x4c/0xc8) [ 86.750000] [<c004f620>] (local_bh_enable+0x4c/0xc8) from [<c02512e8>] (sk_filter+0x84/0x8c) [ 86.750000] [<c02512e8>] (sk_filter+0x84/0x8c) from [<c0236f7c>] (sock_queue_rcv_skb+0x34/0x110) [ 86.750000] [<c0236f7c>] (sock_queue_rcv_skb+0x34/0x110) from [<bf02e25c>] (raw_rcv+0x64/0x78 [can_raw]) [ 86.750000] [<bf02e25c>] (raw_rcv+0x64/0x78 [can_raw]) from [<bf0220e4>] (can_rcv_filter+0xa8/0x218 [can]) [ 86.750000] [<bf0220e4>] (can_rcv_filter+0xa8/0x218 [can]) from [<bf022334>] (can_rcv+0xc8/0x148 [can]) [ 86.750000] [<bf022334>] (can_rcv+0xc8/0x148 [can]) from [<c0241b34>] (netif_receive_skb+0x2a0/0x2fc) [ 86.750000] [<c0241b34>] (netif_receive_skb+0x2a0/0x2fc) from [<bf01ac18>] (at91_poll+0x15c/0x380 [at91_can]) [ 86.750000] [<bf01ac18>] (at91_poll+0x15c/0x380 [at91_can]) from [<c0242fac>] (net_rx_action+0x7c/0x204) [ 86.750000] [<c0242fac>] (net_rx_action+0x7c/0x204) from [<c004f3a4>] (__do_softirq+0xf8/0x200) [ 86.750000] [<c004f3a4>] (__do_softirq+0xf8/0x200) from [<c004f8b0>] (irq_exit+0x50/0xac) [ 86.750000] [<c004f8b0>] (irq_exit+0x50/0xac) from [<c002a07c>] (asm_do_IRQ+0x7c/0x94) [ 86.750000] [<c002a07c>] (asm_do_IRQ+0x7c/0x94) from [<c002a9e8>] (__irq_svc+0x48/0x8c) [ 86.750000] Exception stack(0xc03d3f40 to 0xc03d3f88) [ 86.750000] 3f40: 00000000 0005317f 0005217f 60000013 c03d2000 c03d63c8 c03fcf44 c03d63c0 [ 86.750000] 3f60: 200241fc 41069265 200241c8 c03d3f94 600000d3 c03d3f88 c002be64 c002be70 [ 86.750000] 3f80: 60000013 ffffffff [ 86.750000] [<c002a9e8>] (__irq_svc+0x48/0x8c) from [<c002be70>] (default_idle+0x34/0x38) [ 86.750000] [<c002be70>] (default_idle+0x34/0x38) from [<c002bff0>] (cpu_idle+0x68/0xc0) [ 86.750000] [<c002bff0>] (cpu_idle+0x68/0xc0) from [<c02bed80>] (rest_init+0x70/0x84) [ 86.750000] [<c02bed80>] (rest_init+0x70/0x84) from [<c0008ab8>] (start_kernel+0x268/0x2c0) [ 86.750000] [<c0008ab8>] (start_kernel+0x268/0x2c0) from [<20008034>] (0x20008034) [ 86.750000] ---[ end trace 1dd02412fce3b434 ]--- I this case "at91_poll" is basicly the same as "c_can_poll", in both cases they call the function with the spinlock in the rx chain. Looking at the patch Wolfgang sugested, I became uncertain of what this patch actually wants to protect. Is it the registers in the cpu can interface? (mailboxes and control regs, i don't know the hw) Or is it the potential race between "c_can_start_xmit" and "c_can_do_tx" ? Or even the access to the net api? Would someone care to explain? Thanks in advance. Henriik ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-27 14:11 ` Henrik Bork Steffensen @ 2012-11-27 16:31 ` Wolfgang Grandegger 2012-11-28 14:22 ` Henrik Bork Steffensen 2012-11-28 14:56 ` Marc Kleine-Budde 0 siblings, 2 replies; 17+ messages in thread From: Wolfgang Grandegger @ 2012-11-27 16:31 UTC (permalink / raw) To: Henrik Bork Steffensen; +Cc: linux-can On 11/27/2012 03:11 PM, Henrik Bork Steffensen wrote: > On 11/26/2012 05:29 PM, Henrik Bork Steffensen wrote: >> On 11/26/2012 04:25 PM, Wolfgang Grandegger wrote: >>> On 11/26/2012 03:28 PM, Henrik Bork Steffensen wrote: >>>> In our case the lockup occurs approximately 1 time in 50 days. >>> :( >> Luckily we have 50 systems for in-house testing. >> >> >>> >>>> I am considering protecting tx objects as Wolfgang suggests in the >>>> pch_can thread. >>> This problem is with SMP in the first place. Can you show your .config. >> I attached my .config. >>> The c_can driver uses similar code than the at91_can and they have >>> therefore the same issues if the kernel is preemptable, IIUC. Should not >>> be a big deal to adapt the following patch: >>> >>> http://marc.info/?l=linux-can&m=135391821814519&w=2 >> I was not aware of the relationship to c_can. >> >> I agree, it should be very easy to implement that patch. >> > > I implemented this patch on our at91_can.c, and it was rather simple to > find the spots. > But the compiled kernel gives me this during boot: > > [ 86.750000] ------------[ cut here ]------------ > [ 86.750000] WARNING: at kernel/softirq.c:143 local_bh_enable+0x4c/0xc8() > [ 86.750000] Modules linked in: reset_state ad_converter_mcp3002 > ohci_hcd ads7846 atmel_lcdfb cfbcopyarea cfbimgblt cfbfillrect pwm ext3 > ipv6 jbd mmc_block at91_mci can_raw can at91_can can_dev led > at91sam9_wdt rtc_at91sam9 > [ 86.750000] [<c0030bb4>] (unwind_backtrace+0x0/0xd0) from > [<c02c084c>] (dump_stack+0x18/0x1c) > [ 86.750000] [<c02c084c>] (dump_stack+0x18/0x1c) from [<c0048f3c>] > (warn_slowpath_common+0x50/0x68) > [ 86.750000] [<c0048f3c>] (warn_slowpath_common+0x50/0x68) from > [<c0048f6c>] (warn_slowpath_null+0x18/0x1c) > [ 86.750000] [<c0048f6c>] (warn_slowpath_null+0x18/0x1c) from > [<c004f620>] (local_bh_enable+0x4c/0xc8) > [ 86.750000] [<c004f620>] (local_bh_enable+0x4c/0xc8) from > [<c02512e8>] (sk_filter+0x84/0x8c) > [ 86.750000] [<c02512e8>] (sk_filter+0x84/0x8c) from [<c0236f7c>] > (sock_queue_rcv_skb+0x34/0x110) > [ 86.750000] [<c0236f7c>] (sock_queue_rcv_skb+0x34/0x110) from > [<bf02e25c>] (raw_rcv+0x64/0x78 [can_raw]) > [ 86.750000] [<bf02e25c>] (raw_rcv+0x64/0x78 [can_raw]) from > [<bf0220e4>] (can_rcv_filter+0xa8/0x218 [can]) > [ 86.750000] [<bf0220e4>] (can_rcv_filter+0xa8/0x218 [can]) from > [<bf022334>] (can_rcv+0xc8/0x148 [can]) > [ 86.750000] [<bf022334>] (can_rcv+0xc8/0x148 [can]) from [<c0241b34>] > (netif_receive_skb+0x2a0/0x2fc) > [ 86.750000] [<c0241b34>] (netif_receive_skb+0x2a0/0x2fc) from > [<bf01ac18>] (at91_poll+0x15c/0x380 [at91_can]) > [ 86.750000] [<bf01ac18>] (at91_poll+0x15c/0x380 [at91_can]) from > [<c0242fac>] (net_rx_action+0x7c/0x204) > [ 86.750000] [<c0242fac>] (net_rx_action+0x7c/0x204) from [<c004f3a4>] > (__do_softirq+0xf8/0x200) > [ 86.750000] [<c004f3a4>] (__do_softirq+0xf8/0x200) from [<c004f8b0>] > (irq_exit+0x50/0xac) > [ 86.750000] [<c004f8b0>] (irq_exit+0x50/0xac) from [<c002a07c>] > (asm_do_IRQ+0x7c/0x94) > [ 86.750000] [<c002a07c>] (asm_do_IRQ+0x7c/0x94) from [<c002a9e8>] > (__irq_svc+0x48/0x8c) > [ 86.750000] Exception stack(0xc03d3f40 to 0xc03d3f88) > [ 86.750000] 3f40: 00000000 0005317f 0005217f 60000013 c03d2000 > c03d63c8 c03fcf44 c03d63c0 > [ 86.750000] 3f60: 200241fc 41069265 200241c8 c03d3f94 600000d3 > c03d3f88 c002be64 c002be70 > [ 86.750000] 3f80: 60000013 ffffffff > [ 86.750000] [<c002a9e8>] (__irq_svc+0x48/0x8c) from [<c002be70>] > (default_idle+0x34/0x38) > [ 86.750000] [<c002be70>] (default_idle+0x34/0x38) from [<c002bff0>] > (cpu_idle+0x68/0xc0) > [ 86.750000] [<c002bff0>] (cpu_idle+0x68/0xc0) from [<c02bed80>] > (rest_init+0x70/0x84) > [ 86.750000] [<c02bed80>] (rest_init+0x70/0x84) from [<c0008ab8>] > (start_kernel+0x268/0x2c0) > [ 86.750000] [<c0008ab8>] (start_kernel+0x268/0x2c0) from [<20008034>] > (0x20008034) > [ 86.750000] ---[ end trace 1dd02412fce3b434 ]--- Hm, could you show your diffs. > I this case "at91_poll" is basicly the same as "c_can_poll", in both > cases they call the function with the spinlock in the rx chain. You don't need to protect against RX. Sorry, forgot that. On the c_can this is necessary due to concurrent accesses to the same message RAM. > Looking at the patch Wolfgang sugested, I became uncertain of what this > patch actually wants to protect. > Is it the registers in the cpu can interface? (mailboxes and control > regs, i don't know the hw) As mentioned above, on the c_can there is definitely a race with the message ram due to the busy wait after accessing it. See: http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 > Or is it the potential race between "c_can_start_xmit" and "c_can_do_tx" ? > Or even the access to the net api? > > Would someone care to explain? I will try. In at91_start_xmit, if we get interrupted if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv))) & AT91_MSR_MRDY) || (priv->tx_next & get_next_mask(priv)) == 0) /* HERE */ netif_stop_queue(dev); and then at91_irq_tx() is called executing netif_wake_queue() we may end up with a stopped tx queue. But I'm not yet 100% sure. Wolfgang. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-27 16:31 ` Wolfgang Grandegger @ 2012-11-28 14:22 ` Henrik Bork Steffensen 2012-11-28 14:29 ` Marc Kleine-Budde 2012-11-28 14:38 ` Wolfgang Grandegger 2012-11-28 14:56 ` Marc Kleine-Budde 1 sibling, 2 replies; 17+ messages in thread From: Henrik Bork Steffensen @ 2012-11-28 14:22 UTC (permalink / raw) To: linux-can On 11/27/2012 05:31 PM, Wolfgang Grandegger wrote: > On 11/27/2012 03:11 PM, Henrik Bork Steffensen wrote: > Hm, could you show your diffs. Do You mean a diff on these 7 lines, or a diff to the original file? >> I this case "at91_poll" is basicly the same as "c_can_poll", in both >> cases they call the function with the spinlock in the rx chain. > You don't need to protect against RX. Sorry, forgot that. On the c_can > this is necessary due to concurrent accesses to the same message RAM. Ok, I think that at91_can.c might have an issue in register access. I am not sure, but I will look into it. > >> Looking at the patch Wolfgang sugested, I became uncertain of what this >> patch actually wants to protect. >> Is it the registers in the cpu can interface? (mailboxes and control >> regs, i don't know the hw) > As mentioned above, on the c_can there is definitely a race with the > message ram due to the busy wait after accessing it. See: > > http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 > >> Or is it the potential race between "c_can_start_xmit" and "c_can_do_tx" ? >> Or even the access to the net api? >> >> Would someone care to explain? > I will try. In at91_start_xmit, if we get interrupted > > if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv)))& > AT91_MSR_MRDY) || > (priv->tx_next& get_next_mask(priv)) == 0) > > /* HERE */ > > netif_stop_queue(dev); > > and then at91_irq_tx() is called executing netif_wake_queue() we may end > up with a stopped tx queue. But I'm not yet 100% sure. Ok, thanks a lot. In my case i changed the driver to only use one mailbox for transmission. Which means that the "net_stop_queue" will be called every time a packet is tx'ed. And the "net_wake_queue" will be called after the packet is actually transmitted. This is as far as i can see this is 100% safe, provided that no further "ndo_start_xmit" calls come before the wake_queue call. Anyway, after removing the spin_lock from rx, it loads fine and seems to work. I will do a test with the suggested changes to the tx chain and get to the list if anything interesting appears. Thank You very much for Your help so far :-) regards, Henrik ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-28 14:22 ` Henrik Bork Steffensen @ 2012-11-28 14:29 ` Marc Kleine-Budde 2012-11-28 15:09 ` Henrik Bork Steffensen 2012-11-28 14:38 ` Wolfgang Grandegger 1 sibling, 1 reply; 17+ messages in thread From: Marc Kleine-Budde @ 2012-11-28 14:29 UTC (permalink / raw) To: Henrik Bork Steffensen; +Cc: linux-can [-- Attachment #1: Type: text/plain, Size: 2865 bytes --] On 11/28/2012 03:22 PM, Henrik Bork Steffensen wrote: > On 11/27/2012 05:31 PM, Wolfgang Grandegger wrote: >> On 11/27/2012 03:11 PM, Henrik Bork Steffensen wrote: >> Hm, could you show your diffs. > Do You mean a diff on these 7 lines, or a diff to the original file? > >>> I this case "at91_poll" is basicly the same as "c_can_poll", in both >>> cases they call the function with the spinlock in the rx chain. >> You don't need to protect against RX. Sorry, forgot that. On the c_can >> this is necessary due to concurrent accesses to the same message RAM. > Ok, I think that at91_can.c might have an issue in register access. > I am not sure, but I will look into it. > >> >>> Looking at the patch Wolfgang sugested, I became uncertain of what this >>> patch actually wants to protect. >>> Is it the registers in the cpu can interface? (mailboxes and control >>> regs, i don't know the hw) >> As mentioned above, on the c_can there is definitely a race with the >> message ram due to the busy wait after accessing it. See: >> >> http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 >> >>> Or is it the potential race between "c_can_start_xmit" and >>> "c_can_do_tx" ? >>> Or even the access to the net api? >>> >>> Would someone care to explain? >> I will try. In at91_start_xmit, if we get interrupted >> >> if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv)))& >> AT91_MSR_MRDY) || >> (priv->tx_next& get_next_mask(priv)) == 0) >> >> /* HERE */ >> >> netif_stop_queue(dev); >> >> and then at91_irq_tx() is called executing netif_wake_queue() we may end >> up with a stopped tx queue. But I'm not yet 100% sure. > Ok, thanks a lot. > > In my case i changed the driver to only use one mailbox for transmission. > Which means that the "net_stop_queue" will be called every time a packet > is tx'ed. > And the "net_wake_queue" will be called after the packet is actually > transmitted. In your first mail you've written that using only one mailbox increases the probability for a lockup. > This is as far as i can see this is 100% safe, provided that no further > "ndo_start_xmit" > calls come before the wake_queue call. > > > Anyway, after removing the spin_lock from rx, it loads fine and seems to > work. > I will do a test with the suggested changes to the tx chain and get to > the list > if anything interesting appears. > > Thank You very much for Your help so far :-) Can you send me a diff of your current changes? regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 261 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-28 14:29 ` Marc Kleine-Budde @ 2012-11-28 15:09 ` Henrik Bork Steffensen 2012-11-28 15:12 ` Marc Kleine-Budde 0 siblings, 1 reply; 17+ messages in thread From: Henrik Bork Steffensen @ 2012-11-28 15:09 UTC (permalink / raw) To: Marc Kleine-Budde; +Cc: linux-can [-- Attachment #1: Type: text/plain, Size: 2948 bytes --] On 11/28/2012 03:29 PM, Marc Kleine-Budde wrote: > On 11/28/2012 03:22 PM, Henrik Bork Steffensen wrote: >> On 11/27/2012 05:31 PM, Wolfgang Grandegger wrote: >>> On 11/27/2012 03:11 PM, Henrik Bork Steffensen wrote: >>> Hm, could you show your diffs. >> Do You mean a diff on these 7 lines, or a diff to the original file? >> >>>> I this case "at91_poll" is basicly the same as "c_can_poll", in both >>>> cases they call the function with the spinlock in the rx chain. >>> You don't need to protect against RX. Sorry, forgot that. On the c_can >>> this is necessary due to concurrent accesses to the same message RAM. >> Ok, I think that at91_can.c might have an issue in register access. >> I am not sure, but I will look into it. >> >>>> Looking at the patch Wolfgang sugested, I became uncertain of what this >>>> patch actually wants to protect. >>>> Is it the registers in the cpu can interface? (mailboxes and control >>>> regs, i don't know the hw) >>> As mentioned above, on the c_can there is definitely a race with the >>> message ram due to the busy wait after accessing it. See: >>> >>> http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 >>> >>>> Or is it the potential race between "c_can_start_xmit" and >>>> "c_can_do_tx" ? >>>> Or even the access to the net api? >>>> >>>> Would someone care to explain? >>> I will try. In at91_start_xmit, if we get interrupted >>> >>> if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv)))& >>> AT91_MSR_MRDY) || >>> (priv->tx_next& get_next_mask(priv)) == 0) >>> >>> /* HERE */ >>> >>> netif_stop_queue(dev); >>> >>> and then at91_irq_tx() is called executing netif_wake_queue() we may end >>> up with a stopped tx queue. But I'm not yet 100% sure. >> Ok, thanks a lot. >> >> In my case i changed the driver to only use one mailbox for transmission. >> Which means that the "net_stop_queue" will be called every time a packet >> is tx'ed. >> And the "net_wake_queue" will be called after the packet is actually >> transmitted. > In your first mail you've written that using only one mailbox increases > the probability for a lockup. > >> This is as far as i can see this is 100% safe, provided that no further >> "ndo_start_xmit" >> calls come before the wake_queue call. >> >> >> Anyway, after removing the spin_lock from rx, it loads fine and seems to >> work. >> I will do a test with the suggested changes to the tx chain and get to >> the list >> if anything interesting appears. >> >> Thank You very much for Your help so far :-) > Can you send me a diff of your current changes? Hi, Please note that i have not yet tested it for lockup. So far i just did a simple rx/tx test. Patch attached. Expect large offsets in line numbers. I have a few other small changes to at91_can.c which might be interesting. I will get back with them, after checking them against a recent kernel version. regards, Henrik [-- Attachment #2: at91_can.c.tx_race_protection.patch --] [-- Type: text/x-patch, Size: 2217 bytes --] --- drivers/net/can/at91_can.c_org 2012-11-27 09:24:01.410683785 +0100 +++ drivers/net/can/at91_can.c 2012-11-28 15:44:45.786660609 +0100 @@ -149,6 +149,7 @@ struct at91_priv { struct clk *clk; struct at91_can_data *pdata; canid_t mb0_id; + spinlock_t lock; /* to protect against race beetween "netif_stop_queue" and "netif_wake_queue" */ }; static struct can_bittiming_const at91_bittiming_const = { @@ -340,9 +341,11 @@ static netdev_tx_t at91_start_xmit(struc struct net_device_stats *stats = &dev->stats; struct can_frame *cf = (struct can_frame *)skb->data; u32 reg_mid, reg_mcr, reg_msr; + unsigned long flags; if (can_dropped_invalid_skb(dev, skb)) return NETDEV_TX_OK; + spin_lock_irqsave(&priv->lock, flags); /* We nee to read MSR only once - because reading it clear MMI bits */ reg_msr=at91_read(priv, AT91_MSR(AT91_MB_TX_SINGLE_MB_NUM)); @@ -350,6 +353,7 @@ static netdev_tx_t at91_start_xmit(struc if (unlikely(!(reg_msr & AT91_MSR_MRDY))) { netif_stop_queue(dev); dev_err(dev->dev.parent, "TX buffer full when queue awake!\n"); + spin_unlock_irqrestore(&priv->lock, flags); return NETDEV_TX_BUSY; } reg_mid = at91_can_id_to_reg_mid(cf->can_id); @@ -377,6 +381,7 @@ static netdev_tx_t at91_start_xmit(struc /* Enable interrupt for this mailbox */ at91_write(priv, AT91_IER, 1 << AT91_MB_TX_SINGLE_MB_NUM); + spin_unlock_irqrestore(&priv->lock, flags); return NETDEV_TX_OK; } @@ -621,7 +626,9 @@ static void at91_irq_tx(struct net_devic struct at91_priv *priv = netdev_priv(dev); u32 reg_msr; unsigned int mb; + unsigned long flags; + spin_lock_irqsave(&priv->lock, flags); /* masking of reg_sr not needed, already done by at91_irq */ mb=AT91_MB_TX_SINGLE_MB_NUM; /* event in mailbox? */ @@ -647,6 +654,8 @@ static void at91_irq_tx(struct net_devic /* Restart que */ netif_wake_queue(dev); + + spin_unlock_irqrestore(&priv->lock, flags); } static void at91_irq_err_state(struct net_device *dev, @@ -1050,7 +1059,7 @@ static int __init at91_can_probe(struct dev_info(&pdev->dev, "device registered (reg_base=%p, irq=%d)\n", priv->reg_base, dev->irq); - + spin_lock_init(&priv->lock); return 0; exit_free: ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-28 15:09 ` Henrik Bork Steffensen @ 2012-11-28 15:12 ` Marc Kleine-Budde 2012-11-28 15:44 ` Henrik Bork Steffensen 0 siblings, 1 reply; 17+ messages in thread From: Marc Kleine-Budde @ 2012-11-28 15:12 UTC (permalink / raw) To: Henrik Bork Steffensen; +Cc: linux-can [-- Attachment #1: Type: text/plain, Size: 3588 bytes --] On 11/28/2012 04:09 PM, Henrik Bork Steffensen wrote: > On 11/28/2012 03:29 PM, Marc Kleine-Budde wrote: >> On 11/28/2012 03:22 PM, Henrik Bork Steffensen wrote: >>> On 11/27/2012 05:31 PM, Wolfgang Grandegger wrote: >>>> On 11/27/2012 03:11 PM, Henrik Bork Steffensen wrote: >>>> Hm, could you show your diffs. >>> Do You mean a diff on these 7 lines, or a diff to the original file? >>> >>>>> I this case "at91_poll" is basicly the same as "c_can_poll", in both >>>>> cases they call the function with the spinlock in the rx chain. >>>> You don't need to protect against RX. Sorry, forgot that. On the c_can >>>> this is necessary due to concurrent accesses to the same message RAM. >>> Ok, I think that at91_can.c might have an issue in register access. >>> I am not sure, but I will look into it. >>> >>>>> Looking at the patch Wolfgang sugested, I became uncertain of what >>>>> this >>>>> patch actually wants to protect. >>>>> Is it the registers in the cpu can interface? (mailboxes and control >>>>> regs, i don't know the hw) >>>> As mentioned above, on the c_can there is definitely a race with the >>>> message ram due to the busy wait after accessing it. See: >>>> >>>> >>>> http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 >>>> >>>>> Or is it the potential race between "c_can_start_xmit" and >>>>> "c_can_do_tx" ? >>>>> Or even the access to the net api? >>>>> >>>>> Would someone care to explain? >>>> I will try. In at91_start_xmit, if we get interrupted >>>> >>>> if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv)))& >>>> AT91_MSR_MRDY) || >>>> (priv->tx_next& get_next_mask(priv)) == 0) >>>> >>>> /* HERE */ >>>> >>>> netif_stop_queue(dev); >>>> >>>> and then at91_irq_tx() is called executing netif_wake_queue() we may >>>> end >>>> up with a stopped tx queue. But I'm not yet 100% sure. >>> Ok, thanks a lot. >>> >>> In my case i changed the driver to only use one mailbox for >>> transmission. >>> Which means that the "net_stop_queue" will be called every time a packet >>> is tx'ed. >>> And the "net_wake_queue" will be called after the packet is actually >>> transmitted. >> In your first mail you've written that using only one mailbox increases >> the probability for a lockup. >> >>> This is as far as i can see this is 100% safe, provided that no further >>> "ndo_start_xmit" >>> calls come before the wake_queue call. >>> >>> >>> Anyway, after removing the spin_lock from rx, it loads fine and seems to >>> work. >>> I will do a test with the suggested changes to the tx chain and get to >>> the list >>> if anything interesting appears. >>> >>> Thank You very much for Your help so far :-) >> Can you send me a diff of your current changes? > > Hi, > > Please note that i have not yet tested it for lockup. > So far i just did a simple rx/tx test. How many TX mailboxes are you using? According to your patch, the number is unchanged. > Patch attached. > Expect large offsets in line numbers. > > I have a few other small changes to at91_can.c which might be interesting. > I will get back with them, after checking them against a recent kernel > version. Cool, I'm looking forward to see them. tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 261 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-28 15:12 ` Marc Kleine-Budde @ 2012-11-28 15:44 ` Henrik Bork Steffensen 2012-11-28 16:23 ` Wolfgang Grandegger 0 siblings, 1 reply; 17+ messages in thread From: Henrik Bork Steffensen @ 2012-11-28 15:44 UTC (permalink / raw) To: Marc Kleine-Budde; +Cc: linux-can On 11/28/2012 04:12 PM, Marc Kleine-Budde wrote: > On 11/28/2012 04:09 PM, Henrik Bork Steffensen wrote: >> On 11/28/2012 03:29 PM, Marc Kleine-Budde wrote: >>> On 11/28/2012 03:22 PM, Henrik Bork Steffensen wrote: >>>> On 11/27/2012 05:31 PM, Wolfgang Grandegger wrote: >>>>> On 11/27/2012 03:11 PM, Henrik Bork Steffensen wrote: >>>>> Hm, could you show your diffs. >>>> Do You mean a diff on these 7 lines, or a diff to the original file? >>>> >>>>>> I this case "at91_poll" is basicly the same as "c_can_poll", in both >>>>>> cases they call the function with the spinlock in the rx chain. >>>>> You don't need to protect against RX. Sorry, forgot that. On the c_can >>>>> this is necessary due to concurrent accesses to the same message RAM. >>>> Ok, I think that at91_can.c might have an issue in register access. >>>> I am not sure, but I will look into it. >>>> >>>>>> Looking at the patch Wolfgang sugested, I became uncertain of what >>>>>> this >>>>>> patch actually wants to protect. >>>>>> Is it the registers in the cpu can interface? (mailboxes and control >>>>>> regs, i don't know the hw) >>>>> As mentioned above, on the c_can there is definitely a race with the >>>>> message ram due to the busy wait after accessing it. See: >>>>> >>>>> >>>>> http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 >>>>> >>>>>> Or is it the potential race between "c_can_start_xmit" and >>>>>> "c_can_do_tx" ? >>>>>> Or even the access to the net api? >>>>>> >>>>>> Would someone care to explain? >>>>> I will try. In at91_start_xmit, if we get interrupted >>>>> >>>>> if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv)))& >>>>> AT91_MSR_MRDY) || >>>>> (priv->tx_next& get_next_mask(priv)) == 0) >>>>> >>>>> /* HERE */ >>>>> >>>>> netif_stop_queue(dev); >>>>> >>>>> and then at91_irq_tx() is called executing netif_wake_queue() we may >>>>> end >>>>> up with a stopped tx queue. But I'm not yet 100% sure. >>>> Ok, thanks a lot. >>>> >>>> In my case i changed the driver to only use one mailbox for >>>> transmission. >>>> Which means that the "net_stop_queue" will be called every time a packet >>>> is tx'ed. >>>> And the "net_wake_queue" will be called after the packet is actually >>>> transmitted. >>> In your first mail you've written that using only one mailbox increases >>> the probability for a lockup. >>> >>>> This is as far as i can see this is 100% safe, provided that no further >>>> "ndo_start_xmit" >>>> calls come before the wake_queue call. >>>> >>>> >>>> Anyway, after removing the spin_lock from rx, it loads fine and seems to >>>> work. >>>> I will do a test with the suggested changes to the tx chain and get to >>>> the list >>>> if anything interesting appears. >>>> >>>> Thank You very much for Your help so far :-) >>> Can you send me a diff of your current changes? >> Hi, >> >> Please note that i have not yet tested it for lockup. >> So far i just did a simple rx/tx test. > How many TX mailboxes are you using? According to your patch, the number > is unchanged. This patch only contains this tx spin_lock - the rest of the driver contains changes too. e.g: "at91_write(priv, AT91_IER, 1 << AT91_MB_TX_SINGLE_MB_NUM);" Only using one mailbox for TX was part of an divide-and-conquer process, but also because the data sheet errata suggested it for low bw applications. Henrik ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-28 15:44 ` Henrik Bork Steffensen @ 2012-11-28 16:23 ` Wolfgang Grandegger 2012-12-03 16:13 ` Henrik Bork Steffensen 0 siblings, 1 reply; 17+ messages in thread From: Wolfgang Grandegger @ 2012-11-28 16:23 UTC (permalink / raw) To: Henrik Bork Steffensen; +Cc: Marc Kleine-Budde, linux-can On 11/28/2012 04:44 PM, Henrik Bork Steffensen wrote: > On 11/28/2012 04:12 PM, Marc Kleine-Budde wrote: >> On 11/28/2012 04:09 PM, Henrik Bork Steffensen wrote: >>> On 11/28/2012 03:29 PM, Marc Kleine-Budde wrote: >>>> On 11/28/2012 03:22 PM, Henrik Bork Steffensen wrote: >>>>> On 11/27/2012 05:31 PM, Wolfgang Grandegger wrote: >>>>>> On 11/27/2012 03:11 PM, Henrik Bork Steffensen wrote: >>>>>> Hm, could you show your diffs. >>>>> Do You mean a diff on these 7 lines, or a diff to the original file? >>>>> >>>>>>> I this case "at91_poll" is basicly the same as "c_can_poll", in both >>>>>>> cases they call the function with the spinlock in the rx chain. >>>>>> You don't need to protect against RX. Sorry, forgot that. On the >>>>>> c_can >>>>>> this is necessary due to concurrent accesses to the same message RAM. >>>>> Ok, I think that at91_can.c might have an issue in register access. >>>>> I am not sure, but I will look into it. >>>>> >>>>>>> Looking at the patch Wolfgang sugested, I became uncertain of what >>>>>>> this >>>>>>> patch actually wants to protect. >>>>>>> Is it the registers in the cpu can interface? (mailboxes and control >>>>>>> regs, i don't know the hw) >>>>>> As mentioned above, on the c_can there is definitely a race with the >>>>>> message ram due to the busy wait after accessing it. See: >>>>>> >>>>>> >>>>>> http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 >>>>>> >>>>>>> Or is it the potential race between "c_can_start_xmit" and >>>>>>> "c_can_do_tx" ? >>>>>>> Or even the access to the net api? >>>>>>> >>>>>>> Would someone care to explain? >>>>>> I will try. In at91_start_xmit, if we get interrupted >>>>>> >>>>>> if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv)))& >>>>>> AT91_MSR_MRDY) || >>>>>> (priv->tx_next& get_next_mask(priv)) == 0) >>>>>> >>>>>> /* HERE */ >>>>>> >>>>>> netif_stop_queue(dev); >>>>>> >>>>>> and then at91_irq_tx() is called executing netif_wake_queue() we may >>>>>> end >>>>>> up with a stopped tx queue. But I'm not yet 100% sure. >>>>> Ok, thanks a lot. >>>>> >>>>> In my case i changed the driver to only use one mailbox for >>>>> transmission. >>>>> Which means that the "net_stop_queue" will be called every time a >>>>> packet >>>>> is tx'ed. >>>>> And the "net_wake_queue" will be called after the packet is actually >>>>> transmitted. >>>> In your first mail you've written that using only one mailbox increases >>>> the probability for a lockup. >>>> >>>>> This is as far as i can see this is 100% safe, provided that no >>>>> further >>>>> "ndo_start_xmit" >>>>> calls come before the wake_queue call. >>>>> >>>>> >>>>> Anyway, after removing the spin_lock from rx, it loads fine and >>>>> seems to >>>>> work. >>>>> I will do a test with the suggested changes to the tx chain and get to >>>>> the list >>>>> if anything interesting appears. >>>>> >>>>> Thank You very much for Your help so far :-) >>>> Can you send me a diff of your current changes? >>> Hi, >>> >>> Please note that i have not yet tested it for lockup. >>> So far i just did a simple rx/tx test. >> How many TX mailboxes are you using? According to your patch, the number >> is unchanged. > This patch only contains this tx spin_lock - the rest of the driver > contains changes too. > > e.g: "at91_write(priv, AT91_IER, 1 << AT91_MB_TX_SINGLE_MB_NUM);" > Only using one mailbox for TX was part of an divide-and-conquer process, > but also because the data sheet errata suggested it for low bw > applications. Don't change two (or more) things at a time. Otherwise you don't know what really helped. Just my 0.01 EUR Wolfgang. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-28 16:23 ` Wolfgang Grandegger @ 2012-12-03 16:13 ` Henrik Bork Steffensen 0 siblings, 0 replies; 17+ messages in thread From: Henrik Bork Steffensen @ 2012-12-03 16:13 UTC (permalink / raw) To: Wolfgang Grandegger; +Cc: Marc Kleine-Budde, linux-can On 11/28/2012 05:23 PM, Wolfgang Grandegger wrote: > On 11/28/2012 04:44 PM, Henrik Bork Steffensen wrote: >> >> This patch only contains this tx spin_lock - the rest of the driver >> contains changes too. >> >> e.g: "at91_write(priv, AT91_IER, 1<< AT91_MB_TX_SINGLE_MB_NUM);" >> Only using one mailbox for TX was part of an divide-and-conquer process, >> but also because the data sheet errata suggested it for low bw >> applications. > Don't change two (or more) things at a time. Otherwise you don't know > what really helped. > > Just my 0.01 EUR > > Wolfgang. > > Hi I completly agree, and only one thing is changed. The other changes are older. BTW testing of the patch is postponed because the test equipment is in use for another test. I hope that we will get test time by the end of this week. regards, Henrik ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-28 14:22 ` Henrik Bork Steffensen 2012-11-28 14:29 ` Marc Kleine-Budde @ 2012-11-28 14:38 ` Wolfgang Grandegger 2012-11-28 15:17 ` Henrik Bork Steffensen 1 sibling, 1 reply; 17+ messages in thread From: Wolfgang Grandegger @ 2012-11-28 14:38 UTC (permalink / raw) To: Henrik Bork Steffensen; +Cc: linux-can On 11/28/2012 03:22 PM, Henrik Bork Steffensen wrote: > On 11/27/2012 05:31 PM, Wolfgang Grandegger wrote: >> On 11/27/2012 03:11 PM, Henrik Bork Steffensen wrote: >> Hm, could you show your diffs. > Do You mean a diff on these 7 lines, or a diff to the original file? > >>> I this case "at91_poll" is basicly the same as "c_can_poll", in both >>> cases they call the function with the spinlock in the rx chain. >> You don't need to protect against RX. Sorry, forgot that. On the c_can >> this is necessary due to concurrent accesses to the same message RAM. > Ok, I think that at91_can.c might have an issue in register access. > I am not sure, but I will look into it. > >> >>> Looking at the patch Wolfgang sugested, I became uncertain of what this >>> patch actually wants to protect. >>> Is it the registers in the cpu can interface? (mailboxes and control >>> regs, i don't know the hw) >> As mentioned above, on the c_can there is definitely a race with the >> message ram due to the busy wait after accessing it. See: >> >> http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 >> >>> Or is it the potential race between "c_can_start_xmit" and >>> "c_can_do_tx" ? >>> Or even the access to the net api? >>> >>> Would someone care to explain? >> I will try. In at91_start_xmit, if we get interrupted >> >> if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv)))& >> AT91_MSR_MRDY) || >> (priv->tx_next& get_next_mask(priv)) == 0) >> >> /* HERE */ >> >> netif_stop_queue(dev); >> >> and then at91_irq_tx() is called executing netif_wake_queue() we may end >> up with a stopped tx queue. But I'm not yet 100% sure. > Ok, thanks a lot. > > In my case i changed the driver to only use one mailbox for transmission. > Which means that the "net_stop_queue" will be called every time a packet > is tx'ed. > And the "net_wake_queue" will be called after the packet is actually > transmitted. > > This is as far as i can see this is 100% safe, provided that no further > "ndo_start_xmit" > calls come before the wake_queue call. Yes, then the race should be gone. Anyway, we don't want that solution. > Anyway, after removing the spin_lock from rx, it loads fine and seems to > work. It would help use to know if a spin-lock protecting the whole at91_start_xmit() and at91_start_xmit() functions does *really* fix your "tx-does-not-work-any-more" problem. Then we are rather sure that there is a race. > I will do a test with the suggested changes to the tx chain and get to > the list > if anything interesting appears. Not sure what changes you have in mind? > Thank You very much for Your help so far :-) You are welcome. Wolfgang. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-28 14:38 ` Wolfgang Grandegger @ 2012-11-28 15:17 ` Henrik Bork Steffensen 0 siblings, 0 replies; 17+ messages in thread From: Henrik Bork Steffensen @ 2012-11-28 15:17 UTC (permalink / raw) To: Wolfgang Grandegger; +Cc: linux-can On 11/28/2012 03:38 PM, Wolfgang Grandegger wrote: > On 11/28/2012 03:22 PM, Henrik Bork Steffensen wrote: >> On 11/27/2012 05:31 PM, Wolfgang Grandegger wrote: >>> On 11/27/2012 03:11 PM, Henrik Bork Steffensen wrote: >>> Hm, could you show your diffs. >> Do You mean a diff on these 7 lines, or a diff to the original file? >> >>>> I this case "at91_poll" is basicly the same as "c_can_poll", in both >>>> cases they call the function with the spinlock in the rx chain. >>> You don't need to protect against RX. Sorry, forgot that. On the c_can >>> this is necessary due to concurrent accesses to the same message RAM. >> Ok, I think that at91_can.c might have an issue in register access. >> I am not sure, but I will look into it. >> >>>> Looking at the patch Wolfgang sugested, I became uncertain of what this >>>> patch actually wants to protect. >>>> Is it the registers in the cpu can interface? (mailboxes and control >>>> regs, i don't know the hw) >>> As mentioned above, on the c_can there is definitely a race with the >>> message ram due to the busy wait after accessing it. See: >>> >>> http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 >>> >>>> Or is it the potential race between "c_can_start_xmit" and >>>> "c_can_do_tx" ? >>>> Or even the access to the net api? >>>> >>>> Would someone care to explain? >>> I will try. In at91_start_xmit, if we get interrupted >>> >>> if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv)))& >>> AT91_MSR_MRDY) || >>> (priv->tx_next& get_next_mask(priv)) == 0) >>> >>> /* HERE */ >>> >>> netif_stop_queue(dev); >>> >>> and then at91_irq_tx() is called executing netif_wake_queue() we may end >>> up with a stopped tx queue. But I'm not yet 100% sure. >> Ok, thanks a lot. >> >> In my case i changed the driver to only use one mailbox for transmission. >> Which means that the "net_stop_queue" will be called every time a packet >> is tx'ed. >> And the "net_wake_queue" will be called after the packet is actually >> transmitted. >> >> This is as far as i can see this is 100% safe, provided that no further >> "ndo_start_xmit" >> calls come before the wake_queue call. > Yes, then the race should be gone. Anyway, we don't want that solution. We will probably move back to a number of TX mailboxes after resolving the lockup. >> Anyway, after removing the spin_lock from rx, it loads fine and seems to >> work. > It would help use to know if a spin-lock protecting the whole > at91_start_xmit() and at91_start_xmit() functions does *really* fix your > "tx-does-not-work-any-more" problem. Then we are rather sure that there > is a race. I will get back with a status. I think we need at week for the test. > >> I will do a test with the suggested changes to the tx chain and get to >> the list >> if anything interesting appears. > Not sure what changes you have in mind? Just the ones You suggested :-) Anyway, I attached this small patch to my reply to Marc a few minutes ago. Best regards, Henrik ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-27 16:31 ` Wolfgang Grandegger 2012-11-28 14:22 ` Henrik Bork Steffensen @ 2012-11-28 14:56 ` Marc Kleine-Budde 2012-11-28 15:17 ` Wolfgang Grandegger 1 sibling, 1 reply; 17+ messages in thread From: Marc Kleine-Budde @ 2012-11-28 14:56 UTC (permalink / raw) To: Wolfgang Grandegger; +Cc: Henrik Bork Steffensen, linux-can [-- Attachment #1: Type: text/plain, Size: 1817 bytes --] On 11/27/2012 05:31 PM, Wolfgang Grandegger wrote: [...] > As mentioned above, on the c_can there is definitely a race with the > message ram due to the busy wait after accessing it. See: > > http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 > >> Or is it the potential race between "c_can_start_xmit" and "c_can_do_tx" ? >> Or even the access to the net api? >> >> Would someone care to explain? > > I will try. In at91_start_xmit, if we get interrupted > > if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv))) & > AT91_MSR_MRDY) || > (priv->tx_next & get_next_mask(priv)) == 0) > > /* HERE */ > > netif_stop_queue(dev); > > and then at91_irq_tx() is called executing netif_wake_queue() we may end > up with a stopped tx queue. But I'm not yet 100% sure. I don't think so, because after this follows[1] /* Enable interrupt for this mailbox */ at91_write(priv, AT91_IER, 1 << mb); [1] http://lxr.free-electrons.com/source/drivers/net/can/at91_can.c#L524 So first the queued ist stopped, then the interrupt activated. Then in the interrupt handler[2], [3]: reg_sr = at91_read(priv, AT91_SR); reg_imr = at91_read(priv, AT91_IMR); reg_sr &= reg_imr; ... if (reg_sr & AT91_IRQ_MB_TX) at91_irq_tx(dev, reg_sr); [2] http://lxr.free-electrons.com/source/drivers/net/can/at91_can.c#L1081 [3] http://lxr.free-electrons.com/source/drivers/net/can/at91_can.c#L1104 The at91_irq_tx() function works on the reg_sr. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 261 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-28 14:56 ` Marc Kleine-Budde @ 2012-11-28 15:17 ` Wolfgang Grandegger 0 siblings, 0 replies; 17+ messages in thread From: Wolfgang Grandegger @ 2012-11-28 15:17 UTC (permalink / raw) To: Marc Kleine-Budde; +Cc: Henrik Bork Steffensen, linux-can On 11/28/2012 03:56 PM, Marc Kleine-Budde wrote: > On 11/27/2012 05:31 PM, Wolfgang Grandegger wrote: > [...] > >> As mentioned above, on the c_can there is definitely a race with the >> message ram due to the busy wait after accessing it. See: >> >> http://lxr.linux.no/#linux+v3.6.8/drivers/net/can/c_can/c_can.c#L237 >> >>> Or is it the potential race between "c_can_start_xmit" and "c_can_do_tx" ? >>> Or even the access to the net api? >>> >>> Would someone care to explain? >> >> I will try. In at91_start_xmit, if we get interrupted >> >> if (!(at91_read(priv, AT91_MSR(get_tx_next_mb(priv))) & >> AT91_MSR_MRDY) || >> (priv->tx_next & get_next_mask(priv)) == 0) >> >> /* HERE */ >> >> netif_stop_queue(dev); >> >> and then at91_irq_tx() is called executing netif_wake_queue() we may end >> up with a stopped tx queue. But I'm not yet 100% sure. > > I don't think so, because after this follows[1] > > /* Enable interrupt for this mailbox */ > at91_write(priv, AT91_IER, 1 << mb); > > [1] http://lxr.free-electrons.com/source/drivers/net/can/at91_can.c#L524 > > So first the queued ist stopped, then the interrupt activated. OK, if not the interrupt of another mailbox does occur before the queue gets stopped. May that happen? Wolfgang. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: at91_can.c: Data transmission stops 2012-11-26 15:25 ` Wolfgang Grandegger 2012-11-26 16:29 ` Henrik Bork Steffensen @ 2012-11-26 16:36 ` Marc Kleine-Budde 1 sibling, 0 replies; 17+ messages in thread From: Marc Kleine-Budde @ 2012-11-26 16:36 UTC (permalink / raw) To: Wolfgang Grandegger; +Cc: Henrik Bork Steffensen, linux-can [-- Attachment #1: Type: text/plain, Size: 887 bytes --] On 11/26/2012 04:25 PM, Wolfgang Grandegger wrote: >> I am considering protecting tx objects as Wolfgang suggests in the >> pch_can thread. > > This problem is with SMP in the first place. Can you show your .config. > The c_can driver uses similar code than the at91_can and they have > therefore the same issues if the kernel is preemptable, IIUC. Should not > be a big deal to adapt the following patch: From my point of view, it should be possible to implement that algorithm lock-free, as there is only one writer and one reader of the two variables. I'll have a look at it tomorrow. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 261 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2012-12-03 16:13 UTC | newest] Thread overview: 17+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-11-26 14:28 at91_can.c: Data transmission stops Henrik Bork Steffensen 2012-11-26 15:25 ` Wolfgang Grandegger 2012-11-26 16:29 ` Henrik Bork Steffensen 2012-11-27 14:11 ` Henrik Bork Steffensen 2012-11-27 16:31 ` Wolfgang Grandegger 2012-11-28 14:22 ` Henrik Bork Steffensen 2012-11-28 14:29 ` Marc Kleine-Budde 2012-11-28 15:09 ` Henrik Bork Steffensen 2012-11-28 15:12 ` Marc Kleine-Budde 2012-11-28 15:44 ` Henrik Bork Steffensen 2012-11-28 16:23 ` Wolfgang Grandegger 2012-12-03 16:13 ` Henrik Bork Steffensen 2012-11-28 14:38 ` Wolfgang Grandegger 2012-11-28 15:17 ` Henrik Bork Steffensen 2012-11-28 14:56 ` Marc Kleine-Budde 2012-11-28 15:17 ` Wolfgang Grandegger 2012-11-26 16:36 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).