From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH 3/5] can: Kconfig: switch on CAN_RAW by default
Date: Fri, 30 Nov 2012 07:47:29 +0100 [thread overview]
Message-ID: <50B85681.8030502@hartkopp.net> (raw)
In-Reply-To: <1354197491-31205-4-git-send-email-mkl@pengutronix.de>
On 29.11.2012 14:58, Marc Kleine-Budde wrote:
> As CAN_RAW is the basic CAN protocol, switch it on by default.
>
Hello Marc,
you are probably right, that most users will at least need CAN_RAW sockets.
But i asked myself, what the Linux distributions will do once we point out
that a specific protocol is *preferred* to be enabled?
Regards,
Oliver
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> net/can/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/can/Kconfig b/net/can/Kconfig
> index 0435fc4..c017121 100644
> --- a/net/can/Kconfig
> +++ b/net/can/Kconfig
> @@ -20,7 +20,7 @@ if CAN
>
> config CAN_RAW
> tristate "Raw CAN Protocol (raw access with CAN-ID filtering)"
> - default N
> + default y
> ---help---
> The raw CAN protocol option offers access to the CAN bus via
> the BSD socket API. You probably want to use the raw socket in
next prev parent reply other threads:[~2012-11-30 6:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 13:58 [PATCH 0/5] clean up Kconfig + switch on CAN_RAW by default Marc Kleine-Budde
2012-11-29 13:58 ` [PATCH 1/5] can: Kconfig: convert 'depends on CAN' into 'if CAN...endif' block Marc Kleine-Budde
2012-11-29 13:58 ` [PATCH 2/5] can: Kconfig: convert 'depends on CAN_DEV' into 'if CAN_DEV...endif' block Marc Kleine-Budde
2012-11-29 13:58 ` [PATCH 3/5] can: Kconfig: switch on CAN_RAW by default Marc Kleine-Budde
2012-11-30 6:47 ` Oliver Hartkopp [this message]
2012-11-30 8:19 ` Marc Kleine-Budde
2012-11-30 17:02 ` Oliver Hartkopp
2012-12-03 13:39 ` Marc Kleine-Budde
2012-12-03 17:43 ` Oliver Hartkopp
2012-11-29 13:58 ` [PATCH 4/5] can: Kconfig: remove 'default n' from CAN_BCM and CAN_GW Marc Kleine-Budde
2012-11-29 13:58 ` [PATCH 5/5] can: sja1000: correct indention of Kconfig help text Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B85681.8030502@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).