Re: [RFC v2 3/7] c_can: use different sets of interface registers for rx and tx

[Wolfgang Grandegger <wg@grandegger.com>]

On 11/30/2012 09:39 AM, Marc Kleine-Budde wrote:
> On 11/29/2012 03:39 PM, Wolfgang Grandegger wrote:
>> To avoid conflicts between CPU access to the message RAM we now
>> use the first set of interface registers for RX and the second
>> for TX.
>>
>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
>> ---
>>  drivers/net/can/c_can/c_can.c |   37 ++++++++++++++++++++++---------------
>>  1 file changed, 22 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
>> index 3ae356f..27e45e6 100644
>> --- a/drivers/net/can/c_can/c_can.c
>> +++ b/drivers/net/can/c_can/c_can.c
>> @@ -158,6 +158,10 @@
>>  #define C_CAN_NEXT_MSG_OBJ_MASK	(C_CAN_MSG_OBJ_TX_NUM - 1)
>>  #define RECEIVE_OBJECT_BITS	0x0000ffff
>>  
>> +/* message interface used for rx and tx */
>> +#define IFACE_RX		0
>> +#define IFACE_TX		1
> 
> Can you give these defines a common C_CAN_ prefix? And you can make them
> an enum and change the signature of the function you're changing below.

OK, will do with the next version. Want to be sure that the driver works
as expected first.

Wolfgang