From: Henrik Bork Steffensen <hbs@rosetechnology.dk>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Subject: Re: at91_can.c: Data transmission stops
Date: Mon, 03 Dec 2012 17:13:53 +0100 [thread overview]
Message-ID: <50BCCFC1.3030105@rosetechnology.dk> (raw)
In-Reply-To: <50B63A8E.5010802@grandegger.com>
On 11/28/2012 05:23 PM, Wolfgang Grandegger wrote:
> On 11/28/2012 04:44 PM, Henrik Bork Steffensen wrote:
>>
>> This patch only contains this tx spin_lock - the rest of the driver
>> contains changes too.
>>
>> e.g: "at91_write(priv, AT91_IER, 1<< AT91_MB_TX_SINGLE_MB_NUM);"
>> Only using one mailbox for TX was part of an divide-and-conquer process,
>> but also because the data sheet errata suggested it for low bw
>> applications.
> Don't change two (or more) things at a time. Otherwise you don't know
> what really helped.
>
> Just my 0.01 EUR
>
> Wolfgang.
>
>
Hi
I completly agree, and only one thing is changed.
The other changes are older.
BTW testing of the patch is postponed because the test equipment is in
use for another test.
I hope that we will get test time by the end of this week.
regards,
Henrik
next prev parent reply other threads:[~2012-12-03 16:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 14:28 at91_can.c: Data transmission stops Henrik Bork Steffensen
2012-11-26 15:25 ` Wolfgang Grandegger
2012-11-26 16:29 ` Henrik Bork Steffensen
2012-11-27 14:11 ` Henrik Bork Steffensen
2012-11-27 16:31 ` Wolfgang Grandegger
2012-11-28 14:22 ` Henrik Bork Steffensen
2012-11-28 14:29 ` Marc Kleine-Budde
2012-11-28 15:09 ` Henrik Bork Steffensen
2012-11-28 15:12 ` Marc Kleine-Budde
2012-11-28 15:44 ` Henrik Bork Steffensen
2012-11-28 16:23 ` Wolfgang Grandegger
2012-12-03 16:13 ` Henrik Bork Steffensen [this message]
2012-11-28 14:38 ` Wolfgang Grandegger
2012-11-28 15:17 ` Henrik Bork Steffensen
2012-11-28 14:56 ` Marc Kleine-Budde
2012-11-28 15:17 ` Wolfgang Grandegger
2012-11-26 16:36 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BCCFC1.3030105@rosetechnology.dk \
--to=hbs@rosetechnology.dk \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).