From: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
To: Wolfgang Grandegger <wg@grandegger.com>,
Bernd Krumboeck <krumboeck@universalnet.at>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
linux-usb@vger.kernel.org, info@gerhard-bertelsmann.de,
gediminas@8devices.com
Subject: Re: [PATCH v4] usb_8dev: Add support for USB2CAN interface from 8 devices
Date: Wed, 05 Dec 2012 16:49:25 +0100 [thread overview]
Message-ID: <50BF6D05.4070609@volkswagen.de> (raw)
In-Reply-To: <50BF1E58.4090603@grandegger.com>
On 05.12.2012 11:13, Wolfgang Grandegger wrote:
>> + outmsg.command = USB_8DEV_OPEN;
>> + outmsg.opt1 = USB_8DEV_BAUD_MANUAL;
>> + outmsg.data[0] = (bt->prop_seg + bt->phase_seg1);
>
> Minor issue. Brackets not needed.
>
>> + outmsg.data[1] = bt->phase_seg2;
>> + outmsg.data[2] = bt->sjw;
>> +
That's correct from a compilers point of view.
But in this case i would preserve the [0] as it is better to read in
conjunction with the two lines below ( ..[1] ..[2] )
The semantic has to be understood by humans ;-)
Regards,
Oliver
next prev parent reply other threads:[~2012-12-05 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 22:43 [PATCH v4] usb_8dev: Add support for USB2CAN interface from 8 devices Bernd Krumboeck
[not found] ` <50BE7C7E.8080406-Hi41barv6paIERSsAYjmKA@public.gmane.org>
2012-12-04 22:11 ` Marc Kleine-Budde
2012-12-04 22:14 ` Marc Kleine-Budde
2012-12-05 6:28 ` "Bernd Krumböck"
2012-12-05 10:13 ` Wolfgang Grandegger
2012-12-05 15:49 ` Oliver Hartkopp [this message]
[not found] ` <50BF6D05.4070609-l29pVbxQd1IUtdQbppsyvg@public.gmane.org>
2012-12-05 16:00 ` Marc Kleine-Budde
[not found] ` <50BF6F93.9050107-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-12-05 16:31 ` Wolfgang Grandegger
2012-12-05 21:32 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BF6D05.4070609@volkswagen.de \
--to=oliver.hartkopp@volkswagen.de \
--cc=gediminas@8devices.com \
--cc=info@gerhard-bertelsmann.de \
--cc=krumboeck@universalnet.at \
--cc=linux-can@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).