From: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Bernd Krumboeck <krumboeck-Hi41barv6paIERSsAYjmKA@public.gmane.org>
Cc: "linux-can-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-can-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
info-La43T0Mi4bH5xCKuJOYmCvaTkwRoYoCU@public.gmane.org,
gediminas-LljXPT5IorFWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v4] usb_8dev: Add support for USB2CAN interface from 8 devices
Date: Wed, 05 Dec 2012 22:32:25 +0100 [thread overview]
Message-ID: <50BFBD69.40009@pengutronix.de> (raw)
In-Reply-To: <50BE7C7E.8080406-Hi41barv6paIERSsAYjmKA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
On 12/04/2012 11:43 PM, Bernd Krumboeck wrote:
> Add device driver for USB2CAN interface from "8 devices"
> (http://www.8devices.com).
[...]
> +/* Send data to device */
> +static netdev_tx_t usb_8dev_start_xmit(struct sk_buff *skb,
> + struct net_device *netdev)
> +{
> + struct usb_8dev *dev = netdev_priv(netdev);
I just noticed, it's unusual to name you private data pointer "dev", I
suggest to name it priv. Maybe you can rename your private data struct
to: "struct usb_8dev_priv".
> + struct net_device_stats *stats = &netdev->stats;
> + struct can_frame *cf = (struct can_frame *) skb->data;
> + struct usb_8dev_tx_msg *msg;
> + struct urb *urb;
> + struct usb_8dev_tx_urb_context *context = NULL;
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]
prev parent reply other threads:[~2012-12-05 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 22:43 [PATCH v4] usb_8dev: Add support for USB2CAN interface from 8 devices Bernd Krumboeck
[not found] ` <50BE7C7E.8080406-Hi41barv6paIERSsAYjmKA@public.gmane.org>
2012-12-04 22:11 ` Marc Kleine-Budde
2012-12-04 22:14 ` Marc Kleine-Budde
2012-12-05 6:28 ` "Bernd Krumböck"
2012-12-05 10:13 ` Wolfgang Grandegger
2012-12-05 15:49 ` Oliver Hartkopp
[not found] ` <50BF6D05.4070609-l29pVbxQd1IUtdQbppsyvg@public.gmane.org>
2012-12-05 16:00 ` Marc Kleine-Budde
[not found] ` <50BF6F93.9050107-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-12-05 16:31 ` Wolfgang Grandegger
2012-12-05 21:32 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BFBD69.40009@pengutronix.de \
--to=mkl-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=gediminas-LljXPT5IorFWk0Htik3J/w@public.gmane.org \
--cc=info-La43T0Mi4bH5xCKuJOYmCvaTkwRoYoCU@public.gmane.org \
--cc=krumboeck-Hi41barv6paIERSsAYjmKA@public.gmane.org \
--cc=linux-can-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).