Re: [RFC v2 0/7] pch_can/c_can: fix races and add PCH support to c_can

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

On 12/06/2012 03:31 PM, Wolfgang Grandegger wrote:
>>  
>>  static void c_can_pci_write_reg_32bit(struct c_can_priv *priv,
>>                                       enum reg index, u16 val)
>>  {
>> -       iowrite32((u32)val, priv->base + 2 * priv->regs[index]);
>> +       u16 reg;
>> +       unsigned long flags;
>> +       int retries;
>> +
>> +       retries = 0;
>> +
>> +       spin_lock_irqsave(&priv->testlock, flags);
>> +
>> +       do
>> +       {
>> +               iowrite32((u32)val, priv->base + 2 * priv->regs[index]);
> 
> I think it's enough to write the message once.

It's a different test, but also very interesting.

> 
>> +               reg = (u16)ioread32(priv->base + 2 * priv->regs[index]);
>> +               if (reg != val)
>> +               {
>> +                       netdev_err(priv->dev, "write 0x%x to offset 0x%x failed. got: 0x%x\n", val, 2 * priv->regs[index], reg);
>> +               }
>> +       } while ((reg != val) && (retries++ < 20));
>> +       spin_unlock_irqrestore(&priv->testlock, flags);
>>  }
>>  
>>  static void c_can_pci_reset_pch(const struct c_can_priv *priv, bool enable)> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]