linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Christian Bendele <Christian.Bendele@gmx.net>
Cc: linux-can@vger.kernel.org
Subject: Re: [RFC v3 0/7] pch_can/c_can: fix races and add PCH support to c_can
Date: Wed, 12 Dec 2012 14:42:26 +0100	[thread overview]
Message-ID: <50C889C2.2040305@grandegger.com> (raw)
In-Reply-To: <loom.20121212T131741-530@post.gmane.org>

On 12/12/2012 01:51 PM, Christian Bendele wrote:
> Wolfgang Grandegger <wg <at> grandegger.com> writes:
> 
>>
>> Hello,
>>
>> here is v3 of my patches for the C_CAN drivers.
> 
> What are those patches against? They don't apply against current mainstream
> kernel (3.7)... 

They are against David Miller's "net-next" tree, which you can get as
shown below:

git clone --reference=<another-recent-linux-tree> \
	git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

>> Anyway, we now know that the handling of reveive objects is not water-
>> proof. To fix out-of-order receipten we should implement an improved
>> algorithm as suggested by Marc here:
>>
>>   http://marc.info/?l=linux-can&m=135487418225533&w=2

> 
> I'd like to take a look at this, but unfortunately that link consistently times
> out for me.

Try http://news.gmane.org/gmane.linux.can instead. Search for:

7 Dec 10:55	Marc Kleine-Budde	
***********	[RFC v2 0/7] pch_can/c_can: fix races and add PCH support to c_can

>> I will not have time to look into that befoer Xmas. Volunteers are
>> welcome.
> 
> Pfffffft.... Personally I wouldn't be opposed to investing some time in this,
> but I don't think I could get this cleared through legal in any useful time 
> frame. 
> Definitely not before next year. If there's still a lot of work left in January
> I'll give it a try.

Hope I will find the time before beginning of next year. Anyway, would
be nice ifyou could give the c_can_pci driver a try to see if it works
better than the pch_can.

Thanks,

Wolfgang,


      reply	other threads:[~2012-12-12 13:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 21:18 [RFC v3 0/7] pch_can/c_can: fix races and add PCH support to c_can Wolfgang Grandegger
2012-12-11 21:18 ` [RFC v3 1/7] pch_can: add spinlocks to protect tx objects Wolfgang Grandegger
2013-06-20 14:29   ` Michael Pellegrini
     [not found]   ` <CAGY4fa-e6foJTzX9cKhNKgeJHfmyi_QsvO8k+94YVzHVM+BAtw@mail.gmail.com>
2013-06-21 10:11     ` Wolfgang Grandegger
2012-12-11 21:18 ` [RFC v3 2/7] c_can: rename callback "initram" to "init" to more general usage Wolfgang Grandegger
2012-12-11 21:18 ` [RFC v3 3/7] c_can: use different sets of interface registers for rx and tx Wolfgang Grandegger
2012-12-11 21:18 ` [RFC v3 4/7] c_can: add spinlock to protect tx objects Wolfgang Grandegger
2012-12-11 21:18 ` [RFC v3 5/7] c_can_pci: introduce board specific PCI bar Wolfgang Grandegger
2012-12-11 21:18 ` [RFC v3 6/7] c_can_pci: enable PCI bus master only for MSI Wolfgang Grandegger
2012-12-11 21:18 ` [RFC v3 7/7] c_can_pci: add support for PCH CAN on Intel EG20T PCH Wolfgang Grandegger
2012-12-12 12:51 ` [RFC v3 0/7] pch_can/c_can: fix races and add PCH support to c_can Christian Bendele
2012-12-12 13:42   ` Wolfgang Grandegger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C889C2.2040305@grandegger.com \
    --to=wg@grandegger.com \
    --cc=Christian.Bendele@gmx.net \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).