From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Bernd Krumböck" <krumboeck@universalnet.at>
Cc: Bernd Krumboeck <b.krumboeck@gmail.com>,
linux-can@vger.kernel.org, linux-usb@vger.kernel.org,
info@gerhard-bertelsmann.de, gediminas@8devices.com
Subject: Re: [PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices
Date: Fri, 14 Dec 2012 19:30:34 +0100 [thread overview]
Message-ID: <50CB704A.8050704@pengutronix.de> (raw)
In-Reply-To: <95c24a1d2b44b779fc4022a4f5ea6961.squirrel@webmail.universalnet.at>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On 12/14/2012 07:22 PM, "Bernd Krumböck" wrote:
> Hello Marc!
>
>> Looks good to me. Minor style issue inline. Please provide a
>> documentation for the sysfs entries and place it under:
>> Documentation/ABI/testing/sysfs-platform.
>
> Should I change the sysfs path to /sys/devices/platform/usb_8dev? At the
> moment the path is /sys/bus/usb/devices/<busnum>:<devnum>.
Sorry, my fault. I copied the sysfs path from the at91 driver, which is
a platform, not a USB driver. There are several usb descriptions under
Documentation/ABI/testing/ see which way to describe your device fits best.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]
next prev parent reply other threads:[~2012-12-14 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 18:40 [PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices Bernd Krumboeck
2012-12-14 11:59 ` Marc Kleine-Budde
2012-12-14 18:22 ` "Bernd Krumböck"
2012-12-14 18:30 ` Marc Kleine-Budde [this message]
2012-12-14 12:53 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CB704A.8050704@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=b.krumboeck@gmail.com \
--cc=gediminas@8devices.com \
--cc=info@gerhard-bertelsmann.de \
--cc=krumboeck@universalnet.at \
--cc=linux-can@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).